[3.14] gh-150372: Add missing null check on completer_word_break_characters in readline.c (GH-150251) (GH-150629)

miss-islington · KowalskiThomas · web-flow · commit dbe802c52270 · 2026-05-31T14:59:17.000+03:00
(cherry picked from commit 56bd9ea) Co-authored-by: Thomas Kowalski <thom.kowa@gmail.com>
diff --git a/Misc/NEWS.d/next/Library/2026-05-25-07-22-05.gh-issue-150372.9hLqhe.rst b/Misc/NEWS.d/next/Library/2026-05-25-07-22-05.gh-issue-150372.9hLqhe.rst
@@ -0,0 +1,2 @@
+:mod:`readline`: Fix a potential crash during tab completion caused by an
+out-of-memory error during module initialization.
diff --git a/Modules/readline.c b/Modules/readline.c
@@ -1382,6 +1382,10 @@ setup_readline(readlinestate *mod_state)
     completer_word_break_characters =
         strdup(" \t\n`~!@#$%^&*()-=+[{]}\\|;:'\",<>/?");
         /* All nonalphanums except '.' */
+
+    if (!completer_word_break_characters) {
+        goto error;
+    }
 #ifdef WITH_EDITLINE
     // libedit uses rl_basic_word_break_characters instead of
     // rl_completer_word_break_characters as complete delimiter
@@ -1425,6 +1429,10 @@ setup_readline(readlinestate *mod_state)
 
     RESTORE_LOCALE(saved_locale)
     return 0;
+
+error:
+    RESTORE_LOCALE(saved_locale)
+    return -1;
 }
 
 /* Wrapper around GNU readline that handles signals differently. */

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+:mod:`readline`: Fix a potential crash during tab completion caused by an
	`2`	`+out-of-memory error during module initialization.`