Eliminate a big block of duplicate code in PySequence_List() by

rhettinger · rhettinger · commit 8ca92ae54c3c · 2004-03-11T09:13:12.000Z
exposing _PyList_Extend().
diff --git a/Include/listobject.h b/Include/listobject.h
@@ -41,6 +41,7 @@ PyAPI_FUNC(int) PyList_SetSlice(PyObject *, int, int, PyObject *);
 PyAPI_FUNC(int) PyList_Sort(PyObject *);
 PyAPI_FUNC(int) PyList_Reverse(PyObject *);
 PyAPI_FUNC(PyObject *) PyList_AsTuple(PyObject *);
+PyAPI_FUNC(PyObject *) _PyList_Extend(PyListObject *, PyObject *);
 
 /* Macro, trading safety for speed */
 #define PyList_GET_ITEM(op, i) (((PyListObject *)(op))->ob_item[i])
diff --git a/Objects/abstract.c b/Objects/abstract.c
@@ -1427,69 +1427,21 @@ PySequence_Tuple(PyObject *v)
 PyObject *
 PySequence_List(PyObject *v)
 {
-	PyObject *it;      /* iter(v) */
 	PyObject *result;  /* result list */
-	int n;		   /* guess for result list size */
-	int i;
+	PyObject *rv;      /* return value from PyList_Extend */
 
 	if (v == NULL)
 		return null_error();
 
-	/* Special-case list(a_list), for speed. */
-	if (PyList_Check(v))
-		return PyList_GetSlice(v, 0, PyList_GET_SIZE(v));
-
-	/* Get iterator.  There may be some low-level efficiency to be gained
-	 * by caching the tp_iternext slot instead of using PyIter_Next()
-	 * later, but premature optimization is the root etc.
-	 */
-	it = PyObject_GetIter(v);
-	if (it == NULL)
+	result = PyList_New(0);
+	if (result == NULL)
 		return NULL;
 
-	/* Guess a result list size. */
-	n = PyObject_Size(v);
-	if (n < 0) {
-		PyErr_Clear();
-		n = 8;	/* arbitrary */
-	}
-	result = PyList_New(n);
-	if (result == NULL) {
-		Py_DECREF(it);
+	rv = _PyList_Extend((PyListObject *)result, v);
+	if (rv == NULL) {
+		Py_DECREF(result);
 		return NULL;
 	}
-
-	/* Run iterator to exhaustion. */
-	for (i = 0; ; i++) {
-		PyObject *item = PyIter_Next(it);
-		if (item == NULL) {
-			if (PyErr_Occurred()) {
-				Py_DECREF(result);
-				result = NULL;
-			}
-			break;
-		}
-		if (i < n)
-			PyList_SET_ITEM(result, i, item); /* steals ref */
-		else {
-			int status = PyList_Append(result, item);
-			Py_DECREF(item);  /* append creates a new ref */
-			if (status < 0) {
-				Py_DECREF(result);
-				result = NULL;
-				break;
-			}
-		}
-	}
-
-	/* Cut back result list if initial guess was too large. */
-	if (i < n && result != NULL) {
-		if (PyList_SetSlice(result, i, n, (PyObject *)NULL) != 0) {
-			Py_DECREF(result);
-			result = NULL;
-		}
-	}
-	Py_DECREF(it);
 	return result;
 }
 
diff --git a/Objects/listobject.c b/Objects/listobject.c
@@ -776,6 +776,12 @@ listextend(PyListObject *self, PyObject *b)
 	return NULL;
 }
 
+PyObject *
+_PyList_Extend(PyListObject *self, PyObject *b)
+{
+	return listextend(self, b);
+}
+
 static PyObject *
 list_inplace_concat(PyListObject *self, PyObject *other)
 {

Original file line number	Diff line number	Diff line change
`@@ -776,6 +776,12 @@ listextend(PyListObject self, PyObject b)`
`776`	`776`	`return NULL;`
`777`	`777`	`}`
`778`	`778`
	`779`	`+PyObject *`
	`780`	`+_PyList_Extend(PyListObject self, PyObject b)`
	`781`	`+{`
	`782`	`+ return listextend(self, b);`
	`783`	`+}`
	`784`	`+`
`779`	`785`	`static PyObject *`
`780`	`786`	`list_inplace_concat(PyListObject self, PyObject other)`
`781`	`787`	`{`