Skip to content

Commit 30d8e16

Browse files
committed
Cleanup this test's modification of os.environ in teardown (this already
exists in 3.4 but apparently wasn't done for 3.3).
1 parent 162307f commit 30d8e16

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

Lib/test/test_urllib2_localnet.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,12 +353,15 @@ class TestUrlopen(unittest.TestCase):
353353
def setUp(self):
354354
super(TestUrlopen, self).setUp()
355355
# Ignore proxies for localhost tests.
356+
self.old_environ = os.environ.copy()
356357
os.environ['NO_PROXY'] = '*'
357358
self.server = None
358359

359360
def tearDown(self):
360361
if self.server is not None:
361362
self.server.stop()
363+
os.environ.clear()
364+
os.environ.update(self.old_environ)
362365
super(TestUrlopen, self).tearDown()
363366

364367
def urlopen(self, url, data=None, **kwargs):

0 commit comments

Comments
 (0)