Skip to content

Add Bill of Materials - #561

Merged
brian-brazil merged 2 commits into
prometheus:masterfrom
twz123:add-bom
Jul 17, 2020
Merged

Add Bill of Materials#561
brian-brazil merged 2 commits into
prometheus:masterfrom
twz123:add-bom

Conversation

@twz123

@twz123 twz123 commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

Fixes #508.

Fixes #508.

Signed-off-by: Tom Wieczorek <t.wieczorek@yieldlab.de>
Comment thread simpleclient_bom/pom.xml Outdated
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>simpleclient</artifactId>
<version>${project.version}</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use variables, there's some build system out there that can't handle them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, didn't know. Which one?

I'll try to fix that. Without variables, we'll need some special handling for releases, so that versions are changed accordingly. Let's see...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was some years ago, so I don't recall offhand.

I'd expect that mvn would update everything automatically, as it already does that for the other versions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. The release plugin handles this out of the box just fine. It seems to rewrite versions for all projects in the reactor everywhere. I thought it would just update the parent version.

The maven release plugin handles the version updates in the
dependencyManagement section just fine.

Signed-off-by: Tom Wieczorek <t.wieczorek@yieldlab.de>
@brian-brazil
brian-brazil merged commit 2009e7d into prometheus:master Jul 17, 2020
@brian-brazil

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish a BOM

2 participants