-
Notifications
You must be signed in to change notification settings - Fork 22
Comparing changes
Open a pull request
base repository: oxidecomputer/console
base: main
head repository: oxidecomputer/console
compare: oxql-builder
- 16 commits
- 34 files changed
- 3 contributors
Commits on Jul 21, 2026
-
Getting these in puts us in a spot where we can pretty easily see the differences between uplot and recharts.
Configuration menu - View commit details
-
Copy full SHA for 3301582 - Browse repository at this point
Copy the full SHA 3301582View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c57526 - Browse repository at this point
Copy the full SHA 3c57526View commit details -
Migrate from recharts to uplot
Verbose, but fairly straightforward. The only meaningful changes you should see are the lack of a top grid line (since uplot does tick calculation, this would often be quite tight with the line below) and uplot's tick selection logic replacing ours (which is for the greater good).
Configuration menu - View commit details
-
Copy full SHA for 633e5e0 - Browse repository at this point
Copy the full SHA 633e5e0View commit details -
Use theme variables for colors and fonts
Any canvas drawing element is going to need themes this way. I considered doing something more involved, like computing the style within the subscription, or actually making a the subscription an effect hook, but the thing is, you kind of want to only use getComputedStyle consciously.
Configuration menu - View commit details
-
Copy full SHA for 27f4db9 - Browse repository at this point
Copy the full SHA 27f4db9View commit details -
Add guard against accidental recreations from formatter prop
If you passed an anonymous function as the yAxisTickFormatter, that would cause rerender cycles that screwed with hovering, because the graph was being constantly re-created. You could say the caller is just responsible for not doing that, but I was feeling generous.
Configuration menu - View commit details
-
Copy full SHA for a56a8d3 - Browse repository at this point
Copy the full SHA a56a8d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e153db - Browse repository at this point
Copy the full SHA 9e153dbView commit details
Commits on Jul 24, 2026
-
Configuration menu - View commit details
-
Copy full SHA for c8e2b78 - Browse repository at this point
Copy the full SHA c8e2b78View commit details
Commits on Jul 28, 2026
-
Revert "Fix uPlot initialization in production builds"
This reverts commit 9e153db.
Configuration menu - View commit details
-
Copy full SHA for b54ad40 - Browse repository at this point
Copy the full SHA b54ad40View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2fc380 - Browse repository at this point
Copy the full SHA b2fc380View commit details
Commits on Jul 31, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 1c8a4bc - Browse repository at this point
Copy the full SHA 1c8a4bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b26d17d - Browse repository at this point
Copy the full SHA b26d17dView commit details -
Add an OxQL explorer page, support multiline charts
This also makes some design decisions unilaterally, such as a rotating color palette, and legends/what they look like.
Configuration menu - View commit details
-
Copy full SHA for 487aadc - Browse repository at this point
Copy the full SHA 487aadcView commit details -
Put in some sort of tooltip support for multi-line charts
I'm not entirely sure this is what we're going to love. As you drag the mouse around, the alpha changes are quite noisy. I wonder if we can get by with just highlighting the active point (instead of _all_ the points on that X) and stick the color itself in the tooltip? The other thought I'm having here: in the legend, there's not much to do other than throw all the legend values in line like that (or come up with aliases, but then you need some sort of hover). Within a tooltip, though, this could be actually formatted!
Configuration menu - View commit details
-
Copy full SHA for 3007c24 - Browse repository at this point
Copy the full SHA 3007c24View commit details -
Add button to prefill some arbitrary queries
Maybe we'll actually hang on to something like this in the long run, but for now it's just plain handy.
Configuration menu - View commit details
-
Copy full SHA for 4e782d0 - Browse repository at this point
Copy the full SHA 4e782d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41acc7c - Browse repository at this point
Copy the full SHA 41acc7cView commit details -
💩 Kludge in some syntax highlighting
I don't think there's a reasonable way to use the design system for this directly at the moment!
Configuration menu - View commit details
-
Copy full SHA for 90c0aeb - Browse repository at this point
Copy the full SHA 90c0aebView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...oxql-builder