Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oxidecomputer/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: oxidecomputer/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: oxql-builder
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 34 files changed
  • 3 contributors

Commits on Jul 21, 2026

  1. Add a couple tooltip tests

    Getting these in puts us in a spot where we can pretty easily see the
    differences between uplot and recharts.
    fakemonster committed Jul 21, 2026
    Configuration menu
    Copy the full SHA
    3301582 View commit details
    Browse the repository at this point in the history
  2. Get bash from env

    This is just a touch more portable.
    fakemonster committed Jul 21, 2026
    Configuration menu
    Copy the full SHA
    3c57526 View commit details
    Browse the repository at this point in the history
  3. Migrate from recharts to uplot

    Verbose, but fairly straightforward. The only meaningful changes you
    should see are the lack of a top grid line (since uplot does tick
    calculation, this would often be quite tight with the line below) and
    uplot's tick selection logic replacing ours (which is for the greater
    good).
    fakemonster committed Jul 21, 2026
    Configuration menu
    Copy the full SHA
    633e5e0 View commit details
    Browse the repository at this point in the history
  4. Use theme variables for colors and fonts

    Any canvas drawing element is going to need themes this way. I
    considered doing something more involved, like computing the style
    within the subscription, or actually making a the subscription an effect
    hook, but the thing is, you kind of want to only use getComputedStyle
    consciously.
    fakemonster committed Jul 21, 2026
    Configuration menu
    Copy the full SHA
    27f4db9 View commit details
    Browse the repository at this point in the history
  5. Add guard against accidental recreations from formatter prop

    If you passed an anonymous function as the yAxisTickFormatter, that
    would cause rerender cycles that screwed with hovering, because the
    graph was being constantly re-created. You could say the caller is just
    responsible for not doing that, but I was feeling generous.
    fakemonster committed Jul 21, 2026
    Configuration menu
    Copy the full SHA
    a56a8d3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9e153db View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2026

  1. Configuration menu
    Copy the full SHA
    c8e2b78 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2026

  1. Revert "Fix uPlot initialization in production builds"

    This reverts commit 9e153db.
    fakemonster committed Jul 28, 2026
    Configuration menu
    Copy the full SHA
    b54ad40 View commit details
    Browse the repository at this point in the history
  2. Avoid recalculating paths

    fakemonster committed Jul 28, 2026
    Configuration menu
    Copy the full SHA
    b2fc380 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2026

  1. Pick a better color name

    fakemonster committed Jul 31, 2026
    Configuration menu
    Copy the full SHA
    1c8a4bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b26d17d View commit details
    Browse the repository at this point in the history
  3. Add an OxQL explorer page, support multiline charts

    This also makes some design decisions unilaterally, such as a rotating
    color palette, and legends/what they look like.
    fakemonster committed Jul 31, 2026
    Configuration menu
    Copy the full SHA
    487aadc View commit details
    Browse the repository at this point in the history
  4. Put in some sort of tooltip support for multi-line charts

    I'm not entirely sure this is what we're going to love. As you drag the
    mouse around, the alpha changes are quite noisy. I wonder if we can get
    by with just highlighting the active point (instead of _all_ the points
    on that X) and stick the color itself in the tooltip?
    
    The other thought I'm having here: in the legend, there's not much to do
    other than throw all the legend values in line like that (or come up
    with aliases, but then you need some sort of hover). Within a tooltip,
    though, this could be actually formatted!
    fakemonster committed Jul 31, 2026
    Configuration menu
    Copy the full SHA
    3007c24 View commit details
    Browse the repository at this point in the history
  5. Add button to prefill some arbitrary queries

    Maybe we'll actually hang on to something like this in the long run, but
    for now it's just plain handy.
    fakemonster committed Jul 31, 2026
    Configuration menu
    Copy the full SHA
    4e782d0 View commit details
    Browse the repository at this point in the history
  6. 🤖 Add a builder

    fakemonster committed Jul 31, 2026
    Configuration menu
    Copy the full SHA
    41acc7c View commit details
    Browse the repository at this point in the history
  7. 💩 Kludge in some syntax highlighting

    I don't think there's a reasonable way to use the design system for this
    directly at the moment!
    fakemonster committed Jul 31, 2026
    Configuration menu
    Copy the full SHA
    90c0aeb View commit details
    Browse the repository at this point in the history
Loading