PR doesn't modify when the branch is renamed and further merging to the renamed branch doesn't push to the PR branch #196967
Replies: 4 comments
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
It somehow orphans the PR in the process of renaming + retargeting |
Beta Was this translation helpful? Give feedback.
-
|
This looks like the PR metadata is still pointing to the original branch reference even after the branch rename operation completed successfully. From what I can tell:
So the PR appears to remain attached to the stale branch ref internally. This is especially problematic for automation workflows like release-please where branch names may be regenerated or renamed dynamically. A few things that may help narrow this down:
It may also be worth checking whether the PR stores the branch by immutable ref ID vs branch name string, since this behavior suggests the linkage is name-based and not being reconciled after rename events. |
Beta Was this translation helpful? Give feedback.
-
|
I overcame this by updating the ref instead of renaming and deleting the branch, but there shouldn't be dangling PRs like the above one I guess. Seems weird, it should probably error out instead of being stuck at the loading screen I guess. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
🏷️ Discussion Type
Bug
Body
PR doesn't modify when the branch is renamed and further merging to the renamed branch doesn't push to the PR branch
Basically if you see this
https://github.com/openfga/release-automation-test/pull/11
If you see the branch name it has modified from https://github.com/openfga/release-automation-test/tree/release-please--branches--main--components--pkg/js
AS it is mentioned here
But the PR doesn't get updated to be from this branch
https://github.com/openfga/release-automation-test/pull/11
Beta Was this translation helpful? Give feedback.
All reactions