Code coverage on pull requests is now in public preview 🚀 #194833
Replies: 13 comments 14 replies
-
|
Great addition! Although i would have expect to first see test results / code coverage results in a github action before getting results in a PR? is that something that is considered? |
Beta Was this translation helpful? Give feedback.
-
|
Nice feature! Is it possible to see current coverage in the default branch? |
Beta Was this translation helpful? Give feedback.
-
|
And how much should we expect to be paying after the preview period? |
Beta Was this translation helpful? Give feedback.
-
|
Are there plans to extend this to work with PRs from forks as well? |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for shipping this preview. I ran into a confusing file-level summary with a Go workspace that uploads a Cobertura report generated from multiple Go modules. A concrete example is this PR: abema/crema#61 In the Cobertura XML, packages are distinct, e.g. It would be helpful if the PR coverage UI disambiguated files by repo-relative path or package/module path when there are duplicate filenames. For example, showing |
Beta Was this translation helpful? Give feedback.
-
|
Will this have any special pricing for opensource projects |
Beta Was this translation helpful? Give feedback.
-
|
Very cool feature. Is there any plan to add inline coverage feedback (similar to toggling blame on and off) within the PR diff itself? I think one of the best uses of this deep integration is for the code reviewer to know "these lines are/aren't covered by tests" while they are doing their review. |
Beta Was this translation helpful? Give feedback.
-
|
We've been looking for this for a while - finally! 🎉 A few pieces of feedback from a first pass:
Thanks again for shipping the preview! |
Beta Was this translation helpful? Give feedback.
-
|
Silly question; are there examples what the reports look like? I found an example posted by someone in this thread; abema/crema#61 (comment) which seems very limited and to be just a flat markdown table with percentages per package (no options to "drill down" the report to see coverage per line), or are more extended reports available elsewhere? |
Beta Was this translation helpful? Give feedback.
-
|
We got excited when seeing this announcement, and were hoping this could replace uses of CodeCov to cut down our list of dependencies / dependency services. Unfortunately, I don't think this feature will be useful to us in its current form.
(Going slightly orthogonal, but hope it's useful nonetheless); what I'm looking for is for GitHub to provide reports over time; not just Code Coverage, but also (e.g.) test results, benchmark results.
These are all incremental, and often "marginal", changes, but they will accumulate over time. Tests may turn out to be flaky, we may have lost X% coverage in a package between two releases, a test may have become slow, and overall CI time increased with X minutes, and our binary sizes may have doubled. Having reports on individual pull request is useful (but much already possible with custom actions generating a report); having dashboards and reports at the repository / branch level, over time, would be much more useful (and something GitHub may be best to provide). |
Beta Was this translation helpful? Give feedback.
-
|
What’s the point of specifying the language? Code coverage may span multiple languages. Also, other code coverage integrations (CodeCov / GitLab) work without having to specify this. |
Beta Was this translation helpful? Give feedback.
-
|
This is a really cool feature, probably one of the most obvious missing features in GitHub that I would expect from a git provider. Please add a proper UI for this in merge requests and GitHub Actions. Code coverage is not a comment. Using comments for integrations are a bit of a hack. Have a look at GitLab and CodeCov for inspiration. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, been waiting for something like this so really glad to see the start of it 😀 Some repositories have a separate workflow for default branches and pull requests as they can be quite complicated and have therefore have dedicated flows. Is this feature going to be compatible with repositories that have pull requests and default branches running separate workflows? The picker in the repository settings only lets you select one workflow - which one should be selected? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Code coverage metrics are now in public preview for all GitHub Code Quality users on github.com.
You can now see an aggregate percent of code covered directly on pull requests, giving reviewers a clear signal to help evaluate test completeness before merging. With coverage context in the pull request experience, your team can make faster, higher-confidence review decisions without switching to a separate tool.
To get started, enable code coverage for your repository and upload a Cobertura report from your existing CI workflow using the upload-code-coverage action.
Permissions
GitHub Apps and Actions workflows require the new
code-quality:writefine-grained permission to upload code coverage reports to GitHub.Availability and pricing
GitHub Code Quality is available today for GitHub Enterprise Cloud and Team, but isn’t yet available on GitHub Enterprise Server. It’s free during the preview period.
Learn more
Beta Was this translation helpful? Give feedback.
All reactions