Correctly define copy assignment operators.

rolftimmermans · Gabriel Schulhof · commit 734725e97114 · 2019-12-03T14:39:39.000-08:00
diff --git a/napi-inl.h b/napi-inl.h
@@ -2120,7 +2120,7 @@ inline Error& Error::operator =(Error&& other) {
 inline Error::Error(const Error& other) : ObjectReference(other) {
 }
 
-inline Error& Error::operator =(Error& other) {
+inline Error& Error::operator =(const Error& other) {
   Reset();
 
   _env = other.Env();
diff --git a/napi.h b/napi.h
@@ -1108,7 +1108,7 @@ namespace Napi {
     // A reference can be moved but cannot be copied.
     Reference(Reference<T>&& other);
     Reference<T>& operator =(Reference<T>&& other);
-    Reference<T>& operator =(Reference<T>&) = delete;
+    Reference<T>& operator =(const Reference<T>&) = delete;
 
     operator napi_ref() const;
     bool operator ==(const Reference<T> &other) const;
@@ -1153,7 +1153,7 @@ namespace Napi {
     ObjectReference& operator =(Reference<Object>&& other);
     ObjectReference(ObjectReference&& other);
     ObjectReference& operator =(ObjectReference&& other);
-    ObjectReference& operator =(ObjectReference&) = delete;
+    ObjectReference& operator =(const ObjectReference&) = delete;
 
     Napi::Value Get(const char* utf8name) const;
     Napi::Value Get(const std::string& utf8name) const;
@@ -1191,7 +1191,7 @@ namespace Napi {
     FunctionReference(FunctionReference&& other);
     FunctionReference& operator =(FunctionReference&& other);
     FunctionReference(const FunctionReference&) = delete;
-    FunctionReference& operator =(FunctionReference&) = delete;
+    FunctionReference& operator =(const FunctionReference&) = delete;
 
     Napi::Value operator ()(const std::initializer_list<napi_value>& args) const;
 
@@ -1333,7 +1333,7 @@ namespace Napi {
     Error(Error&& other);
     Error& operator =(Error&& other);
     Error(const Error&);
-    Error& operator =(Error&);
+    Error& operator =(const Error&);
 
     const std::string& Message() const NAPI_NOEXCEPT;
     void ThrowAsJavaScriptException() const;
@@ -1806,7 +1806,7 @@ namespace Napi {
     AsyncContext(AsyncContext&& other);
     AsyncContext& operator =(AsyncContext&& other);
     AsyncContext(const AsyncContext&) = delete;
-    AsyncContext& operator =(AsyncContext&) = delete;
+    AsyncContext& operator =(const AsyncContext&) = delete;
 
     operator napi_async_context() const;
 
@@ -1825,7 +1825,7 @@ namespace Napi {
     AsyncWorker(AsyncWorker&& other);
     AsyncWorker& operator =(AsyncWorker&& other);
     AsyncWorker(const AsyncWorker&) = delete;
-    AsyncWorker& operator =(AsyncWorker&) = delete;
+    AsyncWorker& operator =(const AsyncWorker&) = delete;
 
     operator napi_async_work() const;
 

Original file line number	Diff line number	Diff line change
`@@ -2120,7 +2120,7 @@ inline Error& Error::operator =(Error&& other) {`
`2120`	`2120`	`inline Error::Error(const Error& other) : ObjectReference(other) {`
`2121`	`2121`	`}`
`2122`	`2122`
`2123`		`-inline Error& Error::operator =(Error& other) {`
	`2123`	`+inline Error& Error::operator =(const Error& other) {`
`2124`	`2124`	`Reset();`
`2125`	`2125`
`2126`	`2126`	`_env = other.Env();`