From 59ecdf004ba3d5616915da9842d3cc5dce70b7d0 Mon Sep 17 00:00:00 2001 From: Tyler Wanek Date: Thu, 18 Feb 2016 08:16:58 -0700 Subject: [PATCH] Don't check for \\ No newline at end of file\n if it can't exist --- .../templates/manual/src/convenient_patch.cc | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/generate/templates/manual/src/convenient_patch.cc b/generate/templates/manual/src/convenient_patch.cc index ff4d54306..adc324988 100644 --- a/generate/templates/manual/src/convenient_patch.cc +++ b/generate/templates/manual/src/convenient_patch.cc @@ -75,13 +75,17 @@ PatchData *createFromRaw(git_patch *raw) { const git_diff_line *line; git_patch_get_line_in_hunk(&line, raw, i, j); - if ( - j == 0 && - !strcmp( - &line->content[strlen(line->content) - 29], - "\n\\ No newline at end of file\n" - )) { - EOFFlag = true; + if (j == 0) { + // calculate strlen only once for the first line of the first hunk. + int calculatedContentLength = strlen(line->content); + if ( + calculatedContentLength > 29 && + !strcmp( + &line->content[calculatedContentLength - 29], + "\n\\ No newline at end of file\n" + )) { + EOFFlag = true; + } } storeLine->origin = line->origin;