From 9e790942642c897783da992cd9742dd9fe84b2eb Mon Sep 17 00:00:00 2001 From: John Haley Date: Tue, 19 May 2015 12:51:02 -0700 Subject: [PATCH 1/4] Add failing test --- test/tests/attr.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/tests/attr.js b/test/tests/attr.js index cf229d372..d69cc5599 100644 --- a/test/tests/attr.js +++ b/test/tests/attr.js @@ -19,6 +19,10 @@ describe("Attr", function() { }); }); + it("breaks right now", function() { + assert.equal(1, 0); + }); + it("can add a macro definition", function() { var error = Attr.addMacro(this.repository, "binary", "-diff -crlf"); From c67217938031ff62f5b4f31a2d77da850c5b88c0 Mon Sep 17 00:00:00 2001 From: John Haley Date: Tue, 19 May 2015 14:52:40 -0700 Subject: [PATCH 2/4] Tests call `process.exit` on close now For some reason, CI tests always report a success if we don't kill the process. --- test/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/index.js b/test/index.js index c78082e31..bde4d989c 100644 --- a/test/index.js +++ b/test/index.js @@ -15,4 +15,4 @@ var args = cov.concat([ "--expose-gc" ]); -fork(bin, args, { cwd: path.join(__dirname, "../") }); +fork(bin, args, { cwd: path.join(__dirname, "../") }).on("close", process.exit); From 82ba6af879cf87d7b0d5551a0ae19a7251a9464c Mon Sep 17 00:00:00 2001 From: John Haley Date: Tue, 19 May 2015 15:06:44 -0700 Subject: [PATCH 3/4] Revert "Add failing test" This reverts commit 9e790942642c897783da992cd9742dd9fe84b2eb. --- test/tests/attr.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/tests/attr.js b/test/tests/attr.js index d69cc5599..cf229d372 100644 --- a/test/tests/attr.js +++ b/test/tests/attr.js @@ -19,10 +19,6 @@ describe("Attr", function() { }); }); - it("breaks right now", function() { - assert.equal(1, 0); - }); - it("can add a macro definition", function() { var error = Attr.addMacro(this.repository, "binary", "-diff -crlf"); From 5b928ee655482fb1a709b22251b635f954f0c119 Mon Sep 17 00:00:00 2001 From: John Haley Date: Tue, 19 May 2015 15:20:49 -0700 Subject: [PATCH 4/4] Update travis to use io.js v1.x --- .travis.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 426563ef4..6cf313285 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,12 +2,9 @@ env: matrix: - export NODE_VERSION="0.10" - export NODE_VERSION="0.12" - - export NODE_VERSION="iojs" + - export NODE_VERSION="iojs-v1" matrix: fast_finish: true - allow_failures: - - env: NODE_VERSION="0.10" - - env: NODE_VERSION="iojs" before_install: - git clone https://github.com/creationix/nvm.git ./.nvm - source ./.nvm/nvm.sh