Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodegit/nodegit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.23.0
Choose a base ref
...
head repository: nodegit/nodegit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.24.0-alpha.1
Choose a head ref
  • 15 commits
  • 25 files changed
  • 2 contributors

Commits on Oct 12, 2018

  1. Configuration menu
    Copy the full SHA
    1be9c37 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6419faf View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. Update descriptor to handle more auto-gc behavior

    - Turns on selfFreeing for basically everything, including the repository
    - Ignores all git_*_free calls
    - Adds ownerFn info used to make associative ownership links between objects that have an exposed link to the repository
    - Added isSingleton flag for repository, this adds reference counting to the repo address externally so that no matter how many v8 objects point to it, only the last GC'd v8 object will free the repository.
    - Added an "ownedBy" field for arguments to enable ownership linking to arbitrary parameters, not just "this"
    - Some additional clean up of things that don't exist or shouldn't exist
    implausible committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    0135189 View commit details
    Browse the repository at this point in the history
  2. Add additional GC behavior that reflects new descriptor format

    - Implements isSingleton behavior with reference counting
    - Implements ownerFn, which ties an arbitrary pointer to a singleton type pointer
    - always calls free, even if object is "owned", the ownership link is about keeping internal pointers alive, but it seems that most calls to free are reference counted in libgit2, but the repository has a different relationship than all other types of ref counted frees.
    implausible committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    2e5451f View commit details
    Browse the repository at this point in the history
  3. git_filter_list has a complex owner scenario and requires adjustments

    I know we will need this in the future for merge drivers and the like. But for now, this will at least show how it could be done.
    implausible committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    a2388e3 View commit details
    Browse the repository at this point in the history
  4. Move this inherited clone behavior into C++ land

    It looks like this is pretty important to preserve, as it broke tests on windows immediately when removing it.
    
    Because we are no longer exposing free methods in javascript land, we will need to manually perform this method at the C++ layer.
    implausible committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    8c5d58b View commit details
    Browse the repository at this point in the history
  5. Fix tests

    implausible committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    335cc01 View commit details
    Browse the repository at this point in the history
  6. Fix Node 6 builds on Mac OS not having unordered_map defined

    Changes minimum support version of MacOS to 10.9.
    emmax86 committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    340e245 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. Improve ownership model

    co-authored-by: Steve King <stevek@axosoft.com>
    implausible and emmax86 committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    d685897 View commit details
    Browse the repository at this point in the history
  2. Ownership updates to descriptor and supplement

    co-authored-by: Steve King <stevek@axosoft.com>
    
    We walked the entire file and compared documentation + struct implementation to try and glean ownership relationships between out parameters and arguments.
    
    Since we had to walk this whole file, and it took about 2 1/2 days, we also spent a little bit of time touching up groupings, definitions, and ignore settings.
    implausible committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    1e1b639 View commit details
    Browse the repository at this point in the history
  3. assign owner to wrappers

    implausible committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    1f8fd84 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ec91f71 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Extraneous test

    implausible committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    a838ce8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1570 from implausible/garbage-collection/free-alm…

    …ost-everything
    
    Garbage collection: Free mostly everything automatically
    implausible authored Oct 25, 2018
    Configuration menu
    Copy the full SHA
    2274679 View commit details
    Browse the repository at this point in the history
  3. Bump to v0.24.0-alpha.1

    implausible committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    3c74b8e View commit details
    Browse the repository at this point in the history
Loading