-
Notifications
You must be signed in to change notification settings - Fork 700
Comparing changes
Open a pull request
base repository: nodegit/nodegit
base: v0.23.0
head repository: nodegit/nodegit
compare: v0.24.0-alpha.1
- 15 commits
- 25 files changed
- 2 contributors
Commits on Oct 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1be9c37 - Browse repository at this point
Copy the full SHA 1be9c37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6419faf - Browse repository at this point
Copy the full SHA 6419fafView commit details
Commits on Oct 17, 2018
-
Update descriptor to handle more auto-gc behavior
- Turns on selfFreeing for basically everything, including the repository - Ignores all git_*_free calls - Adds ownerFn info used to make associative ownership links between objects that have an exposed link to the repository - Added isSingleton flag for repository, this adds reference counting to the repo address externally so that no matter how many v8 objects point to it, only the last GC'd v8 object will free the repository. - Added an "ownedBy" field for arguments to enable ownership linking to arbitrary parameters, not just "this" - Some additional clean up of things that don't exist or shouldn't exist
Configuration menu - View commit details
-
Copy full SHA for 0135189 - Browse repository at this point
Copy the full SHA 0135189View commit details -
Add additional GC behavior that reflects new descriptor format
- Implements isSingleton behavior with reference counting - Implements ownerFn, which ties an arbitrary pointer to a singleton type pointer - always calls free, even if object is "owned", the ownership link is about keeping internal pointers alive, but it seems that most calls to free are reference counted in libgit2, but the repository has a different relationship than all other types of ref counted frees.
Configuration menu - View commit details
-
Copy full SHA for 2e5451f - Browse repository at this point
Copy the full SHA 2e5451fView commit details -
git_filter_list has a complex owner scenario and requires adjustments
I know we will need this in the future for merge drivers and the like. But for now, this will at least show how it could be done.
Configuration menu - View commit details
-
Copy full SHA for a2388e3 - Browse repository at this point
Copy the full SHA a2388e3View commit details -
Move this inherited clone behavior into C++ land
It looks like this is pretty important to preserve, as it broke tests on windows immediately when removing it. Because we are no longer exposing free methods in javascript land, we will need to manually perform this method at the C++ layer.
Configuration menu - View commit details
-
Copy full SHA for 8c5d58b - Browse repository at this point
Copy the full SHA 8c5d58bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 335cc01 - Browse repository at this point
Copy the full SHA 335cc01View commit details -
Fix Node 6 builds on Mac OS not having
unordered_mapdefinedChanges minimum support version of MacOS to 10.9.
Configuration menu - View commit details
-
Copy full SHA for 340e245 - Browse repository at this point
Copy the full SHA 340e245View commit details
Commits on Oct 19, 2018
-
co-authored-by: Steve King <stevek@axosoft.com>
Configuration menu - View commit details
-
Copy full SHA for d685897 - Browse repository at this point
Copy the full SHA d685897View commit details -
Ownership updates to descriptor and supplement
co-authored-by: Steve King <stevek@axosoft.com> We walked the entire file and compared documentation + struct implementation to try and glean ownership relationships between out parameters and arguments. Since we had to walk this whole file, and it took about 2 1/2 days, we also spent a little bit of time touching up groupings, definitions, and ignore settings.
Configuration menu - View commit details
-
Copy full SHA for 1e1b639 - Browse repository at this point
Copy the full SHA 1e1b639View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f8fd84 - Browse repository at this point
Copy the full SHA 1f8fd84View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec91f71 - Browse repository at this point
Copy the full SHA ec91f71View commit details
Commits on Oct 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a838ce8 - Browse repository at this point
Copy the full SHA a838ce8View commit details -
Merge pull request #1570 from implausible/garbage-collection/free-alm…
…ost-everything Garbage collection: Free mostly everything automatically
Configuration menu - View commit details
-
Copy full SHA for 2274679 - Browse repository at this point
Copy the full SHA 2274679View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c74b8e - Browse repository at this point
Copy the full SHA 3c74b8eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.23.0...v0.24.0-alpha.1