Skip to content

Commit 4e880e2

Browse files
committed
implement SocketIO on top of the EventEmitter model
1 parent 8128d23 commit 4e880e2

14 files changed

Lines changed: 371 additions & 334 deletions

javascript/ql/src/semmle/javascript/frameworks/EventEmitter.qll

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,9 @@ module EventRegistration {
117117

118118
abstract DataFlow::Node getReceivedItem(int i);
119119

120-
abstract DataFlow::Node getAReturnedValue();
120+
DataFlow::Node getAReturnedValue() { none() }
121121

122-
abstract EventDispatch::Range getAReturnDispatch();
122+
EventDispatch::Range getAReturnDispatch() { none() }
123123
}
124124

125125
/**
@@ -136,10 +136,6 @@ module EventRegistration {
136136
override DataFlow::Node getReceivedItem(int i) {
137137
result = this.getABoundCallbackParameter(1, i)
138138
}
139-
140-
override DataFlow::Node getAReturnedValue() { none() }
141-
142-
override EventDispatch::Range getAReturnDispatch() { none() }
143139
}
144140
}
145141

@@ -227,3 +223,4 @@ private class EventEmitterTaintStep extends DataFlow::AdditionalFlowStep {
227223
succ = dispatch
228224
}
229225
}
226+

0 commit comments

Comments
 (0)