review comment

subrata-ms · subrata-ms · commit 4a0167d43f1a · 2026-02-24T11:39:57.000Z
diff --git a/mssql_python/cursor.py b/mssql_python/cursor.py
@@ -2576,7 +2576,7 @@ def _bulkcopy(
             RuntimeError: If connection string is not available
         """
         # Fast check if logging is enabled to avoid overhead
-        is_logging = logger.is_debug_enabled
+        is_logging_enabled = logger.is_debug_enabled
 
         try:
             import mssql_py_core
@@ -2667,7 +2667,7 @@ def _bulkcopy(
         try:
             # Only pass logger to Rust if logging is enabled (performance optimization)
             pycore_connection = mssql_py_core.PyCoreConnection(
-                pycore_context, python_logger=logger if is_logging else None
+                pycore_context, python_logger=logger if is_logging_enabled else None
             )
             pycore_cursor = pycore_connection.cursor()
 
@@ -2685,16 +2685,15 @@ def _bulkcopy(
                 keep_nulls=keep_nulls,
                 fire_triggers=fire_triggers,
                 use_internal_transaction=use_internal_transaction,
-                python_logger=logger if is_logging else None,  # Only pass logger if enabled
+                python_logger=logger if is_logging_enabled else None,  # Only pass logger if enabled
             )
 
-            if is_logging:
-                logger.info(
-                    "_bulkcopy: Bulk copy completed successfully - rows_copied=%s, batch_count=%s, elapsed_time=%s",
-                    result.get("rows_copied", "N/A"),
-                    result.get("batch_count", "N/A"),
-                    result.get("elapsed_time", "N/A"),
-                )
+            logger.info(
+                "_bulkcopy: Bulk copy completed successfully - rows_copied=%s, batch_count=%s, elapsed_time=%s",
+                result.get("rows_copied", "N/A"),
+                result.get("batch_count", "N/A"),
+                result.get("elapsed_time", "N/A"),
+            )
 
             return result
 
diff --git a/mssql_python/logging.py b/mssql_python/logging.py
@@ -88,7 +88,7 @@ def __init__(self):
 
         # Create the underlying Python logger
         self._logger = logging.getLogger("mssql_python")
-        self._logger.setLevel(logging.WARNING)  # Allow WARNING and ERROR by default
+        self._logger.setLevel(logging.CRITICAL)  # Disabled by default
         self._logger.propagate = False  # Don't propagate to root logger
 
         # Add trace ID filter (injects thread_id into every log record)
