mderka
diff --git a/‎gcloud-java-core/src/main/java/com/google/gcloud/BatchResult.java‎
Lines changed: 5 additions & 4 deletions b/‎gcloud-java-core/src/main/java/com/google/gcloud/BatchResult.java‎
Lines changed: 5 additions & 4 deletions
diff --git a/‎gcloud-java-core/src/test/java/com/google/gcloud/BatchResultTest.java‎
Lines changed: 70 additions & 0 deletions b/‎gcloud-java-core/src/test/java/com/google/gcloud/BatchResultTest.java‎
Lines changed: 70 additions & 0 deletions
@@ -16,8 +16,11 @@
 
 package com.google.gcloud;
 
+import static com.google.common.base.Preconditions.checkState;
+
 /**
- * This class holds a single result of a batch call.
+ * This class holds a single result of a batch call. {@code T} is the type of the result and
+ * {@code E} is the type of the service-dependent exception thrown when processing error occurs.
  */
 public abstract class BatchResult<T, E extends BaseServiceException> {
 
@@ -40,9 +43,7 @@ public boolean submitted() {
    * @throws E if an error occurred when processing this request
    */
   public T get() throws E {
-    if (!submitted()) {
-      throw new IllegalStateException("Batch has not been submitted yet");
-    }
+    checkState(submitted(), "Batch has not been submitted yet");
     if (error != null) {
       throw error;
     }
 
@@ -0,0 +1,70 @@
+/*
+ * Copyright 2015 Google Inc. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.google.gcloud;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+import org.junit.Before;
+import org.junit.Test;
+
+public class BatchResultTest {
+
+  private BatchResult<Boolean, BaseServiceException> RESULT;
+
+  @Before
+  public void setUp() {
+    RESULT = new BatchResult<Boolean, BaseServiceException>() {};
+  }
+
+  @Test
+  public void testSuccess() {
+    assertFalse(RESULT.submitted());
+    try {
+      RESULT.get();
+      fail("This was not submitted yet.");
+    } catch (IllegalStateException ex) {
+      // expected
+    }
+    RESULT.success(true);
+    assertTrue(RESULT.get());
+  }
+
+  @Test
+  public void testError() {
+    assertFalse(RESULT.submitted());
+    try {
+      RESULT.get();
+      fail("This was not submitted yet.");
+    } catch (IllegalStateException ex) {
+      // expected
+    }
+    BaseServiceException ex = new BaseServiceException(0, "message", "reason", false);
+    RESULT.error(ex);
+    try {
+      RESULT.get();
+      fail("This is a failed operation and should have thrown a DnsException.");
+    } catch (BaseServiceException real) {
+      assertSame(ex, real);
+    }
+  }
+
+  // todo(mderka) test notify when implemented
+
+}