Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python-smpplib/python-smpplib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: lynxis/python-smpplib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on May 30, 2017

  1. re-introduce AlertNotification 

    Since certain SMPP gateways (osmocom/OpenBSC) will send
an AlertNotification, this would result in the following exception:

Traceback (most recent call last):
  File "test.py", line 43, in <module>
    client.listen()
  File "/home/user/python-smpplib/smpplib/client.py", line 275, in listen
    p = self.read_pdu()
  File "/home/user/python-smpplib/smpplib/client.py", line 218, in read_pdu
    p = smpp.parse_pdu(raw_pdu, client=self)
  File "/home/user/python-smpplib/smpplib/smpp.py", line 45, in parse_pdu
    new_pdu = make_pdu(command, **kwargs)
  File "/home/user/python-smpplib/smpplib/smpp.py", line 32, in make_pdu
    f = command.factory(command_name, **kwargs)
  File "/home/user/python-smpplib/smpplib/command.py", line 61, in factory
    'Command "%s" is not supported' % command_name)
smpplib.exceptions.UnknownCommandError: Command "alert_notification" is not supported
    @lynxis
    lynxis committed May 30, 2017
    Configuration menu
    Copy the full SHA
    6d83501 View commit details
    Browse the repository at this point in the history
Loading