-
Notifications
You must be signed in to change notification settings - Fork 453
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: python-control/python-control
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: ldriever/python-control
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 4 files changed
- 1 contributor
Commits on Jul 26, 2020
-
At the very bottom of the existing document I added the clean_ss() function, adjusting it slightly to confirm with the existing imports in the document. Re-wrote the documentation to have the same style as the rest of the document
Configuration menu - View commit details
-
Copy full SHA for 35cebfb - Browse repository at this point
Copy the full SHA 35cebfbView commit details -
Added the clean_tf() function at the bottom of xferfcn.py, adjusting it slightly to be conform with the existing imports in the file and adding one import from another file of the control library. Also adjusted the documentation for the function to match the existing style. Additionally fixed a formatting error in the documentation for clean_ss()
Configuration menu - View commit details
-
Copy full SHA for d3aaafb - Browse repository at this point
Copy the full SHA d3aaafbView commit details -
Added the fival() function at the bottom of thetimeresp.py file, slightly adjusting it to conform with the existing imports in the file and adding a couple of new import statements. Adjusted the documentation so that its format is conform with the rest of the file. Slightly adjusted the format of the documentation for clean_tf() in the xferfcn.py file
Configuration menu - View commit details
-
Copy full SHA for fa100df - Browse repository at this point
Copy the full SHA fa100dfView commit details
Commits on Jul 29, 2020
-
Added the clean() and fival() functions as functions to the TransferF…
…unction and StateSpace classes While the functions clean_ss and clean_tf remain as separate functions in the respective files, the function clean() has been added in the respective form to the TransferFunction ans StateSpace classes. This makes it possible to still go directly from a StateSpace to a clean TransferFunction (or vice versa) but makes it easier to clean either one of the two if it is already in the desired form. The fival function remains as a function in the timeresp.py file, but by importing it to the other two files and including it in the aforementioned classes it is now possible to, for instance, use sys.fival(**) where sys is a StateSpace or TransferFunction.
Configuration menu - View commit details
-
Copy full SHA for 76ec68f - Browse repository at this point
Copy the full SHA 76ec68fView commit details -
Used the property that .clean() is now a function of the TransferFunction class to simplify the code for the clean_tf() function, which performs the same task but opens up the input to not just TrasnferFunction objects but also StateSpace objects.
Configuration menu - View commit details
-
Copy full SHA for 1636e78 - Browse repository at this point
Copy the full SHA 1636e78View commit details
Commits on Jul 30, 2020
-
Fixed cyclical import references
The three files statesp.py, timeresp.py, and xferfcn.py all imported each other in a cyclical manner. I solved this issue by moving the import statements from the global positions at the top of said files to within the respective functions. Additionally I temporarily added a file to test the implementation of the functions using examples.
Configuration menu - View commit details
-
Copy full SHA for d34b8f3 - Browse repository at this point
Copy the full SHA d34b8f3View commit details -
The clean_tf function was not making use of the input, output, and precision values passed to it. Fixed this issue. Also extended the documentation to include that the fival function returns None if an unstable system is checked for stability
Configuration menu - View commit details
-
Copy full SHA for a0d26bf - Browse repository at this point
Copy the full SHA a0d26bfView commit details
Commits on Aug 2, 2020
-
Edited the fival stability check function such that the error message grammatically accounts for one or multiple poles in the right half of the compley plane
Configuration menu - View commit details
-
Copy full SHA for 62ef7ef - Browse repository at this point
Copy the full SHA 62ef7efView commit details -
Clean up the developer branch before merging
The most recent version of tester.py contains information that, while going to be deleted at some point, is as of now still useful
Configuration menu - View commit details
-
Copy full SHA for 5d71c4d - Browse repository at this point
Copy the full SHA 5d71c4dView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...master