Change the design to track addRoot and removeRoot

zhengbli · zhengbli · commit 8ac22ecbb04d · 2016-12-29T17:00:04.000-08:00
diff --git a/src/harness/unittests/tsserverProjectSystem.ts b/src/harness/unittests/tsserverProjectSystem.ts
@@ -1620,7 +1620,7 @@ namespace ts.projectSystem {
             const configureHostRequest = makeSessionRequest<protocol.ConfigureRequestArguments>(CommandNames.Configure, { extraFileExtensions });
             session.executeCommand(configureHostRequest).response;
 
-             // HTML file still not included in the project as it is closed
+            // HTML file still not included in the project as it is closed
             checkNumberOfProjects(projectService, { configuredProjects: 1 });
             checkProjectActualFiles(projectService.configuredProjects[0], [file1.path]);
 
@@ -3053,7 +3053,7 @@ namespace ts.projectSystem {
     });
 
     describe("maxNodeModuleJsDepth for inferred projects", () => {
-        it("should be set by default", () => {
+        it("should be set to 2 if the project has js root files", () => {
             const file1: FileOrFolder = {
                 path: "/a/b/file1.js",
                 content: `var t = require("test"); t.`
@@ -3077,6 +3077,33 @@ namespace ts.projectSystem {
             options = project.getCompilerOptions();
             assert.isTrue(options.maxNodeModuleJsDepth === 2);
         });
+
+        it("should return to normal state when all js root files are removed from project", () => {
+            const file1 = {
+                path: "/a/file1.ts",
+                content: "let x =1;"
+            };
+            const file2 = {
+                path: "/a/file2.js",
+                content: "let x =1;"
+            };
+
+            const host = createServerHost([file1, file2, libFile]);
+            const projectService = createProjectService(host, { useSingleInferredProject: true });
+
+            projectService.openClientFile(file1.path);
+            checkNumberOfInferredProjects(projectService, 1);
+            let project = projectService.inferredProjects[0];
+            assert.isUndefined(project.getCompilerOptions().maxNodeModuleJsDepth);
+
+            projectService.openClientFile(file2.path);
+            project = projectService.inferredProjects[0];
+            assert.isTrue(project.getCompilerOptions().maxNodeModuleJsDepth === 2);
+
+            projectService.closeClientFile(file2.path);
+            project = projectService.inferredProjects[0];
+            assert.isUndefined(project.getCompilerOptions().maxNodeModuleJsDepth);
+        });
     });
 
 }
diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts
@@ -1072,10 +1072,6 @@ namespace ts.server {
                 ? this.inferredProjects[0]
                 : new InferredProject(this, this.documentRegistry, this.compilerOptionsForInferredProjects);
 
-            if (root.scriptKind === ScriptKind.JS || root.scriptKind === ScriptKind.JSX) {
-                project.setAsJsInferredProject();
-            }
-
             project.addRoot(root);
 
             this.directoryWatchers.startWatchingContainingDirectoriesForFile(
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -395,7 +395,9 @@ namespace ts.server {
         }
 
         removeFile(info: ScriptInfo, detachFromProject = true) {
-            this.removeRootFileIfNecessary(info);
+            if (this.isRoot(info)) {
+                this.removeRoot(info);
+            }
             this.lsHost.notifyFileRemoved(info);
             this.cachedUnresolvedImportsPerFile.remove(info.path);
 
@@ -693,11 +695,9 @@ namespace ts.server {
         }
 
         // remove a root file from project
-        private removeRootFileIfNecessary(info: ScriptInfo): void {
-            if (this.isRoot(info)) {
-                remove(this.rootFiles, info);
-                this.rootFilesMap.remove(info.path);
-            }
+        protected removeRoot(info: ScriptInfo): void {
+            remove(this.rootFiles, info);
+            this.rootFilesMap.remove(info.path);
         }
     }
 
@@ -714,20 +714,26 @@ namespace ts.server {
 
         private _isJsInferredProject = false;
 
-        setAsJsInferredProject() {
-            this._isJsInferredProject = true;
-            this.setCompilerOptions();
+        toggleJsInferredProject(isJsInferredProject: boolean) {
+            if (isJsInferredProject !== this._isJsInferredProject) {
+                this._isJsInferredProject = isJsInferredProject;
+                this.setCompilerOptions();
+            }
         }
 
-        setCompilerOptions(newOptions?: CompilerOptions) {
-            newOptions = newOptions ? newOptions : this.getCompilerOptions();
+        setCompilerOptions(options?: CompilerOptions) {
+            // Avoid manipulating the given options directly
+            const newOptions = options ? clone(options) : this.getCompilerOptions();
             if (!newOptions) {
                 return;
             }
 
             if (this._isJsInferredProject && typeof newOptions.maxNodeModuleJsDepth !== "number") {
                 newOptions.maxNodeModuleJsDepth = 2;
             }
+            else if (!this._isJsInferredProject) {
+                newOptions.maxNodeModuleJsDepth = undefined;
+            }
             newOptions.allowJs = true;
             super.setCompilerOptions(newOptions);
         }
@@ -746,6 +752,22 @@ namespace ts.server {
                 /*compileOnSaveEnabled*/ false);
         }
 
+        addRoot(info: ScriptInfo) {
+            if (!this._isJsInferredProject && info.isJavaScript()) {
+                this.toggleJsInferredProject(/*isJsInferredProject*/ true);
+            }
+            super.addRoot(info);
+        }
+
+        removeRoot(info: ScriptInfo) {
+            if (this._isJsInferredProject && info.isJavaScript()) {
+                if (filter(this.getRootScriptInfos(), info => info.isJavaScript()).length === 0) {
+                    this.toggleJsInferredProject(/*isJsInferredProject*/ false);
+                }
+            }
+            super.removeRoot(info);
+        }
+
         getProjectRootPath() {
             // Single inferred project does not have a project root.
             if (this.projectService.useSingleInferredProject) {
diff --git a/src/server/scriptInfo.ts b/src/server/scriptInfo.ts
@@ -355,5 +355,9 @@ namespace ts.server {
         positionToLineOffset(position: number): ILineInfo {
             return this.textStorage.positionToLineOffset(position);
         }
+
+        public isJavaScript() {
+            return this.scriptKind === ScriptKind.JS || this.scriptKind === ScriptKind.JSX;
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -355,5 +355,9 @@ namespace ts.server {`
`355`	`355`	`positionToLineOffset(position: number): ILineInfo {`
`356`	`356`	`return this.textStorage.positionToLineOffset(position);`
`357`	`357`	`}`
	`358`	`+`
	`359`	`+ public isJavaScript() {`
	`360`	`+ return this.scriptKind === ScriptKind.JS \|\| this.scriptKind === ScriptKind.JSX;`
	`361`	`+ }`
`358`	`362`	`}`
`359`	`363`	`}`