Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jamesshore/lets_code_javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: jamesshore/lets_code_javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: spike_socket_io_race_condition
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 57 files changed
  • 1 contributor

Commits on May 26, 2017

  1. Reliably cause RealTimeServer test to fail

    @jamesshore
    jamesshore committed May 26, 2017
    Configuration menu
    Copy the full SHA
    0ef5dc5 View commit details
    Browse the repository at this point in the history

  2. Isolate 'make it work' code into RealTimeServer test

    @jamesshore
    jamesshore committed May 26, 2017
    Configuration menu
    Copy the full SHA
    38db3c5 View commit details
    Browse the repository at this point in the history

  3. Delete irrelevant tests

    @jamesshore
    jamesshore committed May 26, 2017
    Configuration menu
    Copy the full SHA
    d1938f2 View commit details
    Browse the repository at this point in the history

  4. Narrow down test failure to needing setTimeout() and file creation

    @jamesshore
    jamesshore committed May 26, 2017
    Configuration menu
    Copy the full SHA
    f0d3990 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2017

  1. Simplify file handling code and instrument closeSocket()

    @jamesshore
    jamesshore committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    369a52a View commit details
    Browse the repository at this point in the history

  2. Avoid race condition where server is connected and client is disconne… 

    …cted
    @jamesshore
    jamesshore committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    47b22e0 View commit details
    Browse the repository at this point in the history

  3. Remove irrelevant code

    @jamesshore
    jamesshore committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    7616739 View commit details
    Browse the repository at this point in the history

  4. Instrument HTTP connections

    @jamesshore
    jamesshore committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    ca7f84c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2017

  1. Document issue in todo.txt and update readme.md

    @jamesshore
    jamesshore committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    d5b2fd4 View commit details
    Browse the repository at this point in the history

  2. Start standalone reproduction case for issue 1 in todo.txt

    @jamesshore
    jamesshore committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    981bb0e View commit details
    Browse the repository at this point in the history

  3. Finish attempting to reproduce closeSocket() race condition--didn't work

    @jamesshore
    jamesshore committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    b267316 View commit details
    Browse the repository at this point in the history

  4. Update race condition standalone spike to check if connection is closed

    @jamesshore
    jamesshore committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    998d39a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2017

  1. Clean up socket.io race condition test case and report bug to socket.io

    @jamesshore
    jamesshore committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    b520eda View commit details
    Browse the repository at this point in the history

  2. Workaround test timeout race condition

    @jamesshore
    jamesshore committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    af198f8 View commit details
    Browse the repository at this point in the history

  3. Reproduce httpServer.close() timeout as standalone test case

    @jamesshore
    jamesshore committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    e1d2fe3 View commit details
    Browse the repository at this point in the history

  4. Clean up httpServer.close() test case and report bug to socket.io

    @jamesshore
    jamesshore committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    06cffa7 View commit details
    Browse the repository at this point in the history

  5. Update todo.txt with explanation of fix for httpServer.close() issue

    @jamesshore
    jamesshore committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    510c518 View commit details
    Browse the repository at this point in the history
Loading