fix post breadcrumbs for supported languages (GoogleChrome#1397)

samthor · web-flow · commit 2ff3a55a4e69 · 2021-10-07T13:32:02.000+11:00
* fix tag breadcrumbs for 'es'

* add missing pages for other langs

* render tags to locale

* add tag translation
diff --git a/site/_data/i18n/tags.yml b/site/_data/i18n/tags.yml
@@ -90,6 +90,12 @@ devtools:
 
 new-in-devtools:
   en: What's New in DevTools
+  es: Qué hay de nuevo en DevTools
+  ja: DevTools の新機能
+  ko: DevTools 의 새로운 기능
+  ru: Новинки DevTools
+  zh: DevTools 新功能
+  pt: O que há de novo no DevTools
 
 devtools-engineering:
   en: DevTools Engineering
diff --git a/site/_utils/tag-11tydata.js b/site/_utils/tag-11tydata.js
@@ -37,6 +37,11 @@ module.exports = locale => ({
       }
       return key;
     },
+    permalink: data => {
+      // Tag links appear without a locale, since it's a single shared collection.
+      // Be sure to render in the right locale.
+      return `/${locale}/${data.permalink}`;
+    },
   },
   pagination: {
     /**
diff --git a/site/en/blog/index.md b/site/en/blog/index.md
@@ -4,9 +4,6 @@ description: ''
 permalink: '{{locale}}/blog/{% if pagination.pageNumber > 0 %}{{ pagination.pageNumber + 1 }}/{% endif %}index.html'
 layout: 'layouts/blog-landing.njk'
 type: landing
-i18n:
-  headings:
-    latest-news: 'Latest Chrome news'
 pagination:
   data: collections.blog-en
   size: 24
diff --git a/site/es/blog/blog.11tydata.js b/site/es/blog/blog.11tydata.js
@@ -0,0 +1,3 @@
+module.exports = {
+  type: 'blogPost',
+};
diff --git a/site/es/blog/index.md b/site/es/blog/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Blog'
+description: ''
+permalink: '{{locale}}/blog/{% if pagination.pageNumber > 0 %}{{ pagination.pageNumber + 1 }}/{% endif %}index.html'
+layout: 'layouts/blog-landing.njk'
+type: landing
+pagination:
+  data: collections.blog-es
+  size: 24
+---
diff --git a/site/es/tags/index.md b/site/es/tags/index.md
@@ -0,0 +1,6 @@
+---
+title: 'Tags'
+description: 'Find blog posts tagged to a certain feature'
+permalink: '{{locale}}/tags/index.html'
+layout: 'layouts/tags-landing.njk'
+---
diff --git a/site/es/tags/tag/index.md b/site/es/tags/tag/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Tags'
+permalink: '{{paged.permalink}}'
+layout: 'layouts/tag-landing.njk'
+pagination:
+  data: collections.tags
+  size: 1
+  alias: paged
+  resolve: values
+---
diff --git a/site/es/tags/tag/tag.11tydata.js b/site/es/tags/tag/tag.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../../es.11tydata');
+const tag11tyData = require('../../../_utils/tag-11tydata');
+
+module.exports = tag11tyData(locale);
diff --git a/site/es/tags/tags.11tydata.js b/site/es/tags/tags.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../es.11tydata');
+const tags11tyData = require('../../_utils/tags-11tydata');
+
+module.exports = tags11tyData(locale);
diff --git a/site/ja/blog/blog.11tydata.js b/site/ja/blog/blog.11tydata.js
@@ -0,0 +1,3 @@
+module.exports = {
+  type: 'blogPost',
+};
diff --git a/site/ja/blog/index.md b/site/ja/blog/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Blog'
+description: ''
+permalink: '{{locale}}/blog/{% if pagination.pageNumber > 0 %}{{ pagination.pageNumber + 1 }}/{% endif %}index.html'
+layout: 'layouts/blog-landing.njk'
+type: landing
+pagination:
+  data: collections.blog-ja
+  size: 24
+---
diff --git a/site/ja/tags/index.md b/site/ja/tags/index.md
@@ -0,0 +1,6 @@
+---
+title: 'Tags'
+description: 'Find blog posts tagged to a certain feature'
+permalink: '{{locale}}/tags/index.html'
+layout: 'layouts/tags-landing.njk'
+---
diff --git a/site/ja/tags/tag/index.md b/site/ja/tags/tag/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Tags'
+permalink: '{{paged.permalink}}'
+layout: 'layouts/tag-landing.njk'
+pagination:
+  data: collections.tags
+  size: 1
+  alias: paged
+  resolve: values
+---
diff --git a/site/ja/tags/tag/tag.11tydata.js b/site/ja/tags/tag/tag.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2021 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../../ja.11tydata');
+const tag11tyData = require('../../../_utils/tag-11tydata');
+
+module.exports = tag11tyData(locale);
diff --git a/site/ja/tags/tags.11tydata.js b/site/ja/tags/tags.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2021 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../ja.11tydata');
+const tags11tyData = require('../../_utils/tags-11tydata');
+
+module.exports = tags11tyData(locale);
diff --git a/site/ko/blog/blog.11tydata.js b/site/ko/blog/blog.11tydata.js
@@ -0,0 +1,3 @@
+module.exports = {
+  type: 'blogPost',
+};
diff --git a/site/ko/blog/index.md b/site/ko/blog/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Blog'
+description: ''
+permalink: '{{locale}}/blog/{% if pagination.pageNumber > 0 %}{{ pagination.pageNumber + 1 }}/{% endif %}index.html'
+layout: 'layouts/blog-landing.njk'
+type: landing
+pagination:
+  data: collections.blog-ko
+  size: 24
+---
diff --git a/site/ko/tags/index.md b/site/ko/tags/index.md
@@ -0,0 +1,6 @@
+---
+title: 'Tags'
+description: 'Find blog posts tagged to a certain feature'
+permalink: '{{locale}}/tags/index.html'
+layout: 'layouts/tags-landing.njk'
+---
diff --git a/site/ko/tags/tag/index.md b/site/ko/tags/tag/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Tags'
+permalink: '{{paged.permalink}}'
+layout: 'layouts/tag-landing.njk'
+pagination:
+  data: collections.tags
+  size: 1
+  alias: paged
+  resolve: values
+---
diff --git a/site/ko/tags/tag/tag.11tydata.js b/site/ko/tags/tag/tag.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2021 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../../ko.11tydata');
+const tag11tyData = require('../../../_utils/tag-11tydata');
+
+module.exports = tag11tyData(locale);
diff --git a/site/ko/tags/tags.11tydata.js b/site/ko/tags/tags.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2021 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../ko.11tydata');
+const tags11tyData = require('../../_utils/tags-11tydata');
+
+module.exports = tags11tyData(locale);
diff --git a/site/pt/blog/blog.11tydata.js b/site/pt/blog/blog.11tydata.js
@@ -0,0 +1,3 @@
+module.exports = {
+  type: 'blogPost',
+};
diff --git a/site/pt/blog/index.md b/site/pt/blog/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Blog'
+description: ''
+permalink: '{{locale}}/blog/{% if pagination.pageNumber > 0 %}{{ pagination.pageNumber + 1 }}/{% endif %}index.html'
+layout: 'layouts/blog-landing.njk'
+type: landing
+pagination:
+  data: collections.blog-pt
+  size: 24
+---
diff --git a/site/pt/tags/index.md b/site/pt/tags/index.md
@@ -0,0 +1,6 @@
+---
+title: 'Tags'
+description: 'Find blog posts tagged to a certain feature'
+permalink: '{{locale}}/tags/index.html'
+layout: 'layouts/tags-landing.njk'
+---
diff --git a/site/pt/tags/tag/index.md b/site/pt/tags/tag/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Tags'
+permalink: '{{paged.permalink}}'
+layout: 'layouts/tag-landing.njk'
+pagination:
+  data: collections.tags
+  size: 1
+  alias: paged
+  resolve: values
+---
diff --git a/site/pt/tags/tag/tag.11tydata.js b/site/pt/tags/tag/tag.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2021 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../../pt.11tydata');
+const tag11tyData = require('../../../_utils/tag-11tydata');
+
+module.exports = tag11tyData(locale);
diff --git a/site/pt/tags/tags.11tydata.js b/site/pt/tags/tags.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2021 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../pt.11tydata');
+const tags11tyData = require('../../_utils/tags-11tydata');
+
+module.exports = tags11tyData(locale);
diff --git a/site/ru/blog/blog.11tydata.js b/site/ru/blog/blog.11tydata.js
@@ -0,0 +1,3 @@
+module.exports = {
+  type: 'blogPost',
+};
diff --git a/site/ru/blog/index.md b/site/ru/blog/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Blog'
+description: ''
+permalink: '{{locale}}/blog/{% if pagination.pageNumber > 0 %}{{ pagination.pageNumber + 1 }}/{% endif %}index.html'
+layout: 'layouts/blog-landing.njk'
+type: landing
+pagination:
+  data: collections.blog-ru
+  size: 24
+---
diff --git a/site/ru/tags/index.md b/site/ru/tags/index.md
@@ -0,0 +1,6 @@
+---
+title: 'Tags'
+description: 'Find blog posts tagged to a certain feature'
+permalink: '{{locale}}/tags/index.html'
+layout: 'layouts/tags-landing.njk'
+---
diff --git a/site/ru/tags/tag/index.md b/site/ru/tags/tag/index.md
@@ -0,0 +1,10 @@
+---
+title: 'Tags'
+permalink: '{{paged.permalink}}'
+layout: 'layouts/tag-landing.njk'
+pagination:
+  data: collections.tags
+  size: 1
+  alias: paged
+  resolve: values
+---
diff --git a/site/ru/tags/tag/tag.11tydata.js b/site/ru/tags/tag/tag.11tydata.js
@@ -0,0 +1,20 @@
+/*
+ * Copyright 2021 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const {locale} = require('../../ru.11tydata');
+const tag11tyData = require('../../../_utils/tag-11tydata');
+
+module.exports = tag11tyData(locale);
diff --git a/site/ru/tags/tags.11tydata.js b/site/ru/tags/tags.11tydata.js
diff --git a/site/zh/blog/blog.11tydata.js b/site/zh/blog/blog.11tydata.js
diff --git a/site/zh/blog/index.md b/site/zh/blog/index.md
diff --git a/site/zh/tags/index.md b/site/zh/tags/index.md
diff --git a/site/zh/tags/tag/index.md b/site/zh/tags/tag/index.md
diff --git a/site/zh/tags/tag/tag.11tydata.js b/site/zh/tags/tag/tag.11tydata.js
diff --git a/site/zh/tags/tags.11tydata.js b/site/zh/tags/tags.11tydata.js
diff --git a/tests/site/_data/lib/breadcrumbs.js b/tests/site/_data/lib/breadcrumbs.js

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+module.exports = {`
	`2`	`+ type: 'blogPost',`
	`3`	`+};`