Skip to content

feat: add editorial_summary to atmosphere fields #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wangela merged 3 commits into from
Jan 24, 2023
Merged

feat: add editorial_summary to atmosphere fields #472

wangela merged 3 commits into from
Jan 24, 2023

Conversation

@jloffredo2
Copy link
Contributor

@jloffredo2 jloffredo2 commented Jan 15, 2023

Fixes #471 🦕

@google-cla
Copy link

google-cla bot commented Jan 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jloffredo2
Copy link
Contributor Author

jloffredo2 commented Jan 15, 2023

CLA has been signed

@wangela wangela assigned wangela and unassigned amuramoto Jan 24, 2023
@wangela wangela self-requested a review January 24, 2023 08:53
wangela
wangela requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@wangela wangela left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. Please make two changes:

  • revert the change to PLACES_FIND_FIELDS_ATMOSPHERE
  • add a semantic prefix feat: to your PR title to clear the Semantic PR check

and we'll be good to go.

Noting here that it would be inadvisable to add this field to tests/test_places.py since the editorial summary content might change.

@jloffredo2 jloffredo2 changed the title Add editorial_summary to atmosphere fields feat: add editorial_summary to atmosphere fields Jan 24, 2023
@jloffredo2
Copy link
Contributor Author

jloffredo2 commented Jan 24, 2023

@wangela As per your request, I have reverted the change to PLACES_FIND_FIELDS_ATMOSPHERE and have added feat: to this PR title.

wangela
wangela approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the feedback!

@wangela wangela merged commit 9f09ccb into googlemaps:master Jan 24, 2023
googlemaps-bot pushed a commit that referenced this pull request Jan 24, 2023
@semantic-release-bot
chore(release): 4.8.0 [skip ci]
65d5a26 
# [4.8.0](v4.7.3...v4.8.0) (2023-01-24)

### Features

* add `editorial_summary` to Place Details atmosphere fields ([#472](#472)) ([9f09ccb](9f09ccb))
@googlemaps-bot
Copy link
Contributor

googlemaps-bot commented Jan 24, 2023

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add editorial_summary to place atmosphere field dictionary

4 participants

@jloffredo2 @googlemaps-bot @wangela @amuramoto