This repository was archived by the owner on Sep 23, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Expand file tree
/
Copy pathvalidate_test.go
More file actions
202 lines (197 loc) · 4.74 KB
/
Copy pathvalidate_test.go
File metadata and controls
202 lines (197 loc) · 4.74 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
// Copyright 2023 The Sigstore Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package policy
import (
"context"
"errors"
"testing"
policycontrollerconfig "github.com/sigstore/policy-controller/pkg/config"
"knative.dev/pkg/apis"
)
func TestValidate(t *testing.T) {
tests := []struct {
name string
doc string
wantWarns error
wantErr error
allowEmptyAuthorities bool
}{{
name: "good single object",
doc: `
apiVersion: policy.sigstore.dev/v1beta1
kind: ClusterImagePolicy
metadata:
name: blah
spec:
images:
- glob: '*'
authorities:
- keyless:
identities:
- issuer: https://issuer.example.com
subject: foo@example.com
url: https://fulcio.sigstore.dev
`,
wantErr: nil,
}, {
name: "good CIP and Secret",
doc: `
apiVersion: policy.sigstore.dev/v1beta1
kind: ClusterImagePolicy
metadata:
name: blah
spec:
images:
- glob: '*'
authorities:
- keyless:
identities:
- issuer: https://issuer.example.com
subject: foo@example.com
url: https://fulcio.sigstore.dev
---
apiVersion: v1
kind: Secret
metadata:
name: foo
namespace: cosign-system
stringData:
foo: bar
`,
wantErr: nil,
}, {
name: "bad secret namespace",
doc: `
apiVersion: v1
kind: Secret
metadata:
name: foo
namespace: something-system
stringData:
foo: bar
`,
wantErr: errors.New(`invalid value: something-system: [0].metadata.namespace`),
}, {
name: "bad image policy",
doc: `
apiVersion: policy.sigstore.dev/v1alpha1
kind: ClusterImagePolicy
metadata:
name: blah
spec:
images:
- glob: '*'
authorities:
- key: {}
`,
wantErr: apis.ErrMissingOneOf("data", "kms", "secretref").ViaField("key").ViaFieldIndex("authorities", 0).ViaField("spec"),
}, {
name: "empty document",
doc: ``,
wantErr: ErrEmptyDocument,
}, {
name: "object missing kind",
doc: `
apiVersion: policy.sigstore.dev/v1beta1
# Missing: kind: ClusterImagePolicy
metadata:
name: blah
spec: {}
`,
wantErr: errors.New(`decoding object[0]: error unmarshaling JSON: while decoding JSON: Object 'Kind' is missing in '{"apiVersion":"policy.sigstore.dev/v1beta1","metadata":{"name":"blah"},"spec":{}}'`),
}, {
name: "unknown field",
doc: `
apiVersion: policy.sigstore.dev/v1beta1
kind: ClusterImagePolicy
metadata:
name: blah
spec:
asdf: dfsadf
`,
wantErr: errors.New(`unable to unmarshal: json: unknown field "asdf"`),
}, {
name: "unknown type",
doc: `
apiVersion: unknown.dev/v1
kind: OtherPolicy
metadata:
name: blah
spec: {}
`,
wantErr: errors.New(`unknown type: unknown.dev/v1, Kind=OtherPolicy`),
}, {
name: "error - missing field",
doc: `
apiVersion: policy.sigstore.dev/v1beta1
kind: ClusterImagePolicy
metadata:
name: blah
spec:
images:
- glob: '*'
authorities:
- keyless:
url: https://fulcio.sigstore.dev
`,
wantErr: errors.New("missing field(s): spec.authorities[0].keyless.identities"),
},
{
name: "admit - missing authorities",
doc: `
apiVersion: policy.sigstore.dev/v1beta1
kind: ClusterImagePolicy
metadata:
name: blah
spec:
images:
- glob: '*'
`,
wantErr: nil,
allowEmptyAuthorities: true,
}, {
name: "deny - missing authorities",
doc: `
apiVersion: policy.sigstore.dev/v1beta1
kind: ClusterImagePolicy
metadata:
name: blah
spec:
images:
- glob: '*'
`,
wantErr: errors.New("missing field(s): spec.authorities"),
}}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
testContext := context.Background()
if test.allowEmptyAuthorities {
testContext = policycontrollerconfig.ToContext(testContext, &policycontrollerconfig.PolicyControllerConfig{FailOnEmptyAuthorities: false})
}
gotWarns, gotErr := Validate(testContext, test.doc)
if (gotErr != nil) != (test.wantErr != nil) {
t.Fatalf("Validate() = %v, wanted %v", gotErr, test.wantErr)
}
if (gotWarns != nil) != (test.wantWarns != nil) {
t.Fatalf("Validate() = %v, wanted %v", gotWarns, test.wantWarns)
}
if gotErr != nil && gotErr.Error() != test.wantErr.Error() {
t.Fatalf("Validate() = %v, wanted %v", gotErr, test.wantErr)
}
if gotWarns != nil && gotWarns.Error() != test.wantWarns.Error() {
t.Fatalf("Validate() = %v, wanted %v", gotWarns, test.wantWarns)
}
})
}
}