From ff44365fe5119cdc74fcb16fee51857e77360ca3 Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Wed, 9 Oct 2024 09:47:38 +0530
Subject: [PATCH 01/10] feat: add page to list open external pull requests

---
 app.js          |  6 ++++++
 src/helpers.js  | 32 ++++++++++++++++++++++++++++++--
 src/routes.js   | 25 +++++++++++++++++++++++++
 views/home.html |  1 +
 4 files changed, 62 insertions(+), 2 deletions(-)

diff --git a/app.js b/app.js
index ccc01ef..20176c7 100644
--- a/app.js
+++ b/app.js
@@ -233,6 +233,12 @@ http
       case "POST /cla":
         routes.submitCla(req, res, app);
         break;
+      case "GET /contributions/sync":
+        routes.syncPullRequests(req, res, app);
+        break;
+      case "GET /contributions":
+        routes.listPullRequests(req, res, app);
+        break;
       case "POST /api/webhook":
         middleware(req, res);
         break;
diff --git a/src/helpers.js b/src/helpers.js
index e864065..8f52310 100644
--- a/src/helpers.js
+++ b/src/helpers.js
@@ -1,12 +1,14 @@
 import { storage } from "./storage.js";
 import { resolve } from "path";
 import { PROJECT_ROOT_PATH } from "./config.js";
+import url from "node:url";
 
 export function parseUrlQueryParams(urlString) {
   if(!urlString) return urlString;
   try{
-    const url = new URL(urlString);
-    const params = new URLSearchParams(url.search);
+    const parsedUrl = url.parse(urlString)
+    const query = parsedUrl.query;
+    const params = new URLSearchParams(query);
     return Object.fromEntries(params.entries());
   } catch(err){
     console.error(err);
@@ -270,6 +272,7 @@ export async function getOctokitForOrg(app, org) {
       return octokit
     }
   }
+  console.error("No GitHub App installation found for " + org);
 }
 
 export async function verifyGitHubAppAuthenticationAndAccess(app) {
@@ -333,4 +336,29 @@ function parseRepoUrl(repoUrl) {
     // Handle cases where URL constructor fails (e.g., SSH URLs)
     return null;
   }
+}
+
+export async function getOpenPullRequests(app, owner, repo) {
+  const octokit = await getOctokitForOrg(app, owner);
+  if (!octokit) {
+    console.error("Failed to search PR because of undefined octokit intance")
+    return
+  }
+  const query = `is:pr is:open -author:dependabot[bot]` + (repo ? ` repo:${owner / repo}` : ` org:${owner}`);
+  const response = await octokit.rest.search.issuesAndPullRequests({
+    q: query,
+    sort: 'created',
+    order: 'desc'
+  });
+  const humanPRs = response.data.items.filter(pr => pr.user && pr.user.type === 'User');
+  return humanPRs;
+}
+
+export async function getOpenExternalPullRequests(app, owner, repo) {
+  const openPRs = await getOpenPullRequests(app, owner, repo);
+  if (Array.isArray(openPRs)) {
+    // Send only the external PRs
+    return openPRs?.filter((pr) => isExternalContribution(pr))
+  }
+  return
 }
\ No newline at end of file
diff --git a/src/routes.js b/src/routes.js
index 64af41b..ff420e4 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -9,6 +9,7 @@ import {
   queryStringToJson,
   parseUrlQueryParams,
   jsonToCSV,
+  getOpenExternalPullRequests,
 } from "./helpers.js";
 import { isPasswordValid } from "./auth.js";
 
@@ -166,6 +167,30 @@ export const routes = {
     })
   },
 
+  syncPullRequests(req, res, app) {
+    if (err) {
+      res.writeHead(404);
+      res.write("Not implemented yet");
+      return res.end();
+    }
+    res.writeHead(302, {
+      Location: "/pr",
+    });
+    return res.end();
+  },
+
+  async listPullRequests(req, res, app) {
+    const { org, repo } = parseUrlQueryParams(req.url) || {};
+    if (!org) {
+      res.writeHead(400);
+      return res.end("Please add org parameter in the url e.g. ?org=my-github-org-name");
+    }
+    const prList = await getOpenExternalPullRequests(app, org, repo);
+    res.setHeader('Content-Type', 'application/json');
+    const jsonString = prList ? JSON.stringify(prList, null, 2) : ("No Open Pull Requests found (or you don't have access to search PRs for " + org);
+    return res.end(jsonString);
+  },
+
   default(req, res) {
     res.writeHead(404);
     res.write("Path not found!");
diff --git a/views/home.html b/views/home.html
index 237a6a8..a65d21b 100644
--- a/views/home.html
+++ b/views/home.html
@@ -30,6 +30,7 @@ <h2>🙏 Get started with contribution to RudderStack Open Source</h2>
       <hr/>
       Tools & resources for RudderStack contributors
       <ul>
+        <li><a href="/contributions">Contributions in progress</a></li>
         <li><a href="https://www.rudderstack.com/docs/resources/community/#contribute" target="_blank">Contribution guide</a></li>
         <li><a href="https://www.rudderstack.com/docs/user-guides/how-to-guides/developing-integrations-for-rudderstack/" target="_blank">Create a new integration</a></li>
         <li><a href="https://github.com/rudderlabs/rudder-server/discussions/new?category=feature-requests" target="_blank">Request a new feature</a></li>

From 97a0b77e549e27e411dd38de7a37c64485907277 Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Wed, 9 Oct 2024 15:36:35 +0530
Subject: [PATCH 02/10] feat: group pr results by user and repo

---
 src/helpers.js |  64 ++++++++++++++++++++++++----
 src/routes.js  | 112 ++++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 162 insertions(+), 14 deletions(-)

diff --git a/src/helpers.js b/src/helpers.js
index 8f52310..8733e30 100644
--- a/src/helpers.js
+++ b/src/helpers.js
@@ -60,10 +60,14 @@ export function isMessageAfterMergeRequired(pullRequest) {
 }
 
 export function isExternalContribution(pullRequest) {
-  if (
-    pullRequest?.head?.repo?.full_name !== pullRequest?.base?.repo?.full_name
-  ) {
+  if (pullRequest?.head?.repo?.full_name !== pullRequest?.base?.repo?.full_name) {
     return true;
+  } else if (pullRequest?.author_association?.toUpperCase() === 'NONE') {
+    // They have neither been the owner, member, collborater, nor they have contributed in the past
+    return true
+  } else if (pullRequest?.author_association?.toUpperCase() === 'CONTRIBUTOR') {
+    // They have contributed in the past (at least in the past as contributor)
+    return true
   }
   return false;
 }
@@ -231,6 +235,7 @@ export function getMessage(name, context) {
 }
 
 export function isCLASigned(username) {
+  if (!username) return
   const userData = storage.get({ username: username, terms: "on" });
   if (userData?.length > 0) {
     return true;
@@ -344,21 +349,62 @@ export async function getOpenPullRequests(app, owner, repo) {
     console.error("Failed to search PR because of undefined octokit intance")
     return
   }
-  const query = `is:pr is:open -author:dependabot[bot]` + (repo ? ` repo:${owner / repo}` : ` org:${owner}`);
+  const query = `is:pr is:open -author:dependabot[bot]` + (repo ? ` repo:${owner + "/" + repo}` : ` org:${owner}`);
   const response = await octokit.rest.search.issuesAndPullRequests({
     q: query,
     sort: 'created',
     order: 'desc'
   });
+  console.log(response?.data.total_count + " results found for search: " + query);
   const humanPRs = response.data.items.filter(pr => pr.user && pr.user.type === 'User');
   return humanPRs;
 }
 
 export async function getOpenExternalPullRequests(app, owner, repo) {
-  const openPRs = await getOpenPullRequests(app, owner, repo);
-  if (Array.isArray(openPRs)) {
+  try {
+    const openPRs = await getOpenPullRequests(app, owner, repo);
+    if (!Array.isArray(openPRs)) {
+      return;
+    }
     // Send only the external PRs
-    return openPRs?.filter((pr) => isExternalContribution(pr))
+    const openExternalPRs = openPRs?.filter((pr) => isExternalContribution(pr))
+    return openExternalPRs
+  } catch (err) {
+    return
   }
-  return
-}
\ No newline at end of file
+}
+
+export function timeAgo(date) {
+  if (!date) return '';
+  if (typeof date === 'string') {
+    date = new Date(date);
+  }
+  const now = new Date();
+  const seconds = Math.floor((now - date) / 1000);
+  let interval = Math.floor(seconds / 31536000);
+
+  if (interval > 1) {
+    return `${interval} years ago`;
+  }
+  interval = Math.floor(seconds / 2592000);
+  if (interval > 1) {
+    return `${interval} months ago`;
+  }
+  interval = Math.floor(seconds / 604800);
+  if (interval > 1) {
+    return `${interval} weeks ago`;
+  }
+  interval = Math.floor(seconds / 86400);
+  if (interval > 1) {
+    return `${interval} days ago`;
+  }
+  interval = Math.floor(seconds / 3600);
+  if (interval > 1) {
+    return `${interval} hours ago`;
+  }
+  interval = Math.floor(seconds / 60);
+  if (interval > 1) {
+    return `${interval} minutes ago`;
+  }
+  return `${seconds} seconds ago`;
+}
diff --git a/src/routes.js b/src/routes.js
index ff420e4..8dfc1a3 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -5,11 +5,13 @@ import { PROJECT_ROOT_PATH } from "./config.js";
 import { storage } from "./storage.js";
 import { sanitizeInput } from "./sanitize.js";
 import {
+  isCLASigned,
   afterCLA,
   queryStringToJson,
   parseUrlQueryParams,
   jsonToCSV,
   getOpenExternalPullRequests,
+  timeAgo
 } from "./helpers.js";
 import { isPasswordValid } from "./auth.js";
 
@@ -185,15 +187,115 @@ export const routes = {
       res.writeHead(400);
       return res.end("Please add org parameter in the url e.g. ?org=my-github-org-name");
     }
-    const prList = await getOpenExternalPullRequests(app, org, repo);
-    res.setHeader('Content-Type', 'application/json');
-    const jsonString = prList ? JSON.stringify(prList, null, 2) : ("No Open Pull Requests found (or you don't have access to search PRs for " + org);
-    return res.end(jsonString);
+    const prs = await getOpenExternalPullRequests(app, org, repo);
+    if (req.headers['content-type']?.toLowerCase() === 'application/json') {
+      res.setHeader('Content-Type', 'application/json');
+      const jsonString = prs ? JSON.stringify(prs, null, 2) : ("No Open Pull Requests found (or you don't have access to search PRs for " + org);
+      return res.end(jsonString);
+    }
+    res.writeHead(200, { 'Content-Type': 'text/html' });
+    res.write(`<!DOCTYPE html>
+                <html>
+                <head>
+                  <title>Recent Contributions (Open)</title>
+                  <style>
+                        .tabs { margin-bottom: 20px; }
+                        .tab-button { cursor: pointer; padding: 10px; margin-right: 5px; background-color: #ccc; border: none; }
+                        .tab-button.active { background-color: #999; }
+                        .tab-content { display: none; }
+                        .tab-content.active { display: block; }
+                    </style>
+                  </head>
+                  <body>
+                      <h1>Recent Contributions (Open)</h1>
+                      <div class="tabs">
+                          ${Array.isArray(prs) && prs.length > 0 ? `<button class="tab-button" onclick="switchView('byUser')">Group by User</button><button class="tab-button" onclick="switchView('byRepo')">Group by Repository</button>` : ""}
+                      </div>
+                      <div id="byUser" class="tab-content">
+                          ${groupPullRequestsByUser(prs)}
+                      </div>
+                      <div id="byRepo" class="tab-content">
+                          ${groupPullRequestsByRepo(prs)}
+                      </div>
+                    </body>
+                    <script>
+                        function switchView(viewId) {
+                            document.querySelectorAll('.tab-content').forEach(tab => {
+                                tab.classList.remove('active');
+                            });
+                            document.querySelectorAll('.tab-button').forEach(button => {
+                                button.classList.remove('active');
+                            });
+                            document.getElementById(viewId).classList.add('active');
+                            event.target.classList.add('active');
+                        }
+                        // Set default view
+                        switchView('byUser');
+                    </script>
+                    </html>`);
+    res.end();
   },
-
+  // ${!Array.isArray(prs) || prs?.length < 1 ? "No contributions found! (Might be an access issue)" : prs?.map(pr => `<li><a href="${pr?.user?.html_url}">${pr?.user?.login}</a> contributed a PR - <a href="${pr?.html_url}" target="_blank">${pr?.title}</a> [${pr?.labels?.map(label => label?.name).join('] [')}]  <small>updated ${timeAgo(pr?.updated_at)}</small></li>`).join('')}
   default(req, res) {
     res.writeHead(404);
     res.write("Path not found!");
     return res.end();
   },
 };
+
+
+function groupPullRequestsByUser(prs) {
+  if (!Array.isArray(prs) || prs?.length < 1) {
+    return "No recent contributions found"
+  }
+  const grouped = prs?.reduce((acc, pr) => {
+    if (!acc[pr?.user?.login]) {
+      acc[pr?.user?.login] = [];
+    }
+    acc[pr?.user?.login].push(pr);
+    return acc;
+  }, {});
+  let html = '';
+  for (const user in grouped) {
+    html += `<h2>${user}</h2> ${isCLASigned(user) ? "✅" : ""}<ul>`;
+    grouped[user].forEach(pr => {
+      html += `
+        <li>
+            <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
+            [${pr?.labels?.map(label => label?.name).join('] [')}]
+            <small> updated ${timeAgo(pr?.updated_at)}</small>
+        </li>`;
+    });
+    html += '</ul>';
+  }
+  return html;
+}
+
+function groupPullRequestsByRepo(prs) {
+  if (!Array.isArray(prs) || prs?.length < 1) {
+    return "No recent contributions found"
+  }
+  const grouped = prs?.reduce((acc, pr) => {
+    if (!acc[pr?.repository_url]) {
+      acc[pr?.repository_url] = [];
+    }
+    acc[pr?.repository_url].push(pr);
+    return acc;
+  }, {});
+  let html = '';
+  for (const repo in grouped) {
+    const repoName = repo.split('/').slice(-1)[0];
+    html += `<h2>${repoName}</h2><ul>`;
+    grouped[repo].forEach(pr => {
+      html += `
+        <li>
+            <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
+            by <a href="${pr?.user?.html_url}">${pr?.user?.login} ${isCLASigned(pr?.user?.login) ? "✅" : ""}</a>
+            [${pr?.labels?.map(label => label?.name).join('] [')}]
+            <small> updated ${timeAgo(pr?.updated_at)}</small>
+        </li>`;
+    });
+    html += '</ul>';
+  }
+  return html;
+}
\ No newline at end of file

From 54741e3df9d98a12df073ec9471d559f868c4e47 Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Sat, 12 Oct 2024 08:12:51 +0530
Subject: [PATCH 03/10] feat: use default gh org when no installation found in
 target org

---
 src/helpers.js | 24 ++++++++++++++-----
 src/routes.js  | 64 ++++++++++++++++++++++++++++++--------------------
 2 files changed, 56 insertions(+), 32 deletions(-)

diff --git a/src/helpers.js b/src/helpers.js
index 8733e30..ec1dd6f 100644
--- a/src/helpers.js
+++ b/src/helpers.js
@@ -278,6 +278,11 @@ export async function getOctokitForOrg(app, org) {
     }
   }
   console.error("No GitHub App installation found for " + org);
+  // Fall back authentication method
+  const DEFAULT_GITHUB_ORG = process.env.DEFAULT_GITHUB_ORG;
+  if (DEFAULT_GITHUB_ORG && org !== DEFAULT_GITHUB_ORG) {
+    return await getOctokitForOrg(app, DEFAULT_GITHUB_ORG);
+  }
 }
 
 export async function verifyGitHubAppAuthenticationAndAccess(app) {
@@ -343,26 +348,33 @@ function parseRepoUrl(repoUrl) {
   }
 }
 
-export async function getOpenPullRequests(app, owner, repo) {
+export async function getOpenPullRequests(app, owner, repo, options) {
   const octokit = await getOctokitForOrg(app, owner);
   if (!octokit) {
     console.error("Failed to search PR because of undefined octokit intance")
     return
   }
-  const query = `is:pr is:open -author:dependabot[bot]` + (repo ? ` repo:${owner + "/" + repo}` : ` org:${owner}`);
+  let query = `is:pr is:open` + (repo ? ` repo:${owner + "/" + repo}` : ` org:${owner}`);
+  const BOT_USERS = process.env.GITHUB_BOT_USERS ? process.env.GITHUB_BOT_USERS.split(",")?.map((item) => item?.trim()) : null;
+  const GITHUB_ORG_MEMBERS = process.env.GITHUB_ORG_MEMBERS ? process.env.GITHUB_ORG_MEMBERS.split(",")?.map((item) => item?.trim()) : null;
+  // Remove results from bots or internal team members
+  BOT_USERS?.forEach((botUser) => query += (" -author:" + botUser));
+  GITHUB_ORG_MEMBERS?.forEach((orgMember) => query += (" -author:" + orgMember));
   const response = await octokit.rest.search.issuesAndPullRequests({
     q: query,
+    per_page: 100,
+    page: options?.page || 1,
     sort: 'created',
     order: 'desc'
   });
-  console.log(response?.data.total_count + " results found for search: " + query);
-  const humanPRs = response.data.items.filter(pr => pr.user && pr.user.type === 'User');
+  console.log(response?.data?.total_count + " results found for search: " + query);
+  const humanPRs = response?.data?.items?.filter(pr => pr.user && pr.user.type === 'User');
   return humanPRs;
 }
 
-export async function getOpenExternalPullRequests(app, owner, repo) {
+export async function getOpenExternalPullRequests(app, owner, repo, options) {
   try {
-    const openPRs = await getOpenPullRequests(app, owner, repo);
+    const openPRs = await getOpenPullRequests(app, owner, repo, options);
     if (!Array.isArray(openPRs)) {
       return;
     }
diff --git a/src/routes.js b/src/routes.js
index 8dfc1a3..e1f3eb2 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -182,12 +182,12 @@ export const routes = {
   },
 
   async listPullRequests(req, res, app) {
-    const { org, repo } = parseUrlQueryParams(req.url) || {};
+    const { org, repo, page } = parseUrlQueryParams(req.url) || {};
     if (!org) {
       res.writeHead(400);
       return res.end("Please add org parameter in the url e.g. ?org=my-github-org-name");
     }
-    const prs = await getOpenExternalPullRequests(app, org, repo);
+    const prs = await getOpenExternalPullRequests(app, org, repo, { page: page });
     if (req.headers['content-type']?.toLowerCase() === 'application/json') {
       res.setHeader('Content-Type', 'application/json');
       const jsonString = prs ? JSON.stringify(prs, null, 2) : ("No Open Pull Requests found (or you don't have access to search PRs for " + org);
@@ -209,7 +209,7 @@ export const routes = {
                   <body>
                       <h1>Recent Contributions (Open)</h1>
                       <div class="tabs">
-                          ${Array.isArray(prs) && prs.length > 0 ? `<button class="tab-button" onclick="switchView('byUser')">Group by User</button><button class="tab-button" onclick="switchView('byRepo')">Group by Repository</button>` : ""}
+                          ${Array.isArray(prs) && prs.length > 0 ? `<button id="btn-group-byUser" class="tab-button" onclick="switchView('byUser')">Group by User</button><button id="btn-group-byRepo" class="tab-button" onclick="switchView('byRepo')">Group by Repository</button>` : ""}
                       </div>
                       <div id="byUser" class="tab-content">
                           ${groupPullRequestsByUser(prs)}
@@ -217,22 +217,32 @@ export const routes = {
                       <div id="byRepo" class="tab-content">
                           ${groupPullRequestsByRepo(prs)}
                       </div>
-                    </body>
-                    <script>
-                        function switchView(viewId) {
-                            document.querySelectorAll('.tab-content').forEach(tab => {
-                                tab.classList.remove('active');
-                            });
-                            document.querySelectorAll('.tab-button').forEach(button => {
-                                button.classList.remove('active');
-                            });
-                            document.getElementById(viewId).classList.add('active');
-                            event.target.classList.add('active');
-                        }
-                        // Set default view
-                        switchView('byUser');
-                    </script>
-                    </html>`);
+                      <br/><br/>
+                      <div class="pagination">
+                          <button class="pagination-button" onclick="goToNextPage()">Next Page...</button>
+                      </div>
+                  </body>
+                  <script>
+                      function switchView(viewId) {
+                          document.querySelectorAll('.tab-content').forEach(tab => {
+                              tab.classList.remove('active');
+                          });
+                          document.querySelectorAll('.tab-button').forEach(button => {
+                              button.classList.remove('active');
+                          });
+                          document.getElementById(viewId).classList.add('active');
+                          document.getElementById("btn-group-"+viewId).classList.add('active');
+                      }
+                      function goToNextPage() {
+                            const currentUrl = new URL(window.location.href);
+                            const currentPage = parseInt(currentUrl.searchParams.get('page')) || 1;
+                            currentUrl.searchParams.set('page', currentPage + 1);
+                            window.location.href = currentUrl.toString();
+                      }
+                      // Set default view
+                      switchView('byUser');
+                  </script>
+                  </html>`);
     res.end();
   },
   // ${!Array.isArray(prs) || prs?.length < 1 ? "No contributions found! (Might be an access issue)" : prs?.map(pr => `<li><a href="${pr?.user?.html_url}">${pr?.user?.login}</a> contributed a PR - <a href="${pr?.html_url}" target="_blank">${pr?.title}</a> [${pr?.labels?.map(label => label?.name).join('] [')}]  <small>updated ${timeAgo(pr?.updated_at)}</small></li>`).join('')}
@@ -259,12 +269,13 @@ function groupPullRequestsByUser(prs) {
   for (const user in grouped) {
     html += `<h2>${user}</h2> ${isCLASigned(user) ? "✅" : ""}<ul>`;
     grouped[user].forEach(pr => {
+      const prLabels = pr?.labels?.length > 0 ? "[" + pr?.labels?.map(label => label?.name).join('] [') + "]" : "";
       html += `
-        <li>
-            <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
-            [${pr?.labels?.map(label => label?.name).join('] [')}]
-            <small> updated ${timeAgo(pr?.updated_at)}</small>
-        </li>`;
+          <li>
+              <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
+              ${prLabels}
+              <small> updated ${timeAgo(pr?.updated_at)}</small>
+          </li>`;
     });
     html += '</ul>';
   }
@@ -287,11 +298,12 @@ function groupPullRequestsByRepo(prs) {
     const repoName = repo.split('/').slice(-1)[0];
     html += `<h2>${repoName}</h2><ul>`;
     grouped[repo].forEach(pr => {
+      const prLabels = pr?.labels?.length > 0 ? "[" + pr?.labels?.map(label => label?.name).join('] [') + "]" : "";
       html += `
         <li>
             <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
-            by <a href="${pr?.user?.html_url}">${pr?.user?.login} ${isCLASigned(pr?.user?.login) ? "✅" : ""}</a>
-            [${pr?.labels?.map(label => label?.name).join('] [')}]
+            by <a target="_blank" href="${pr?.user?.html_url}">${pr?.user?.login} ${isCLASigned(pr?.user?.login) ? "✅" : ""}</a>
+            ${prLabels}
             <small> updated ${timeAgo(pr?.updated_at)}</small>
         </li>`;
     });

From f26acf83de1435c9427259dbe3f895b88f217b94 Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Tue, 15 Oct 2024 08:31:00 +0530
Subject: [PATCH 04/10] fix: add configs for bot user exclusion

---
 .env.sample | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/.env.sample b/.env.sample
index 8885605..402a84d 100644
--- a/.env.sample
+++ b/.env.sample
@@ -1,7 +1,10 @@
-APP_ID="11"
-GITHUB_APP_PRIVATE_KEY_BASE64="base64 encoded private key"
-PRIVATE_KEY_PATH="very/secure/location/gh_app_key.pem"
-WEBHOOK_SECRET="secret"
 WEBSITE_ADDRESS="https://github.app.home"
 LOGIN_USER=username
-LOGIN_PASSWORD=strongpassword
\ No newline at end of file
+LOGIN_PASSWORD=strongpassword
+DEFAULT_GITHUB_ORG=Git-Commit-Show
+GITHUB_BOT_USERS=dependabot[bot],devops-github-rudderstack
+GITHUB_ORG_MEMBERS=
+APP_ID="11"
+WEBHOOK_SECRET="secret"
+PRIVATE_KEY_PATH="very/secure/location/gh_app_key.pem"
+GITHUB_APP_PRIVATE_KEY_BASE64="base64 encoded private key"
\ No newline at end of file

From bd78e91bac89cf109404e7740d35fd290e2cd008 Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Wed, 16 Oct 2024 17:49:16 +0530
Subject: [PATCH 05/10] feat: add a deterministic method to check external
 contribution

---
 src/helpers.js | 105 ++++++++++++++++++++++++++++++++++++++++---------
 src/routes.js  |   2 +-
 2 files changed, 87 insertions(+), 20 deletions(-)

diff --git a/src/helpers.js b/src/helpers.js
index ec1dd6f..83944c7 100644
--- a/src/helpers.js
+++ b/src/helpers.js
@@ -34,7 +34,7 @@ export function isCLARequired(pullRequest) {
     console.log("This PR is from a bot. So no CLA required.");
     return false;
   }
-  if (!isExternalContribution(pullRequest)) {
+  if (!isExternalContributionMaybe(pullRequest)) {
     console.log("This PR is an internal contribution. So no CLA required.");
     return false;
   }
@@ -50,7 +50,7 @@ export function isMessageAfterMergeRequired(pullRequest) {
     console.log("This PR is from a bot. So no message after merge required.");
     return false;
   }
-  if (!isExternalContribution(pullRequest)) {
+  if (!isExternalContributionMaybe(pullRequest)) {
     console.log(
       "This PR is an internal contribution. So no message after merge required.",
     );
@@ -59,17 +59,53 @@ export function isMessageAfterMergeRequired(pullRequest) {
   return true;
 }
 
-export function isExternalContribution(pullRequest) {
+/**
+ * Whether a pull request is a contribution by external user who has bot been associated with the repo
+ * @param {Object} pullRequest 
+ * @returns {boolean | undefined} - boolean when confirmed, undefined when not confirmed
+ */
+export function isExternalContributionMaybe(pullRequest) {
+  if (typeof pullRequest?.author_association === "string") {
+    // OWNER: Author is the owner of the repository.
+    // MEMBER: Author is a member of the organization that owns the repository.
+    // COLLABORATOR: Author has been invited to collaborate on the repository.
+    // CONTRIBUTOR: Author has previously committed to the repository.
+    // FIRST_TIMER: Author has not previously committed to GitHub.
+    // FIRST_TIME_CONTRIBUTOR: Author has not previously committed to the repository.
+    // MANNEQUIN: Author is a placeholder for an unclaimed user.
+    // NONE: Author has no association with the repository (or doesn't want to make his association public).
+    switch (pullRequest.author_association.toUpperCase()) {
+      case "OWNER":
+        return false;
+      case "MEMBER":
+        return false;
+      case "COLLABORATOR":
+        return false;
+      default:
+        //TODO: Need more checks to verify author relation with the repo
+        break;
+    }
+  }
   if (pullRequest?.head?.repo?.full_name !== pullRequest?.base?.repo?.full_name) {
     return true;
-  } else if (pullRequest?.author_association?.toUpperCase() === 'NONE') {
-    // They have neither been the owner, member, collborater, nor they have contributed in the past
-    return true
-  } else if (pullRequest?.author_association?.toUpperCase() === 'CONTRIBUTOR') {
-    // They have contributed in the past (at least in the past as contributor)
-    return true
   }
-  return false;
+  // Ambigous results after this point.
+  // Cannot confirm whether an external contribution or not.
+  // Need more reliable check.
+  return undefined;
+}
+
+async function isExternalContribution(octokit, pullRequest) {
+  const probablisticResult = isExternalContributionMaybe(pullRequest);
+  if (typeof probablisticResult === "boolean") {
+    // Boolean is returned when the probabilistic check is sufficient
+    return probablisticResult;
+  }
+  const username = pullRequest?.user?.login;
+  const { owner, repo } = parseRepoUrl(pullRequest?.repository_url) || {};
+  //TODO: Handle failure in checking permissions for the user
+  const deterministicPermissionCheck = await isAllowedToWriteToTheRepo(octokit, username, owner, repo);
+  return deterministicPermissionCheck;
 }
 
 export function isABot(user) {
@@ -343,17 +379,12 @@ function parseRepoUrl(repoUrl) {
 
     return { owner: segments[segments.length - 2], repo: segments[segments.length - 1] };
   } catch (error) {
-    // Handle cases where URL constructor fails (e.g., SSH URLs)
+    //TODO: Handle cases where URL constructor fails (e.g., SSH URLs)
     return null;
   }
 }
 
-export async function getOpenPullRequests(app, owner, repo, options) {
-  const octokit = await getOctokitForOrg(app, owner);
-  if (!octokit) {
-    console.error("Failed to search PR because of undefined octokit intance")
-    return
-  }
+export async function getOpenPullRequests(octokit, owner, repo, options) {
   let query = `is:pr is:open` + (repo ? ` repo:${owner + "/" + repo}` : ` org:${owner}`);
   const BOT_USERS = process.env.GITHUB_BOT_USERS ? process.env.GITHUB_BOT_USERS.split(",")?.map((item) => item?.trim()) : null;
   const GITHUB_ORG_MEMBERS = process.env.GITHUB_ORG_MEMBERS ? process.env.GITHUB_ORG_MEMBERS.split(",")?.map((item) => item?.trim()) : null;
@@ -374,12 +405,16 @@ export async function getOpenPullRequests(app, owner, repo, options) {
 
 export async function getOpenExternalPullRequests(app, owner, repo, options) {
   try {
-    const openPRs = await getOpenPullRequests(app, owner, repo, options);
+    const octokit = await getOctokitForOrg(app, owner);
+    if (!octokit) {
+      throw new Error("Failed to search PR because of undefined octokit intance")
+    }
+    const openPRs = await getOpenPullRequests(octokit, owner, repo, options);
     if (!Array.isArray(openPRs)) {
       return;
     }
     // Send only the external PRs
-    const openExternalPRs = openPRs?.filter((pr) => isExternalContribution(pr))
+    const openExternalPRs = openPRs?.filter(async (pr) => await isExternalContribution(octokit, pr))
     return openExternalPRs
   } catch (err) {
     return
@@ -420,3 +455,35 @@ export function timeAgo(date) {
   }
   return `${seconds} seconds ago`;
 }
+
+/**
+ * Check user permissions for a repository
+ * The authenticating octokit instance must have "Metadata" repository permissions (read)
+ * @param {string} username 
+ * @param {string} owner 
+ * @param {string} repo 
+ * @returns {boolean}
+ */
+async function isAllowedToWriteToTheRepo(octokit, username, owner, repo,) {
+  try {
+    const result = await octokit.rest.repos.getCollaboratorPermissionLevel({
+      owner,
+      repo,
+      username,
+    });
+    //TODO: Cache request result
+    if (["admin", "write"].includes(result?.permission)) {
+      return true
+    }
+    if (["admin", "maintain", "write"].includes(result?.role_name)) {
+      return true
+    }
+    return false;
+  } catch (err) {
+    // If 403 error "HttpError: Resource not accessible by integration"
+    // The app is not installed in that repo
+    // Only "metadata:repository" permission is needed for this api, which all gh apps have wherever they are installed
+    console.log("Failed to check if a " + username + " is allowed to write to " + owner + "/" + repo);
+    console.error(err);
+  }
+}
\ No newline at end of file
diff --git a/src/routes.js b/src/routes.js
index e1f3eb2..169a1e6 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -267,7 +267,7 @@ function groupPullRequestsByUser(prs) {
   }, {});
   let html = '';
   for (const user in grouped) {
-    html += `<h2>${user}</h2> ${isCLASigned(user) ? "✅" : ""}<ul>`;
+    html += `<h2>${user} ${isCLASigned(user) ? "✅" : ""}</h2><ul>`;
     grouped[user].forEach(pr => {
       const prLabels = pr?.labels?.length > 0 ? "[" + pr?.labels?.map(label => label?.name).join('] [') + "]" : "";
       html += `

From 3e326167fa7a1eb6681dad876cb8490547f581fd Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Thu, 17 Oct 2024 10:37:40 +0530
Subject: [PATCH 06/10] feat: pr detail endpoint and fix async filter

---
 app.js         |  3 +++
 src/helpers.js | 47 ++++++++++++++++++++++++++++++++++++++++++++++-
 src/routes.js  | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 98 insertions(+), 1 deletion(-)

diff --git a/app.js b/app.js
index 20176c7..f010432 100644
--- a/app.js
+++ b/app.js
@@ -239,6 +239,9 @@ http
       case "GET /contributions":
         routes.listPullRequests(req, res, app);
         break;
+      case "GET /contributions/detail":
+        routes.getPullRequestDetail(req, res, app);
+        break;
       case "POST /api/webhook":
         middleware(req, res);
         break;
diff --git a/src/helpers.js b/src/helpers.js
index 83944c7..4f0a773 100644
--- a/src/helpers.js
+++ b/src/helpers.js
@@ -76,10 +76,13 @@ export function isExternalContributionMaybe(pullRequest) {
     // NONE: Author has no association with the repository (or doesn't want to make his association public).
     switch (pullRequest.author_association.toUpperCase()) {
       case "OWNER":
+        //TODO: Cache isExternalContributionInfo { owner/repo/number: false }
         return false;
       case "MEMBER":
+        //TODO: Cache isExternalContributionInfo { owner/repo/number: false }
         return false;
       case "COLLABORATOR":
+        //TODO: Cache isExternalContributionInfo { owner/repo/number: false }
         return false;
       default:
         //TODO: Need more checks to verify author relation with the repo
@@ -87,6 +90,7 @@ export function isExternalContributionMaybe(pullRequest) {
     }
   }
   if (pullRequest?.head?.repo?.full_name !== pullRequest?.base?.repo?.full_name) {
+    //TODO: Cache isExternalContributionInfo { owner/repo/number: true }
     return true;
   }
   // Ambigous results after this point.
@@ -105,6 +109,7 @@ async function isExternalContribution(octokit, pullRequest) {
   const { owner, repo } = parseRepoUrl(pullRequest?.repository_url) || {};
   //TODO: Handle failure in checking permissions for the user
   const deterministicPermissionCheck = await isAllowedToWriteToTheRepo(octokit, username, owner, repo);
+  //TODO: Cache isExternalContributionInfo { owner/repo/number: deterministicPermissionCheck }
   return deterministicPermissionCheck;
 }
 
@@ -304,6 +309,17 @@ export function jsonToCSV(arr) {
   return csvRows.join('\n');
 }
 
+/**
+ * Authenticate as app installation for the org
+ * Authenticating as an app installation lets your app access resources that are owned by the user or organization
+ * that installed the app. Authenticating as an app installation is ideal for automation workflows
+ * that don't involve user input.
+ * Check out { @link https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/about-authentication-with-a-github-app GitHub Docs for Authentication }
+ *  and { @tutorial https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation GitHub Docs for Authenticating App Installation}
+ * @param {Object} app 
+ * @param {string} org 
+ * @returns 
+ */
 export async function getOctokitForOrg(app, org) {
   // Find the installation for the organization
   for await (const { installation } of app.eachInstallation.iterator()) {
@@ -414,7 +430,20 @@ export async function getOpenExternalPullRequests(app, owner, repo, options) {
       return;
     }
     // Send only the external PRs
-    const openExternalPRs = openPRs?.filter(async (pr) => await isExternalContribution(octokit, pr))
+    const openExternalPRs = []
+    for (const pr of openPRs) {
+      try {
+        pr.isExternalContribution = await isExternalContribution(octokit, pr);
+        if (pr.isExternalContribution) {
+          openExternalPRs.push(pr);
+        }
+      } catch (err) {
+        // Some error occurred, so we cannot deterministically say whether it is an external contribution or not
+        pr.isExternalContribution = undefined;
+        // We are anyways going to send this in the external open PR list
+        openExternalPRs.push(pr);
+      }
+    }
     return openExternalPRs
   } catch (err) {
     return
@@ -485,5 +514,21 @@ async function isAllowedToWriteToTheRepo(octokit, username, owner, repo,) {
     // Only "metadata:repository" permission is needed for this api, which all gh apps have wherever they are installed
     console.log("Failed to check if a " + username + " is allowed to write to " + owner + "/" + repo);
     console.error(err);
+    throw new Error("Failed to check user permission for the repo")
   }
+}
+
+export async function getPullRequestDetail(app, owner, repo, number) {
+  const octokit = await getOctokitForOrg(app, owner);
+  if (!octokit) {
+    throw new Error("Failed to search PR because of undefined octokit intance")
+  }
+  const { data } = await octokit.rest.pulls.get({
+    owner: owner,
+    repo: repo,
+    pull_number: number
+  });
+  if (!data) return data;
+  const pr = Object.assign({}, data, { isExternalContribution: isExternalContributionMaybe(data) });
+  return pr;
 }
\ No newline at end of file
diff --git a/src/routes.js b/src/routes.js
index 169a1e6..dbb2701 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -11,6 +11,7 @@ import {
   parseUrlQueryParams,
   jsonToCSV,
   getOpenExternalPullRequests,
+  getPullRequestDetail,
   timeAgo
 } from "./helpers.js";
 import { isPasswordValid } from "./auth.js";
@@ -245,6 +246,45 @@ export const routes = {
                   </html>`);
     res.end();
   },
+  async getPullRequestDetail(req, res, app) {
+    const { org, repo, number } = parseUrlQueryParams(req.url) || {};
+    if (!org) {
+      res.writeHead(400);
+      return res.end("Please add org parameter in the url e.g. ?org=my-github-org-name");
+    }
+    const pr = await getPullRequestDetail(app, org, repo, number);
+    if (req.headers['content-type']?.toLowerCase() === 'application/json') {
+      res.setHeader('Content-Type', 'application/json');
+      const jsonString = pr ? JSON.stringify(pr, null, 2) : ("No Pull Requests found (or you don't have access to get this PR " + org + "/" + repo + "/" + number);
+      return res.end(jsonString);
+    }
+    res.writeHead(200, { 'Content-Type': 'text/html' });
+    res.write(`<!DOCTYPE html>
+                <html>
+                <head>
+                  <title>Pull Request Detail</title>
+                  <style>
+                        .tabs { margin-bottom: 20px; }
+                        .tab-button { cursor: pointer; padding: 10px; margin-right: 5px; background-color: #ccc; border: none; }
+                        .tab-button.active { background-color: #999; }
+                        .tab-content { display: none; }
+                        .tab-content.active { display: block; }
+                    </style>
+                  </head>
+                  <body>
+                      <h1>Pull Request Details</h1>
+                      <code>
+                        <pre>
+                          ${JSON.stringify(pr, null, 2)}
+                        </pre>
+                      </code>
+                      <br/><br/>
+                  </body>
+                  <script>
+                      
+                  </script>
+                  </html>`);
+  },
   // ${!Array.isArray(prs) || prs?.length < 1 ? "No contributions found! (Might be an access issue)" : prs?.map(pr => `<li><a href="${pr?.user?.html_url}">${pr?.user?.login}</a> contributed a PR - <a href="${pr?.html_url}" target="_blank">${pr?.title}</a> [${pr?.labels?.map(label => label?.name).join('] [')}]  <small>updated ${timeAgo(pr?.updated_at)}</small></li>`).join('')}
   default(req, res) {
     res.writeHead(404);
@@ -254,6 +294,7 @@ export const routes = {
 };
 
 
+
 function groupPullRequestsByUser(prs) {
   if (!Array.isArray(prs) || prs?.length < 1) {
     return "No recent contributions found"
@@ -269,12 +310,17 @@ function groupPullRequestsByUser(prs) {
   for (const user in grouped) {
     html += `<h2>${user} ${isCLASigned(user) ? "✅" : ""}</h2><ul>`;
     grouped[user].forEach(pr => {
+      const repo = pr?.repository_url;
+      const repoName = repo.split('/').slice(-1)[0];
+      const org = repo.split('/').slice(-2)[0];
       const prLabels = pr?.labels?.length > 0 ? "[" + pr?.labels?.map(label => label?.name).join('] [') + "]" : "";
       html += `
           <li>
               <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
               ${prLabels}
+              ${typeof pr.isExternalContribution === "boolean" ? "" : " --Author Association Not Confirmed-- "}
               <small> updated ${timeAgo(pr?.updated_at)}</small>
+              <a href="/contributions/detail?org=${org}&repo=${repoName}&number=${pr?.number}" targe="_blank">Get Details</a>
           </li>`;
     });
     html += '</ul>';
@@ -296,6 +342,7 @@ function groupPullRequestsByRepo(prs) {
   let html = '';
   for (const repo in grouped) {
     const repoName = repo.split('/').slice(-1)[0];
+    const org = repo.split('/').slice(-2)[0];
     html += `<h2>${repoName}</h2><ul>`;
     grouped[repo].forEach(pr => {
       const prLabels = pr?.labels?.length > 0 ? "[" + pr?.labels?.map(label => label?.name).join('] [') + "]" : "";
@@ -304,7 +351,9 @@ function groupPullRequestsByRepo(prs) {
             <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
             by <a target="_blank" href="${pr?.user?.html_url}">${pr?.user?.login} ${isCLASigned(pr?.user?.login) ? "✅" : ""}</a>
             ${prLabels}
+            ${typeof pr.isExternalContribution === "boolean" ? "" : " --Author Association Not Confirmed-- "}
             <small> updated ${timeAgo(pr?.updated_at)}</small>
+            <a href="/contributions/detail?org=${org}&repo=${repoName}&number=${pr?.number}" targe="_blank">Get Details</a>
         </li>`;
     });
     html += '</ul>';

From ec5c0490dae9aa3b6a8c324214ca3f587474f914 Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Thu, 17 Oct 2024 15:53:33 +0530
Subject: [PATCH 07/10] feat: cache pr author association with the repo

---
 src/helpers.js      | 24 ++++++++++++++++--------
 src/routes.js       |  2 +-
 src/storage.js      | 11 +++++++++++
 views/download.html |  1 +
 views/home.html     |  1 -
 5 files changed, 29 insertions(+), 10 deletions(-)

diff --git a/src/helpers.js b/src/helpers.js
index 4f0a773..abc44a3 100644
--- a/src/helpers.js
+++ b/src/helpers.js
@@ -65,6 +65,8 @@ export function isMessageAfterMergeRequired(pullRequest) {
  * @returns {boolean | undefined} - boolean when confirmed, undefined when not confirmed
  */
 export function isExternalContributionMaybe(pullRequest) {
+  const { owner, repo } = parseRepoUrl(pullRequest?.repository_url || pullRequest?.base?.repo?.html_url) || {};
+  const username = pullRequest?.user?.login;
   if (typeof pullRequest?.author_association === "string") {
     // OWNER: Author is the owner of the repository.
     // MEMBER: Author is a member of the organization that owns the repository.
@@ -76,23 +78,29 @@ export function isExternalContributionMaybe(pullRequest) {
     // NONE: Author has no association with the repository (or doesn't want to make his association public).
     switch (pullRequest.author_association.toUpperCase()) {
       case "OWNER":
-        //TODO: Cache isExternalContributionInfo { owner/repo/number: false }
+        storage.cache.set(false, username, "contribution", "external", owner, repo);
         return false;
       case "MEMBER":
-        //TODO: Cache isExternalContributionInfo { owner/repo/number: false }
+        storage.cache.set(false, username, "contribution", "external", owner, repo);
         return false;
       case "COLLABORATOR":
-        //TODO: Cache isExternalContributionInfo { owner/repo/number: false }
+        pullRequest.isExternalContribution = false;
+        storage.cache.set(false, username, "contribution", "external", owner, repo);
         return false;
       default:
-        //TODO: Need more checks to verify author relation with the repo
+        //Will need more checks to verify author relation with the repo
         break;
     }
   }
   if (pullRequest?.head?.repo?.full_name !== pullRequest?.base?.repo?.full_name) {
-    //TODO: Cache isExternalContributionInfo { owner/repo/number: true }
+    storage.cache.set(true, username, "contribution", "external", owner, repo);
     return true;
   }
+  // Utilize cache if possible
+  const isConfirmedToBeExternalContributionInPast = storage.cache.get(username, "contribution", "external", owner, repo);
+  if (typeof isConfirmedToBeExternalContributionInPast === "boolean") {
+    return isConfirmedToBeExternalContributionInPast
+  }
   // Ambigous results after this point.
   // Cannot confirm whether an external contribution or not.
   // Need more reliable check.
@@ -106,10 +114,11 @@ async function isExternalContribution(octokit, pullRequest) {
     return probablisticResult;
   }
   const username = pullRequest?.user?.login;
-  const { owner, repo } = parseRepoUrl(pullRequest?.repository_url) || {};
+  const { owner, repo } = parseRepoUrl(pullRequest?.repository_url || pullRequest?.base?.repo?.html_url) || {};
   //TODO: Handle failure in checking permissions for the user
   const deterministicPermissionCheck = await isAllowedToWriteToTheRepo(octokit, username, owner, repo);
-  //TODO: Cache isExternalContributionInfo { owner/repo/number: deterministicPermissionCheck }
+  pullRequest.isExternalContribution = deterministicPermissionCheck;
+  storage.cache.set(pullRequest, username, "contribution", "external", owner, repo);
   return deterministicPermissionCheck;
 }
 
@@ -500,7 +509,6 @@ async function isAllowedToWriteToTheRepo(octokit, username, owner, repo,) {
       repo,
       username,
     });
-    //TODO: Cache request result
     if (["admin", "write"].includes(result?.permission)) {
       return true
     }
diff --git a/src/routes.js b/src/routes.js
index dbb2701..973c1f2 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -259,7 +259,7 @@ export const routes = {
       return res.end(jsonString);
     }
     res.writeHead(200, { 'Content-Type': 'text/html' });
-    res.write(`<!DOCTYPE html>
+    res.end(`<!DOCTYPE html>
                 <html>
                 <head>
                   <title>Pull Request Detail</title>
diff --git a/src/storage.js b/src/storage.js
index 493452d..a6a1b45 100644
--- a/src/storage.js
+++ b/src/storage.js
@@ -4,6 +4,7 @@ import { PROJECT_ROOT_PATH } from "./config.js";
 
 const dbPath = process.env.DB_PATH || resolve(PROJECT_ROOT_PATH, "db.json");
 createFileIfMissing(dbPath);
+const CACHE = new Map();
 
 function createFileIfMissing(path) {
   try {
@@ -43,4 +44,14 @@ export const storage = {
       return true;
     });
   },
+  cache: {
+    get: function (...args) {
+      const key = args.join("/");
+      return CACHE.get(key);
+    },
+    set: function (value, ...args) {
+      const key = args.join("/");
+      return CACHE.set(key, value);
+    }
+  }
 };
diff --git a/views/download.html b/views/download.html
index 825a553..d9bbdcd 100644
--- a/views/download.html
+++ b/views/download.html
@@ -41,6 +41,7 @@ <h2>⬇️ Download Center</h2>
       <hr/>
       <ul>
         <li><a href="/">Home</a></li>
+        <li><a href="/contributions">Contributions in progress</a></li>
       </ul>
     </p>
   </div>
diff --git a/views/home.html b/views/home.html
index a65d21b..237a6a8 100644
--- a/views/home.html
+++ b/views/home.html
@@ -30,7 +30,6 @@ <h2>🙏 Get started with contribution to RudderStack Open Source</h2>
       <hr/>
       Tools & resources for RudderStack contributors
       <ul>
-        <li><a href="/contributions">Contributions in progress</a></li>
         <li><a href="https://www.rudderstack.com/docs/resources/community/#contribute" target="_blank">Contribution guide</a></li>
         <li><a href="https://www.rudderstack.com/docs/user-guides/how-to-guides/developing-integrations-for-rudderstack/" target="_blank">Create a new integration</a></li>
         <li><a href="https://github.com/rudderlabs/rudder-server/discussions/new?category=feature-requests" target="_blank">Request a new feature</a></li>

From d85d5f82e7d129559040d6028e9a9d2ffa9d04c4 Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Fri, 18 Oct 2024 06:36:16 +0530
Subject: [PATCH 08/10] fix: minor html fixes for pr list

---
 src/routes.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/routes.js b/src/routes.js
index 973c1f2..d0925f3 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -318,9 +318,9 @@ function groupPullRequestsByUser(prs) {
           <li>
               <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
               ${prLabels}
-              ${typeof pr.isExternalContribution === "boolean" ? "" : " --Author Association Not Confirmed-- "}
               <small> updated ${timeAgo(pr?.updated_at)}</small>
-              <a href="/contributions/detail?org=${org}&repo=${repoName}&number=${pr?.number}" targe="_blank">Get Details</a>
+              <a href="/contributions/detail?org=${org}&repo=${repoName}&number=${pr?.number}" target="_blank"><button>Get Details</button></a>
+              <small>${typeof pr.isExternalContribution === "boolean" ? "" : " (Click to confirm author association) "}</small>
           </li>`;
     });
     html += '</ul>';
@@ -351,9 +351,9 @@ function groupPullRequestsByRepo(prs) {
             <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
             by <a target="_blank" href="${pr?.user?.html_url}">${pr?.user?.login} ${isCLASigned(pr?.user?.login) ? "✅" : ""}</a>
             ${prLabels}
-            ${typeof pr.isExternalContribution === "boolean" ? "" : " --Author Association Not Confirmed-- "}
             <small> updated ${timeAgo(pr?.updated_at)}</small>
-            <a href="/contributions/detail?org=${org}&repo=${repoName}&number=${pr?.number}" targe="_blank">Get Details</a>
+            <a href="/contributions/detail?org=${org}&repo=${repoName}&number=${pr?.number}" target="_blank"><button>Get Details</button></a>
+            <small>${typeof pr.isExternalContribution === "boolean" ? "" : " (Click to confirm author association) "}</small>
         </li>`;
     });
     html += '</ul>';

From 68688af77440d3c268fa901155126c95d66a095f Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Fri, 18 Oct 2024 06:38:07 +0530
Subject: [PATCH 09/10] refactor: rename contirb detail route to contrib pr

---
 app.js        | 2 +-
 src/routes.js | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app.js b/app.js
index f010432..a5b3cdf 100644
--- a/app.js
+++ b/app.js
@@ -239,7 +239,7 @@ http
       case "GET /contributions":
         routes.listPullRequests(req, res, app);
         break;
-      case "GET /contributions/detail":
+      case "GET /contributions/pr":
         routes.getPullRequestDetail(req, res, app);
         break;
       case "POST /api/webhook":
diff --git a/src/routes.js b/src/routes.js
index d0925f3..a4eb66d 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -319,7 +319,7 @@ function groupPullRequestsByUser(prs) {
               <a href="${pr?.html_url}" target="_blank">${pr?.title}</a>
               ${prLabels}
               <small> updated ${timeAgo(pr?.updated_at)}</small>
-              <a href="/contributions/detail?org=${org}&repo=${repoName}&number=${pr?.number}" target="_blank"><button>Get Details</button></a>
+              <a href="/contributions/pr?org=${org}&repo=${repoName}&number=${pr?.number}" target="_blank"><button>Get Details</button></a>
               <small>${typeof pr.isExternalContribution === "boolean" ? "" : " (Click to confirm author association) "}</small>
           </li>`;
     });
@@ -352,7 +352,7 @@ function groupPullRequestsByRepo(prs) {
             by <a target="_blank" href="${pr?.user?.html_url}">${pr?.user?.login} ${isCLASigned(pr?.user?.login) ? "✅" : ""}</a>
             ${prLabels}
             <small> updated ${timeAgo(pr?.updated_at)}</small>
-            <a href="/contributions/detail?org=${org}&repo=${repoName}&number=${pr?.number}" target="_blank"><button>Get Details</button></a>
+            <a href="/contributions/pr?org=${org}&repo=${repoName}&number=${pr?.number}" target="_blank"><button>Get Details</button></a>
             <small>${typeof pr.isExternalContribution === "boolean" ? "" : " (Click to confirm author association) "}</small>
         </li>`;
     });

From f4c33bb9a4b7f0f5450bd2f35098ee99859482e8 Mon Sep 17 00:00:00 2001
From: gitcommitshow <56937085+gitcommitshow@users.noreply.github.com>
Date: Fri, 18 Oct 2024 06:40:55 +0530
Subject: [PATCH 10/10] fix: style changes

---
 src/routes.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/routes.js b/src/routes.js
index a4eb66d..97833ba 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -320,7 +320,7 @@ function groupPullRequestsByUser(prs) {
               ${prLabels}
               <small> updated ${timeAgo(pr?.updated_at)}</small>
               <a href="/contributions/pr?org=${org}&repo=${repoName}&number=${pr?.number}" target="_blank"><button>Get Details</button></a>
-              <small>${typeof pr.isExternalContribution === "boolean" ? "" : " (Click to confirm author association) "}</small>
+              <small style="opacity: 0.6">${typeof pr.isExternalContribution === "boolean" ? "" : " (Click to confirm author association) "}</small>
           </li>`;
     });
     html += '</ul>';
@@ -353,7 +353,7 @@ function groupPullRequestsByRepo(prs) {
             ${prLabels}
             <small> updated ${timeAgo(pr?.updated_at)}</small>
             <a href="/contributions/pr?org=${org}&repo=${repoName}&number=${pr?.number}" target="_blank"><button>Get Details</button></a>
-            <small>${typeof pr.isExternalContribution === "boolean" ? "" : " (Click to confirm author association) "}</small>
+            <small style="opacity: 0.6">${typeof pr.isExternalContribution === "boolean" ? "" : " (Click to confirm author association) "}</small>
         </li>`;
     });
     html += '</ul>';