From 3e5be55927393a5f5ac31f60f0528bb3dd65141d Mon Sep 17 00:00:00 2001
From: David Heryanto <david.heryanto@hotmail.com>
Date: Mon, 24 Feb 2020 12:17:42 +0800
Subject: [PATCH] Rename metric name for request latency in feast serving So
 that it is consistent with the actual unit of timing being measured And
 recommended metric names in Prometheus
 https://prometheus.io/docs/practices/naming/#metric-names

---
 .../main/java/feast/serving/service/RedisServingService.java  | 2 +-
 serving/src/main/java/feast/serving/util/Metrics.java         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/serving/src/main/java/feast/serving/service/RedisServingService.java b/serving/src/main/java/feast/serving/service/RedisServingService.java
index 48fc485214d..24c69b9f796 100644
--- a/serving/src/main/java/feast/serving/service/RedisServingService.java
+++ b/serving/src/main/java/feast/serving/service/RedisServingService.java
@@ -313,7 +313,7 @@ private List<byte[]> sendMultiGet(List<RedisKey> keys) {
       } finally {
         requestLatency
             .labels("sendMultiGet")
-            .observe((System.currentTimeMillis() - startTime) / 1000);
+            .observe((System.currentTimeMillis() - startTime) / 1000d);
       }
     }
   }
diff --git a/serving/src/main/java/feast/serving/util/Metrics.java b/serving/src/main/java/feast/serving/util/Metrics.java
index 99f6353e742..05546ec384b 100644
--- a/serving/src/main/java/feast/serving/util/Metrics.java
+++ b/serving/src/main/java/feast/serving/util/Metrics.java
@@ -24,9 +24,9 @@ public class Metrics {
   public static final Histogram requestLatency =
       Histogram.build()
           .buckets(0.001, 0.002, 0.004, 0.006, 0.008, 0.01, 0.015, 0.02, 0.025, 0.03, 0.035, 0.05)
-          .name("request_latency_ms")
+          .name("request_latency_seconds")
           .subsystem("feast_serving")
-          .help("Request latency in seconds.")
+          .help("Request latency in seconds")
           .labelNames("method")
           .register();