From ac44d2ee3f8fc1727e6300cc66b7ccc9ebe245b8 Mon Sep 17 00:00:00 2001 From: Ches Martin Date: Thu, 9 Jan 2020 12:21:14 +0700 Subject: [PATCH] Publish datatypes/java along with sdk/java This forward-ports a straggling commit from #407: it was missed when initially creating the datatypes module because Sonatype publishing setup was added concurrently. --- .prow/scripts/publish-java-sdk.sh | 2 +- datatypes/java/README.md | 20 ++++++++++++++++---- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/.prow/scripts/publish-java-sdk.sh b/.prow/scripts/publish-java-sdk.sh index 17513d0eb0d..91123c8d4ee 100755 --- a/.prow/scripts/publish-java-sdk.sh +++ b/.prow/scripts/publish-java-sdk.sh @@ -69,4 +69,4 @@ gpg --import --batch --yes $GPG_KEY_IMPORT_DIR/private-key echo "============================================================" echo "Deploying Java SDK with revision: $REVISION" echo "============================================================" -mvn --projects sdk/java -Drevision=$REVISION --batch-mode clean deploy +mvn --projects datatypes/java,sdk/java -Drevision=$REVISION --batch-mode clean deploy diff --git a/datatypes/java/README.md b/datatypes/java/README.md index f93bd99aa38..535fac73d2e 100644 --- a/datatypes/java/README.md +++ b/datatypes/java/README.md @@ -20,6 +20,11 @@ Dependency Coordinates ``` +Use the version corresponding to the Feast release you have deployed in your +environment—see the [Feast release notes] for details. + +[Feast release notes]: ../../CHANGELOG.md + Using the `.proto` Definitions ------------------------------ @@ -36,8 +41,15 @@ either for `include` or to compile with a different `protoc` plugin than Java. [Gradle]: https://github.com/google/protobuf-gradle-plugin#protos-in-dependencies [sbt-protoc]: https://github.com/thesamet/sbt-protoc -Publishing ----------- +Releases +-------- + +The module is published to Maven Central upon each release of Feast (since +v0.3.7). + +For developers, the publishing process is automated along with the Java SDK by +[the `publish-java-sdk` build task in Prow][prow task], where you can see how +it works. Artifacts are staged to Sonatype where a maintainer needs to take a +release action for them to go live on Maven Central. -TODO: this module should be published to Maven Central upon Feast releases—this -needs to be set up in POM configuration and release automation. +[prow task]: https://github.com/gojek/feast/blob/17e7dca8238aae4dcbf0ff9f0db5d80ef8e035cf/.prow/config.yaml#L166-L192