From d90e402562fdd25672433f634210dafa74b52b57 Mon Sep 17 00:00:00 2001 From: Dimitris Stafylarakis Date: Fri, 30 Dec 2022 14:04:00 +0100 Subject: [PATCH 1/2] Fix get_table_column_names_and_types for postgres source Signed-off-by: Dimitris Stafylarakis --- .../contrib/postgres_offline_store/postgres_source.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py index 8a2e13e5c1c..d858c5e3915 100644 --- a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py +++ b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py @@ -112,7 +112,7 @@ def get_table_column_names_and_types( ) -> Iterable[Tuple[str, str]]: with _get_conn(config.offline_store) as conn, conn.cursor() as cur: cur.execute( - f"SELECT * FROM ({self.get_table_query_string()}) AS sub LIMIT 0" + f"SELECT * FROM {self.get_table_query_string()} AS sub LIMIT 0" ) return ( (c.name, pg_type_code_to_pg_type(c.type_code)) for c in cur.description From 64b31a46a3320432c35a2e8762d3d1ebe33e89c9 Mon Sep 17 00:00:00 2001 From: Dimitris Stafylarakis Date: Fri, 30 Dec 2022 14:05:38 +0100 Subject: [PATCH 2/2] make linter happy Signed-off-by: Dimitris Stafylarakis --- .../contrib/postgres_offline_store/postgres_source.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py index d858c5e3915..bc535ed1940 100644 --- a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py +++ b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py @@ -111,9 +111,7 @@ def get_table_column_names_and_types( self, config: RepoConfig ) -> Iterable[Tuple[str, str]]: with _get_conn(config.offline_store) as conn, conn.cursor() as cur: - cur.execute( - f"SELECT * FROM {self.get_table_query_string()} AS sub LIMIT 0" - ) + cur.execute(f"SELECT * FROM {self.get_table_query_string()} AS sub LIMIT 0") return ( (c.name, pg_type_code_to_pg_type(c.type_code)) for c in cur.description )