From ae703871dc67f6a3bc351f3beb5cda1fbd8f9401 Mon Sep 17 00:00:00 2001 From: Kevin Zhang Date: Wed, 22 Jun 2022 18:55:25 -0700 Subject: [PATCH 1/2] Renable tests Signed-off-by: Kevin Zhang --- sdk/python/tests/integration/e2e/test_go_feature_server.py | 6 +++--- .../tests/integration/online_store/test_universal_online.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sdk/python/tests/integration/e2e/test_go_feature_server.py b/sdk/python/tests/integration/e2e/test_go_feature_server.py index bf6d4636093..4fd003c1944 100644 --- a/sdk/python/tests/integration/e2e/test_go_feature_server.py +++ b/sdk/python/tests/integration/e2e/test_go_feature_server.py @@ -122,7 +122,7 @@ def grpc_client(grpc_server_port): @pytest.mark.integration -# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed. +@pytest.mark.goserver def test_go_grpc_server(grpc_client): resp: GetOnlineFeaturesResponse = grpc_client.GetOnlineFeatures( GetOnlineFeaturesRequest( @@ -148,7 +148,7 @@ def test_go_grpc_server(grpc_client): @pytest.mark.integration -# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed. +@pytest.mark.goserver def test_go_http_server(http_server_port): response = requests.post( f"http://localhost:{http_server_port}/get-online-features", @@ -186,7 +186,7 @@ def test_go_http_server(http_server_port): @pytest.mark.integration -# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed. +@pytest.mark.goserver @pytest.mark.universal_offline_stores @pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v)) def test_feature_logging( diff --git a/sdk/python/tests/integration/online_store/test_universal_online.py b/sdk/python/tests/integration/online_store/test_universal_online.py index c068e041116..b01448e7ccc 100644 --- a/sdk/python/tests/integration/online_store/test_universal_online.py +++ b/sdk/python/tests/integration/online_store/test_universal_online.py @@ -443,7 +443,7 @@ def test_online_retrieval_with_event_timestamps( @pytest.mark.integration @pytest.mark.universal_online_stores -# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed. +@pytest.mark.goserver @pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v)) def test_stream_feature_view_online_retrieval( environment, universal_data_sources, feature_server_endpoint, full_feature_names @@ -519,7 +519,7 @@ def test_stream_feature_view_online_retrieval( @pytest.mark.integration @pytest.mark.universal_online_stores -# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed. +@pytest.mark.goserver @pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v)) def test_online_retrieval( environment, universal_data_sources, feature_server_endpoint, full_feature_names From e104b8ab7e204351a35f90892d0a68275bd5bc67 Mon Sep 17 00:00:00 2001 From: Kevin Zhang Date: Thu, 23 Jun 2022 09:09:09 -0700 Subject: [PATCH 2/2] Renable tests Signed-off-by: Kevin Zhang --- .../tests/integration/online_store/test_universal_online.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/tests/integration/online_store/test_universal_online.py b/sdk/python/tests/integration/online_store/test_universal_online.py index b01448e7ccc..9fdb19eae7c 100644 --- a/sdk/python/tests/integration/online_store/test_universal_online.py +++ b/sdk/python/tests/integration/online_store/test_universal_online.py @@ -519,7 +519,7 @@ def test_stream_feature_view_online_retrieval( @pytest.mark.integration @pytest.mark.universal_online_stores -@pytest.mark.goserver +# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed. @pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v)) def test_online_retrieval( environment, universal_data_sources, feature_server_endpoint, full_feature_names