Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fdr/heroku-wal-e
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: fdr/heroku-wal-e
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: structured-logging
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 14 files changed
  • 1 contributor

Commits on Dec 3, 2012

  1. Emit correct error message when there is a problem with psql

    Mechanism: only EnvironmentErrors are being handled nowadays to
    trigger the error-message-accumulation and reporting logic, so fake up
    an EnvironmentError as to let normal error handling take place here.
    
    This is definitely a kludge, but it doesn't seem worth it perform the
    obvious alternative option, which is making a new exception type to
    treat the same problem.
    
    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 3, 2012
    Configuration menu
    Copy the full SHA
    4d1052e View commit details
    Browse the repository at this point in the history
  2. Set setup.py executable bit

    For ./setup.py in the shell
    
    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 3, 2012
    Configuration menu
    Copy the full SHA
    2ddf186 View commit details
    Browse the repository at this point in the history
  3. Move rate-limiting from source files to output of tarfile generation

    This has the main benefit of being conceptually cleaner (cleaning up
    the tar_partition module) as well as thought to being much faster in
    cases where there are many files being archived.
    
    As a target of opportunity, refactor to clean up complexity in dealing
    with optional pipeline steps, by making PipelineCommand lazy (init,
    then start).  There is still some complexity because one must call
    .start() before pushing around file descriptors, since they do not
    have a defined value before the program in question is started.
    
    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 3, 2012
    Configuration menu
    Copy the full SHA
    2f7d204 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2012

  1. Add structured output support to logging

    An optional 'structured' keyword argument taking a dictionary is now
    supported and logged (and is *not* escaped) in the key=value<SPC>
    format.
    
    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 4, 2012
    Configuration menu
    Copy the full SHA
    750a0aa View commit details
    Browse the repository at this point in the history
  2. Pyflakes cleanup run

    That was a lot of flakes.  However, there were also some false
    positives that I gave treatment, too.
    
    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 4, 2012
    Configuration menu
    Copy the full SHA
    1c2e469 View commit details
    Browse the repository at this point in the history
  3. PEP-8 cleanup

    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 4, 2012
    Configuration menu
    Copy the full SHA
    dbf0dde View commit details
    Browse the repository at this point in the history
  4. Try to handle EACCES in logging set-up

    I tried to find a way to write a test for this, but it led to a lot of
    overwrought code for this error, which I have witnessed but once ever:
    in particular, testing the retry behavior (inverting control seemed
    invasive and made the code harder to read).
    
    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 4, 2012
    Configuration menu
    Copy the full SHA
    dc94bac View commit details
    Browse the repository at this point in the history
  5. Long overdue VERSION increment

    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 4, 2012
    Configuration menu
    Copy the full SHA
    10cc320 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2012

  1. Add structured logging for wal-push and wal-fetch

    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 5, 2012
    Configuration menu
    Copy the full SHA
    5c2647e View commit details
    Browse the repository at this point in the history
  2. Set the storage version back to 005

    It doesn't look like any storage format changes will be happening in
    the next release, and as-is this breaks inter-operation with existing
    0.5.x archives.
    
    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 5, 2012
    Configuration menu
    Copy the full SHA
    39b81a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2012

  1. Change the logging format: move time and pid to the structured fields

    This was raised by Ed Muller <edward@heroku.com> as something that
    makes the structured format much more useful.  Unwilling to duplicate
    the time and pid information at both the log header and in the
    structured information fields, this patch opts to move time to the
    structured area.
    
    However, as a service to human readers, the time and pid fields are
    guaranteed to come first.  Previously, all fields were lexically
    sorted.
    
    Signed-off-by: Daniel Farina <daniel@heroku.com>
    Daniel Farina committed Dec 7, 2012
    Configuration menu
    Copy the full SHA
    b7073cf View commit details
    Browse the repository at this point in the history
Loading