-
Notifications
You must be signed in to change notification settings - Fork 27
Comparing changes
Open a pull request
base repository: fdr/heroku-wal-e
base: master
head repository: fdr/heroku-wal-e
compare: structured-logging
- 11 commits
- 14 files changed
- 1 contributor
Commits on Dec 3, 2012
-
Emit correct error message when there is a problem with psql
Mechanism: only EnvironmentErrors are being handled nowadays to trigger the error-message-accumulation and reporting logic, so fake up an EnvironmentError as to let normal error handling take place here. This is definitely a kludge, but it doesn't seem worth it perform the obvious alternative option, which is making a new exception type to treat the same problem. Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 3, 2012 Configuration menu - View commit details
-
Copy full SHA for 4d1052e - Browse repository at this point
Copy the full SHA 4d1052eView commit details -
For ./setup.py in the shell Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 3, 2012 Configuration menu - View commit details
-
Copy full SHA for 2ddf186 - Browse repository at this point
Copy the full SHA 2ddf186View commit details -
Move rate-limiting from source files to output of tarfile generation
This has the main benefit of being conceptually cleaner (cleaning up the tar_partition module) as well as thought to being much faster in cases where there are many files being archived. As a target of opportunity, refactor to clean up complexity in dealing with optional pipeline steps, by making PipelineCommand lazy (init, then start). There is still some complexity because one must call .start() before pushing around file descriptors, since they do not have a defined value before the program in question is started. Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 3, 2012 Configuration menu - View commit details
-
Copy full SHA for 2f7d204 - Browse repository at this point
Copy the full SHA 2f7d204View commit details
Commits on Dec 4, 2012
-
Add structured output support to logging
An optional 'structured' keyword argument taking a dictionary is now supported and logged (and is *not* escaped) in the key=value<SPC> format. Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 4, 2012 Configuration menu - View commit details
-
Copy full SHA for 750a0aa - Browse repository at this point
Copy the full SHA 750a0aaView commit details -
That was a lot of flakes. However, there were also some false positives that I gave treatment, too. Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 4, 2012 Configuration menu - View commit details
-
Copy full SHA for 1c2e469 - Browse repository at this point
Copy the full SHA 1c2e469View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbf0dde - Browse repository at this point
Copy the full SHA dbf0ddeView commit details -
Try to handle EACCES in logging set-up
I tried to find a way to write a test for this, but it led to a lot of overwrought code for this error, which I have witnessed but once ever: in particular, testing the retry behavior (inverting control seemed invasive and made the code harder to read). Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 4, 2012 Configuration menu - View commit details
-
Copy full SHA for dc94bac - Browse repository at this point
Copy the full SHA dc94bacView commit details -
Long overdue VERSION increment
Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 4, 2012 Configuration menu - View commit details
-
Copy full SHA for 10cc320 - Browse repository at this point
Copy the full SHA 10cc320View commit details
Commits on Dec 5, 2012
-
Add structured logging for wal-push and wal-fetch
Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 5, 2012 Configuration menu - View commit details
-
Copy full SHA for 5c2647e - Browse repository at this point
Copy the full SHA 5c2647eView commit details -
Set the storage version back to 005
It doesn't look like any storage format changes will be happening in the next release, and as-is this breaks inter-operation with existing 0.5.x archives. Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 5, 2012 Configuration menu - View commit details
-
Copy full SHA for 39b81a0 - Browse repository at this point
Copy the full SHA 39b81a0View commit details
Commits on Dec 7, 2012
-
Change the logging format: move time and pid to the structured fields
This was raised by Ed Muller <edward@heroku.com> as something that makes the structured format much more useful. Unwilling to duplicate the time and pid information at both the log header and in the structured information fields, this patch opts to move time to the structured area. However, as a service to human readers, the time and pid fields are guaranteed to come first. Previously, all fields were lexically sorted. Signed-off-by: Daniel Farina <daniel@heroku.com>
Daniel Farina committedDec 7, 2012 Configuration menu - View commit details
-
Copy full SHA for b7073cf - Browse repository at this point
Copy the full SHA b7073cfView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...structured-logging