From adbc468b6fcd1f168e0c45617e999c63f261a3fb Mon Sep 17 00:00:00 2001
From: Michael Lange <dingoeatingfuzz@gmail.com>
Date: Thu, 29 Dec 2016 11:13:32 -0800
Subject: [PATCH] Use synchronous control flow when making synchronous requests

The onload event for XHRs does not fire when the XHR is synchronous.
This was causing the callback to never be called and the test suite
to hang indefinitely.
---
 lib/templates/test-body-footer.html | 70 +++++++++++++++++------------
 1 file changed, 41 insertions(+), 29 deletions(-)

diff --git a/lib/templates/test-body-footer.html b/lib/templates/test-body-footer.html
index f847f1ed..ba5c8c4e 100644
--- a/lib/templates/test-body-footer.html
+++ b/lib/templates/test-body-footer.html
@@ -1,6 +1,7 @@
 <script>
   // Make synchronous requests in phantom to avoid killing the runner before the coverage completes.
   var REQUEST_ASYNC = !/PhantomJS/.test(window.navigator.userAgent);
+
   function sendCoverage(callback) {
    Object.keys(require.entries).forEach(function(file) {
       // Only load non-test files from the project
@@ -21,38 +22,18 @@
     request.open('POST', '/write-coverage', REQUEST_ASYNC);
     request.setRequestHeader('Content-Type', 'application/json; charset=utf-8');
     request.send(data);
-    request.responseType = 'json';
-
-    request.onload = function() {
-      var data = this.response;
-
-      // PhantomJS doesn't honor `responseType = 'json'`
-      if (typeof data === 'string') {
-        data = JSON.parse(data);
-      }
 
-      if (!data || !data.total) {
-        return;
+    if (REQUEST_ASYNC) {
+      request.responseType = 'json';
+      request.onload = function() {
+        handleCoverageResponse(this, callback);
       }
-
-      var results = ['Lines', 'Branches', 'Functions', 'Statements']
-        .filter(function (name) {
-          return data.total[name.toLowerCase()]
-        })
-        .map(function (name) {
-          return name + ' ' + data.total[name.toLowerCase()].pct + '%'
-        });
-
-      var resultsText = document.createTextNode(results.join(' | '));
-      var element = document.createElement('div');
-      element.style = 'background-color: white; color: black; border: 2px solid black; padding: 1em;position: fixed; left: 15px; bottom: 15px';
-      element.appendChild(resultsText);
-      document.body.appendChild(element);
-
-      if (callback) {
-        callback();
+    } else {
+      // The request is already done at this point, since it is synchronous
+      if (request.status === 200) {
+        handleCoverageResponse(request, callback);
       }
-    };
+    }
   }
 
   if (typeof Testem !== "undefined" && Testem.afterTests) {
@@ -64,4 +45,35 @@
       sendCoverage();
     });
   }
+
+  function handleCoverageResponse(xhr, callback) {
+    var data = xhr.response;
+
+    // PhantomJS doesn't honor `responseType = 'json'`
+    if (typeof data === 'string') {
+      data = JSON.parse(data);
+    }
+
+    if (!data || !data.total) {
+      return;
+    }
+
+    var results = ['Lines', 'Branches', 'Functions', 'Statements']
+      .filter(function (name) {
+        return data.total[name.toLowerCase()]
+      })
+      .map(function (name) {
+        return name + ' ' + data.total[name.toLowerCase()].pct + '%'
+      });
+
+    var resultsText = document.createTextNode(results.join(' | '));
+    var element = document.createElement('div');
+    element.style = 'background-color: white; color: black; border: 2px solid black; padding: 1em;position: fixed; left: 15px; bottom: 15px';
+    element.appendChild(resultsText);
+    document.body.appendChild(element);
+
+    if (callback) {
+      callback();
+    }
+  }
 </script>