Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MeVisLab/pythonqt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: dev-threads/pythonqt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 15, 2021

  1. Fix a C++20 compatibility issue with an unnamed struct (P1766R1) 

    As a result of P1766R1 [1], `PyHeapTypeObject` can no longer be added
to an unnamed `typedef struct`. On Visual Studio 2019 ≥16.6, this
causes the warning C5208 in C++14 and C++17 mode, and the error C7626
with `/std:c++latest` or the future `/std:c++20`. Giving a name to the
unnamed struct is the simplest fix here [2].

[1]: http://wg21.link/p1766r1
[2]: https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c5208
    @ClaudioHoffmann
    ClaudioHoffmann committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    5a253b6 View commit details
    Browse the repository at this point in the history
Loading