Skip to content

Commit cc94073

Browse files
committed
Remove deprecated TableMetadata.keyspace attribute
1 parent e16a073 commit cc94073

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

cassandra/metadata.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ def _update_table(self, meta):
185185
# return one or the other based on the query results.
186186
# Here we deal with that.
187187
if isinstance(meta, TableMetadata):
188-
meta.keyspace = keyspace_meta # temporary while TableMetadata.keyspace is deprecated
189188
keyspace_meta._add_table_metadata(meta)
190189
else:
191190
keyspace_meta._add_view_metadata(meta)
@@ -952,14 +951,6 @@ class TableMetadata(object):
952951
A representation of the schema for a single table.
953952
"""
954953

955-
keyspace = None
956-
"""
957-
An instance of :class:`~.KeyspaceMetadata`.
958-
959-
.. deprecated:: 2.7.0
960-
961-
"""
962-
963954
keyspace_name = None
964955
""" String name of this Table's keyspace """
965956

@@ -1348,13 +1339,13 @@ def as_cql_query(self):
13481339

13491340
return "CREATE INDEX %s ON %s.%s (%s)" % (
13501341
self.name, # Cassandra doesn't like quoted index names for some reason
1351-
protect_name(table.keyspace.name),
1342+
protect_name(table.keyspace_name),
13521343
protect_name(table.name),
13531344
index_target)
13541345
else:
13551346
return "CREATE CUSTOM INDEX %s ON %s.%s (%s) USING '%s'" % (
13561347
self.name, # Cassandra doesn't like quoted index names for some reason
1357-
protect_name(table.keyspace.name),
1348+
protect_name(table.keyspace_name),
13581349
protect_name(table.name),
13591350
protect_name(self.column.name),
13601351
self.index_options["class_name"])
@@ -1556,7 +1547,7 @@ def __init__(self, table_metadata, trigger_name, options=None):
15561547
def as_cql_query(self):
15571548
ret = "CREATE TRIGGER %s ON %s.%s USING %s" % (
15581549
protect_name(self.name),
1559-
protect_name(self.table.keyspace.name),
1550+
protect_name(self.table.keyspace_name),
15601551
protect_name(self.table.name),
15611552
protect_value(self.options['class'])
15621553
)
@@ -1644,7 +1635,6 @@ def get_all_keyspaces(self):
16441635
try:
16451636
for table_row in self.keyspace_table_rows.get(keyspace_meta.name, []):
16461637
table_meta = self._build_table_metadata(table_row)
1647-
table_meta.keyspace = keyspace_meta # temporary while TableMetadata.keyspace is deprecated
16481638
keyspace_meta._add_table_metadata(table_meta)
16491639

16501640
for usertype_row in self.keyspace_type_rows.get(keyspace_meta.name, []):

tests/integration/standard/test_metadata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def test_basic_table_meta_properties(self):
126126

127127
self.assertTrue(self.cfname in ksmeta.tables)
128128
tablemeta = ksmeta.tables[self.cfname]
129-
self.assertEqual(tablemeta.keyspace, ksmeta) # tablemeta.keyspace is deprecated
129+
self.assertEqual(tablemeta.keyspace_name, ksmeta.name)
130130
self.assertEqual(tablemeta.name, self.cfname)
131131

132132
self.assertEqual([u'a'], [c.name for c in tablemeta.partition_key])

0 commit comments

Comments
 (0)