Remove deprecated cqlengine.columns.Float(double_precision) parameter

aholmberg · aholmberg · commit a2d3a9862ff8 · 2015-10-06T14:38:36.000-05:00
diff --git a/cassandra/cqlengine/columns.py b/cassandra/cqlengine/columns.py
@@ -594,17 +594,6 @@ class Float(BaseFloat):
     """
     db_type = 'float'
 
-    def __init__(self, double_precision=None, **kwargs):
-        if double_precision is None or bool(double_precision):
-            msg = "Float(double_precision=True) is deprecated. Use Double() type instead."
-            double_precision = True
-            warnings.warn(msg, DeprecationWarning)
-            log.warning(msg)
-
-        self.db_type = 'double' if double_precision else 'float'
-
-        super(Float, self).__init__(**kwargs)
-
 
 class Double(BaseFloat):
     """
diff --git a/tests/integration/cqlengine/columns/test_value_io.py b/tests/integration/cqlengine/columns/test_value_io.py
@@ -175,15 +175,9 @@ def comparator_converter(self, val):
         return val if isinstance(val, UUID) else UUID(val)
 
 
-# until Floats are implicitly single:
-class FloatSingle(columns.Float):
-    def __init__(self, **kwargs):
-        super(FloatSingle, self).__init__(double_precision=False, **kwargs)
-
-
 class TestFloatIO(BaseColumnIOTest):
 
-    column = FloatSingle
+    column = columns.Float
 
     pkey_val = 4.75
     data_val = -1.5
diff --git a/tests/integration/cqlengine/model/test_model_io.py b/tests/integration/cqlengine/model/test_model_io.py
@@ -156,7 +156,7 @@ class AllDatatypesModel(Model):
             e = columns.DateTime()
             f = columns.Decimal()
             g = columns.Double()
-            h = columns.Float(double_precision=False)
+            h = columns.Float()
             i = columns.Inet()
             j = columns.Integer()
             k = columns.Text()
@@ -225,13 +225,8 @@ def test_can_insert_double_and_float(self):
         """
         Test for inserting single-precision and double-precision values into a Float and Double columns
 
-        test_can_insert_double_and_float tests a Float can only hold a single-precision value, unless
-        "double_precision" attribute is specified as True or is unspecified. This test first tests that an AttributeError
-        is raised when attempting to input a double-precision value into a single-precision Float. It then verifies that
-        Double, Float(double_precision=True) and Float() can hold double-precision values by default. It also verifies that
-        columns.Float(double_precision=False) can hold a single-precision value, and a Double can hold a single-precision value.
-
         @since 2.6.0
+        @changed 3.0.0 removed deprecated Float(double_precision) parameter
         @jira_ticket PYTHON-246
         @expected_result Each floating point column type is able to hold their respective precision values.
 
@@ -240,24 +235,19 @@ def test_can_insert_double_and_float(self):
 
         class FloatingPointModel(Model):
             id = columns.Integer(primary_key=True)
-            a = columns.Float(double_precision=False)
-            b = columns.Float(double_precision=True)
-            c = columns.Float()
+            f = columns.Float()
             d = columns.Double()
 
         sync_table(FloatingPointModel)
 
-        FloatingPointModel.create(id=0, a=2.39)
+        FloatingPointModel.create(id=0, f=2.39)
         output = FloatingPointModel.objects().first()
-        self.assertEqual(2.390000104904175, output.a)
+        self.assertEqual(2.390000104904175, output.f)  # float loses precision
 
-        FloatingPointModel.create(id=0, a=3.4028234663852886e+38, b=2.39, c=2.39, d=2.39)
+        FloatingPointModel.create(id=0, f=3.4028234663852886e+38, d=2.39)
         output = FloatingPointModel.objects().first()
-
-        self.assertEqual(3.4028234663852886e+38, output.a)
-        self.assertEqual(2.39, output.b)
-        self.assertEqual(2.39, output.c)
-        self.assertEqual(2.39, output.d)
+        self.assertEqual(3.4028234663852886e+38, output.f)
+        self.assertEqual(2.39, output.d)  # double retains precision
 
         FloatingPointModel.create(id=0, d=3.4028234663852886e+38)
         output = FloatingPointModel.objects().first()
diff --git a/tests/integration/cqlengine/model/test_udts.py b/tests/integration/cqlengine/model/test_udts.py
@@ -214,7 +214,7 @@ class AllDatatypes(UserType):
             e = columns.DateTime()
             f = columns.Decimal()
             g = columns.Double()
-            h = columns.Float(double_precision=False)
+            h = columns.Float()
             i = columns.Inet()
             j = columns.Integer()
             k = columns.Text()
@@ -261,7 +261,7 @@ class AllDatatypes(UserType):
             e = columns.DateTime()
             f = columns.Decimal()
             g = columns.Double()
-            h = columns.Float(double_precision=False)
+            h = columns.Float()
             i = columns.Inet()
             j = columns.Integer()
             k = columns.Text()
