From 3a77208bb3556da034e00882c80a965a7efc2b2a Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Wed, 2 Apr 2025 18:44:53 -0400 Subject: [PATCH 01/15] actually fix required skipped CI jobs --- .github/workflows/ci.yml | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index adca99d..8c1ef59 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,21 +1,26 @@ name: Test on: pull_request: - paths-ignore: "*.rst" push: - # paths-ignore: "*.rst" branches: [master, develop] concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true jobs: - pre-commit: + check-paths: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - - run: pipx run pre-commit run --all-files + - uses: dorny/paths-filter@v3 + id: changes + with: + filters: | + nondoc: + - '!**/*.rst' + - run: echo 'changed={{ steps.changes.outputs.nondoc }}' > "$GITHUB_OUTPUT" build-test: + needs: check-paths + if: needs.check-paths.outputs.changed == 'true' runs-on: ${{ matrix.os }} strategy: fail-fast: false @@ -41,3 +46,9 @@ jobs: python -m pip install --editable .[dev] - name: Test with tox run: tox -e py + + pass: + needs: build-test + if: | + needs.build-test.result == 'success' && needs.build-test.result == 'skipped' + runs-on: ubuntu-latest From f08123041ae7b7ca9fb9f5aebc2a6c6a3e96a63a Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Wed, 2 Apr 2025 18:47:12 -0400 Subject: [PATCH 02/15] actually run stuff --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8c1ef59..6ec4488 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -52,3 +52,6 @@ jobs: if: | needs.build-test.result == 'success' && needs.build-test.result == 'skipped' runs-on: ubuntu-latest + steps: + - name: Curiosity + run: echo "$GITHUB_OUTPUT" From f1b2fb4094baffa0dcb9eeff6b4b65aa4c34aa5e Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Wed, 2 Apr 2025 18:49:50 -0400 Subject: [PATCH 03/15] checks out --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6ec4488..1a1ba79 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,6 +10,7 @@ jobs: check-paths: runs-on: ubuntu-latest steps: + - uses: actions/checkout@4 - uses: dorny/paths-filter@v3 id: changes with: From a2d6fc2aa3eda89eada821732c5a2db950c272f8 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Wed, 2 Apr 2025 18:51:03 -0400 Subject: [PATCH 04/15] bruh --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1a1ba79..8ca809c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,7 +10,9 @@ jobs: check-paths: runs-on: ubuntu-latest steps: - - uses: actions/checkout@4 + - uses: actions/checkout@v4 + with: + fetch-depth: 0 - uses: dorny/paths-filter@v3 id: changes with: From bf44fc2c7af77044a9562bdabbf22abfd53d3b15 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Wed, 2 Apr 2025 18:56:13 -0400 Subject: [PATCH 05/15] bruhh --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8ca809c..bb1ac71 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: filters: | nondoc: - '!**/*.rst' - - run: echo 'changed={{ steps.changes.outputs.nondoc }}' > "$GITHUB_OUTPUT" + - run: echo 'changed=${{ steps.changes.outputs.nondoc }}' > "$GITHUB_OUTPUT" build-test: needs: check-paths From 3ef6e365b8a6b354e0186f2e6cc937dd1ab5f305 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Wed, 2 Apr 2025 18:58:06 -0400 Subject: [PATCH 06/15] dewey have to append? --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bb1ac71..3ecfeed 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: filters: | nondoc: - '!**/*.rst' - - run: echo 'changed=${{ steps.changes.outputs.nondoc }}' > "$GITHUB_OUTPUT" + - run: echo 'changed=${{ steps.changes.outputs.nondoc }}' >> "$GITHUB_OUTPUT" build-test: needs: check-paths @@ -57,4 +57,6 @@ jobs: runs-on: ubuntu-latest steps: - name: Curiosity - run: echo "$GITHUB_OUTPUT" + run: | + echo "$GITHUB_OUTPUT" + cat "$GITHUB_OUTPUT" From 3cfdd17ba6633dc1507ec4fde806ad37a47a85bb Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sat, 5 Apr 2025 19:11:00 -0400 Subject: [PATCH 07/15] fix outputs --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3ecfeed..5c1f11d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,6 +20,9 @@ jobs: nondoc: - '!**/*.rst' - run: echo 'changed=${{ steps.changes.outputs.nondoc }}' >> "$GITHUB_OUTPUT" + id: changed + outputs: + changed: ${{ steps.changed.outputs.changed }} build-test: needs: check-paths From 29a1b49f46d161d665eddeb45db77cfd7818dc7a Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sat, 5 Apr 2025 19:20:17 -0400 Subject: [PATCH 08/15] fix condition --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5c1f11d..714bdc3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -55,8 +55,7 @@ jobs: pass: needs: build-test - if: | - needs.build-test.result == 'success' && needs.build-test.result == 'skipped' + if: needs.build-test.result == 'success' || needs.build-test.result == 'skipped' runs-on: ubuntu-latest steps: - name: Curiosity From fc2a802a5a6760ecf90bedc2ee6b3211c0c7d66d Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sat, 5 Apr 2025 19:24:30 -0400 Subject: [PATCH 09/15] always() is the only one that works smh --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 714bdc3..21b2fce 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -55,9 +55,12 @@ jobs: pass: needs: build-test - if: needs.build-test.result == 'success' || needs.build-test.result == 'skipped' + if: always() runs-on: ubuntu-latest steps: + - name: fail if build-test ran and failed + if: ${{ needs.build-test.result == 'failure' }} + run: exit 1 - name: Curiosity run: | echo "$GITHUB_OUTPUT" From e056094c923a4cecde2fa4cd053a189d758f57d5 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sat, 5 Apr 2025 19:45:14 -0400 Subject: [PATCH 10/15] dummy commits to trigger workflows again --- .style.yapf | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .style.yapf diff --git a/.style.yapf b/.style.yapf deleted file mode 100644 index 274a4e0..0000000 --- a/.style.yapf +++ /dev/null @@ -1,5 +0,0 @@ -[style] -based_on_style = chromium -dedent_closing_brackets = True -coalesce_brackets = True -continuation_indent_width = 2 From 19617ef21ee88a4d10021d207f802a71974b60a4 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sat, 5 Apr 2025 19:45:30 -0400 Subject: [PATCH 11/15] look i don't know why we can't just re-run a filtered workflow either This reverts commit e056094c923a4cecde2fa4cd053a189d758f57d5. --- .style.yapf | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .style.yapf diff --git a/.style.yapf b/.style.yapf new file mode 100644 index 0000000..274a4e0 --- /dev/null +++ b/.style.yapf @@ -0,0 +1,5 @@ +[style] +based_on_style = chromium +dedent_closing_brackets = True +coalesce_brackets = True +continuation_indent_width = 2 From b62390d745a35df41e807626a0ea606af2127cc6 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sat, 5 Apr 2025 19:48:48 -0400 Subject: [PATCH 12/15] you can't be serious This reverts commit 19617ef21ee88a4d10021d207f802a71974b60a4. --- .style.yapf | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .style.yapf diff --git a/.style.yapf b/.style.yapf deleted file mode 100644 index 274a4e0..0000000 --- a/.style.yapf +++ /dev/null @@ -1,5 +0,0 @@ -[style] -based_on_style = chromium -dedent_closing_brackets = True -coalesce_brackets = True -continuation_indent_width = 2 From d5e7903109fe48f75c15861e5ce236b267e29085 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sat, 5 Apr 2025 19:48:58 -0400 Subject: [PATCH 13/15] i had to do that again?? This reverts commit b62390d745a35df41e807626a0ea606af2127cc6. --- .style.yapf | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .style.yapf diff --git a/.style.yapf b/.style.yapf new file mode 100644 index 0000000..274a4e0 --- /dev/null +++ b/.style.yapf @@ -0,0 +1,5 @@ +[style] +based_on_style = chromium +dedent_closing_brackets = True +coalesce_brackets = True +continuation_indent_width = 2 From 97048b5a8dbadd4cd2d745098015a5b730ebf4f5 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Mon, 7 Apr 2025 19:10:05 -0400 Subject: [PATCH 14/15] pin unverified action to commit --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 21b2fce..c9d9170 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 - - uses: dorny/paths-filter@v3 + - uses: dorny/paths-filter@de90cc6 id: changes with: filters: | From 360e9a79bef6066f008a94f58d5f252e1d315ec5 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Mon, 7 Apr 2025 19:12:57 -0400 Subject: [PATCH 15/15] full hash needed --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c9d9170..396fe8d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 - - uses: dorny/paths-filter@de90cc6 + - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 id: changes with: filters: |