From 196d6a36dba76f3c1ace0728ac6335898ea08784 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sun, 16 Mar 2025 17:00:41 -0400 Subject: [PATCH 1/3] misc git cleanup Remove my pathetic attempt at a debug print from unit tests Ignore reformatting commit from git blame gitignore pycharm and uv.lock --- .git-blame-ignore-revs | 3 +++ .gitignore | 4 ++++ cpplint_unittest.py | 1 - 3 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .git-blame-ignore-revs diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs new file mode 100644 index 0000000..9a63ffd --- /dev/null +++ b/.git-blame-ignore-revs @@ -0,0 +1,3 @@ +# .git-blame-ignore-revs +# Reformatted repo with ruff +94f5e443bfa80e576ded32585f0058d09a6a7fbc diff --git a/.gitignore b/.gitignore index 712f99b..f8b1e61 100644 --- a/.gitignore +++ b/.gitignore @@ -81,6 +81,9 @@ ipython_config.py # VSCode .vscode/ +# JetBrains PyCharm +.idea/ + # pyenv .python-version @@ -98,6 +101,7 @@ venv/ ENV/ env.bak/ venv.bak/ +uv.lock # Spyder project settings .spyderproject diff --git a/cpplint_unittest.py b/cpplint_unittest.py index 66751a3..318df16 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -7184,7 +7184,6 @@ def run_around_tests(pytestconfig: pytest.Config): assert pytestconfig.getoption("-k", default=None) in [None, ""] if pytestconfig.getoption("-k", default=None) in [None, ""]: ErrorCollector(None).VerifyAllCategoriesAreSeen() - print("IIIIIIIIII saw the TV glow") if __name__ == "__main__": From ad46fdbfa04d0db9d2424050babe75826b32fd32 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sun, 16 Mar 2025 17:04:37 -0400 Subject: [PATCH 2/3] ditto evidently i was not feeling well --- cpplint_unittest.py | 1 - 1 file changed, 1 deletion(-) diff --git a/cpplint_unittest.py b/cpplint_unittest.py index 318df16..d506e8c 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -7181,7 +7181,6 @@ def run_around_tests(pytestconfig: pytest.Config): # obviously we're not going to see all the error categories. So we # only run VerifyAllCategoriesAreSeen() when we don't filter for # specific tests. - assert pytestconfig.getoption("-k", default=None) in [None, ""] if pytestconfig.getoption("-k", default=None) in [None, ""]: ErrorCollector(None).VerifyAllCategoriesAreSeen() From c3da1e030a2553b9c4472f7d69827f936853b6c5 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 17 Mar 2025 00:27:39 +0100 Subject: [PATCH 3/3] Apply suggestions from code review --- .gitignore | 1 - cpplint_unittest.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index f8b1e61..7098c5b 100644 --- a/.gitignore +++ b/.gitignore @@ -101,7 +101,6 @@ venv/ ENV/ env.bak/ venv.bak/ -uv.lock # Spyder project settings .spyderproject diff --git a/cpplint_unittest.py b/cpplint_unittest.py index d506e8c..c407fb6 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -7181,7 +7181,7 @@ def run_around_tests(pytestconfig: pytest.Config): # obviously we're not going to see all the error categories. So we # only run VerifyAllCategoriesAreSeen() when we don't filter for # specific tests. - if pytestconfig.getoption("-k", default=None) in [None, ""]: + if pytestconfig.getoption("-k", default=None) in {None, ""}: ErrorCollector(None).VerifyAllCategoriesAreSeen()