diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 4dfac75..bd67068 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -2,6 +2,13 @@ Changelog ********* +2.0.1 (2025-01-??) +================== + +Yet another overdue... hotfix. Sorry this took so long. + +* The false positive for indented function parameters in namespaces was eradicated. + 2.0 (2024-10-06) ================ diff --git a/cpplint.py b/cpplint.py index 79a16f2..7e8470a 100755 --- a/cpplint.py +++ b/cpplint.py @@ -3035,6 +3035,11 @@ def __init__(self): # the full nesting stack would slow down cpplint by ~10%. self.previous_stack_top = [] + # The number of open parentheses in the previous stack top before the last update. + # Used to prevent false indentation detection when e.g. a function parameter is indented. + # We can't use previous_stack_top, a shallow copy whose open_parentheses value is updated. + self.previous_open_parentheses = 0 + # Stack of _PreprocessorInfo objects. self.pp_stack = [] @@ -3206,6 +3211,7 @@ def Update(self, filename, clean_lines, linenum, error): # deepcopy would slow down cpplint by ~28%. if self.stack: self.previous_stack_top = self.stack[-1] + self.previous_open_parentheses = self.stack[-1].open_parentheses else: self.previous_stack_top = None @@ -6372,7 +6378,7 @@ def IsBlockInNameSpace(nesting_state, is_forward_declaration): return False -def ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item, +def ShouldCheckNamespaceIndentation(nesting_state: NestingState, is_namespace_indent_item, raw_lines_no_comments, linenum): """This method determines if we should apply our namespace indentation check. @@ -6399,6 +6405,10 @@ def ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item, if IsMacroDefinition(raw_lines_no_comments, linenum): return False + # Skip if we are inside an open parenthesis block (e.g. function parameters). + if nesting_state.previous_stack_top and nesting_state.previous_open_parentheses > 0: + return False + return IsBlockInNameSpace(nesting_state, is_forward_declaration) diff --git a/cpplint_unittest.py b/cpplint_unittest.py index c20384c..d5f126d 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -309,9 +309,10 @@ def testNamespaceIndentationForClass(self): 'Do not indent within a namespace. ' ' [whitespace/indent_namespace] [4]']) - def testNamespaceIndentationNoError(self): + def testNamespaceIndentationIndentedParameter(self): lines = ['namespace Test {', - 'void foo() { }', + 'void foo(' + ' SuperLongTypeName d = 418) { }', '} // namespace Test'] results = self.GetNamespaceResults(lines) diff --git a/samples/boost-sample/exclude.def b/samples/boost-sample/exclude.def index e9fef89..731ffad 100644 --- a/samples/boost-sample/exclude.def +++ b/samples/boost-sample/exclude.def @@ -3,15 +3,13 @@ 4 Done processing src/inspect/unnamed_namespace_check.hpp Done processing src/tr1/c_policy.hpp -Total errors found: 126 +Total errors found: 121 src/inspect/unnamed_namespace_check.hpp:0: No #ifndef header guard found, suggested CPP variable is: SAMPLES_BOOST_SAMPLE_SRC_INSPECT_UNNAMED_NAMESPACE_CHECK_HPP_ [build/header_guard] [5] src/inspect/unnamed_namespace_check.hpp:11: Include the directory when naming header files [build/include_subdir] [4] src/inspect/unnamed_namespace_check.hpp:14: Do not use unnamed namespaces in header files. See https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces for more information. [build/namespaces_headers] [4] src/inspect/unnamed_namespace_check.hpp:17: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/inspect/unnamed_namespace_check.hpp:18: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:18: At least two spaces is best between code and comments [whitespace/comments] [2] -src/inspect/unnamed_namespace_check.hpp:19: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:19: Closing ) should be moved to the previous line [whitespace/parens] [2] src/inspect/unnamed_namespace_check.hpp:21: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] src/inspect/unnamed_namespace_check.hpp:21: At least two spaces is best between code and comments [whitespace/comments] [2] @@ -44,9 +42,6 @@ src/inspect/unnamed_namespace_check.hpp:38: Do not indent within a namespace. src/inspect/unnamed_namespace_check.hpp:38: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/inspect/unnamed_namespace_check.hpp:40: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:40: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] -src/inspect/unnamed_namespace_check.hpp:41: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/inspect/unnamed_namespace_check.hpp:42: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/inspect/unnamed_namespace_check.hpp:43: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:44: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:44: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:48: Lines should be <= 80 characters long [whitespace/line_length] [2] diff --git a/samples/boost-sample/headers_inspect.def b/samples/boost-sample/headers_inspect.def index 6c61efc..3c1d647 100644 --- a/samples/boost-sample/headers_inspect.def +++ b/samples/boost-sample/headers_inspect.def @@ -2,15 +2,13 @@ src/inspect/* 1 3 Done processing src/inspect/unnamed_namespace_check.hpp -Total errors found: 55 +Total errors found: 50 src/inspect/unnamed_namespace_check.hpp:0: No #ifndef header guard found, suggested CPP variable is: SAMPLES_BOOST_SAMPLE_SRC_INSPECT_UNNAMED_NAMESPACE_CHECK_HPP_ [build/header_guard] [5] src/inspect/unnamed_namespace_check.hpp:11: Include the directory when naming header files [build/include_subdir] [4] src/inspect/unnamed_namespace_check.hpp:14: Do not use unnamed namespaces in header files. See https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces for more information. [build/namespaces_headers] [4] src/inspect/unnamed_namespace_check.hpp:17: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/inspect/unnamed_namespace_check.hpp:18: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:18: At least two spaces is best between code and comments [whitespace/comments] [2] -src/inspect/unnamed_namespace_check.hpp:19: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:19: Closing ) should be moved to the previous line [whitespace/parens] [2] src/inspect/unnamed_namespace_check.hpp:21: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] src/inspect/unnamed_namespace_check.hpp:21: At least two spaces is best between code and comments [whitespace/comments] [2] @@ -43,9 +41,6 @@ src/inspect/unnamed_namespace_check.hpp:38: Do not indent within a namespace. src/inspect/unnamed_namespace_check.hpp:38: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/inspect/unnamed_namespace_check.hpp:40: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:40: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] -src/inspect/unnamed_namespace_check.hpp:41: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/inspect/unnamed_namespace_check.hpp:42: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/inspect/unnamed_namespace_check.hpp:43: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:44: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:44: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:48: Lines should be <= 80 characters long [whitespace/line_length] [2] diff --git a/samples/boost-sample/simple.def b/samples/boost-sample/simple.def index 823013c..229b367 100644 --- a/samples/boost-sample/simple.def +++ b/samples/boost-sample/simple.def @@ -2,7 +2,7 @@ include/boost/math/* 1 3 Done processing include/boost/math/octonion.hpp -Total errors found: 2924 +Total errors found: 2900 include/boost/math/octonion.hpp:11: #ifndef header guard has wrong style, please use: SAMPLES_BOOST_SAMPLE_INCLUDE_BOOST_MATH_OCTONION_HPP_ [build/header_guard] [5] include/boost/math/octonion.hpp:4250: #endif line should be "#endif // SAMPLES_BOOST_SAMPLE_INCLUDE_BOOST_MATH_OCTONION_HPP_" [build/header_guard] [5] @@ -1167,7 +1167,6 @@ include/boost/math/octonion.hpp:1711: Do not indent within a namespace. [white include/boost/math/octonion.hpp:1711: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1711: Missing space after , [whitespace/comma] [3] include/boost/math/octonion.hpp:1711: Extra space after ( [whitespace/parens] [2] -include/boost/math/octonion.hpp:1712: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1713: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1713: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1716: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -2616,7 +2615,6 @@ include/boost/math/octonion.hpp:3856: Do not indent within a namespace. [white include/boost/math/octonion.hpp:3856: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:3856: Missing space after , [whitespace/comma] [3] include/boost/math/octonion.hpp:3856: Extra space after ( [whitespace/parens] [2] -include/boost/math/octonion.hpp:3857: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3857: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:3858: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3858: { should almost always be at the end of the previous line [whitespace/braces] [4] @@ -2728,13 +2726,6 @@ include/boost/math/octonion.hpp:3999: Do not indent within a namespace. [white include/boost/math/octonion.hpp:3999: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4000: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4001: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4002: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4003: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4004: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4005: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4006: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4007: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4008: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4009: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4009: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4012: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -2772,13 +2763,6 @@ include/boost/math/octonion.hpp:4054: Do not indent within a namespace. [white include/boost/math/octonion.hpp:4054: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4055: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4056: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4057: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4058: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4059: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4060: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4061: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4062: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4063: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4064: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4064: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4067: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -2791,13 +2775,6 @@ include/boost/math/octonion.hpp:4080: Do not indent within a namespace. [white include/boost/math/octonion.hpp:4080: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4081: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4082: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4083: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4084: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4085: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4086: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4087: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4088: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4089: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4090: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4090: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4093: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -2886,7 +2863,6 @@ include/boost/math/octonion.hpp:4192: Do not indent within a namespace. [white include/boost/math/octonion.hpp:4192: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4193: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4194: Do not indent within a namespace. [whitespace/indent_namespace] [4] -include/boost/math/octonion.hpp:4195: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4196: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4196: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4198: { should almost always be at the end of the previous line [whitespace/braces] [4] diff --git a/samples/chromium-sample/simple.def b/samples/chromium-sample/simple.def index 1e68efd..a5c6c5c 100644 --- a/samples/chromium-sample/simple.def +++ b/samples/chromium-sample/simple.def @@ -5,12 +5,9 @@ Done processing src/chrome_content_renderer_client.cc Done processing src/chrome_content_renderer_client.h Done processing src/io_thread.cc Done processing src/io_thread.h -Total errors found: 25 +Total errors found: 18 src/chrome_content_renderer_client.cc:303: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/chrome_content_renderer_client.cc:308: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/chrome_content_renderer_client.cc:309: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/chrome_content_renderer_client.cc:310: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/chrome_content_renderer_client.cc:308: Add #include for vector<> [build/include_what_you_use] [4] src/chrome_content_renderer_client.cc:1540: Add #include for set<> [build/include_what_you_use] [4] src/chrome_content_renderer_client.cc:1841: Add #include for string [build/include_what_you_use] [4] @@ -19,10 +16,6 @@ src/chrome_content_renderer_client.h:5: #ifndef header guard has wrong style, p src/chrome_content_renderer_client.h:225: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_" [build/header_guard] [5] src/chrome_content_renderer_client.h:115: Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4] src/chrome_content_renderer_client.h:117: Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4] -src/io_thread.cc:242: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/io_thread.cc:286: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/io_thread.cc:298: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/io_thread.cc:299: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/io_thread.cc:1148: Closing ) should be moved to the previous line [whitespace/parens] [2] src/io_thread.cc:1547: Missing space around colon in range-based for loop [whitespace/forcolon] [2] src/io_thread.cc:651: Add #include for map<> [build/include_what_you_use] [4] diff --git a/samples/protobuf-sample/simple.def b/samples/protobuf-sample/simple.def index a01d2b0..963eaba 100644 --- a/samples/protobuf-sample/simple.def +++ b/samples/protobuf-sample/simple.def @@ -4,7 +4,7 @@ src/* Done processing src/descriptor.pb.cc Done processing src/descriptor.pb.h Done processing src/descriptor_unittest.cc -Total errors found: 3212 +Total errors found: 3111 src/descriptor.pb.cc:0: No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5] src/descriptor.pb.cc:9: Found C system header after C++ system header. Should be: descriptor.pb.h, c system, c++ system, other. [build/include_order] [4] @@ -266,12 +266,9 @@ src/descriptor.pb.cc:900: Do not indent within a namespace. [whitespace/indent src/descriptor.pb.cc:917: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:932: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:938: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:956: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:961: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:964: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:970: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:1004: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor.pb.cc:1020: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1030: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1063: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:1064: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -297,7 +294,6 @@ src/descriptor.pb.cc:1249: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:1252: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1260: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1263: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:1280: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1285: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1288: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1347: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -314,8 +310,6 @@ src/descriptor.pb.cc:1455: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:1456: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1459: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1460: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:1510: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor.pb.cc:1608: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1708: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1733: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] src/descriptor.pb.cc:1756: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] @@ -479,16 +473,13 @@ src/descriptor.pb.cc:2482: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:2484: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2502: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:2506: Missing space after , [whitespace/comma] [3] -src/descriptor.pb.cc:2522: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2527: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2530: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2535: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2550: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:2583: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2587: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2592: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2602: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:2603: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2607: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2612: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2616: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -515,16 +506,13 @@ src/descriptor.pb.cc:2781: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:2783: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2801: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:2805: Missing space after , [whitespace/comma] [3] -src/descriptor.pb.cc:2821: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2826: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2829: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2834: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2849: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:2882: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2886: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2891: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2901: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:2902: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2906: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2911: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2915: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -547,7 +535,6 @@ src/descriptor.pb.cc:3071: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:3088: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3106: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3109: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:3127: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3132: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3135: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3158: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -560,9 +547,7 @@ src/descriptor.pb.cc:3237: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:3252: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3263: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3268: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:3321: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3351: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:3399: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3433: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3479: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3504: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] @@ -693,7 +678,6 @@ src/descriptor.pb.cc:4322: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:4325: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4328: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4334: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:4347: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4352: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4355: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4394: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -703,11 +687,9 @@ src/descriptor.pb.cc:4430: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:4433: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4482: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4496: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:4546: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4570: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4613: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4633: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:4634: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4660: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4706: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4721: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -862,12 +844,9 @@ src/descriptor.pb.cc:5381: If statement had no body and no else clause [whites src/descriptor.pb.cc:5396: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5402: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5413: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:5422: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5427: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5430: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:5470: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5489: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:5490: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5504: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5536: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:5537: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -903,13 +882,10 @@ src/descriptor.pb.cc:5699: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:5716: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5722: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5734: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:5748: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5753: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5756: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5779: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5794: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:5826: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor.pb.cc:5858: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5886: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5911: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] src/descriptor.pb.cc:5935: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -955,15 +931,12 @@ src/descriptor.pb.cc:6200: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:6206: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6218: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6222: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:6232: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6237: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6240: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6262: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6276: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:6308: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6322: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6338: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:6339: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6354: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6365: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6397: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] @@ -1014,14 +987,11 @@ src/descriptor.pb.cc:6672: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:6678: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6690: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6693: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:6704: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6709: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6712: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6735: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6750: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:6782: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6813: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:6814: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6842: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6867: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] src/descriptor.pb.cc:6888: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1077,17 +1047,14 @@ src/descriptor.pb.cc:7199: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:7202: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7205: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7208: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:7222: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7227: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7230: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7285: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7299: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7314: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:7347: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7387: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7392: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7402: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:7403: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7447: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7452: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7456: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1200,7 +1167,6 @@ src/descriptor.pb.cc:8014: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:8018: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8024: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8027: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:8042: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8047: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8050: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8074: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1218,7 +1184,6 @@ src/descriptor.pb.cc:8231: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:8248: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8275: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8281: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:8320: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8335: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8342: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8350: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1229,7 +1194,6 @@ src/descriptor.pb.cc:8380: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:8385: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8390: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8395: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:8436: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8452: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8460: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8468: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1419,7 +1383,6 @@ src/descriptor.pb.cc:9363: If statement had no body and no else clause [whites src/descriptor.pb.cc:9378: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9403: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:9407: Missing space after , [whitespace/comma] [3] -src/descriptor.pb.cc:9424: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9429: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9432: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9437: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1428,12 +1391,10 @@ src/descriptor.pb.cc:9467: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:9482: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9492: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9498: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:9537: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9541: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9546: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9551: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9556: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:9577: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9581: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9586: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9591: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1476,7 +1437,6 @@ src/descriptor.pb.cc:9972: If statement had no body and no else clause [whites src/descriptor.pb.cc:9987: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10012: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:10016: Missing space after , [whitespace/comma] [3] -src/descriptor.pb.cc:10036: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10041: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10044: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10045: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1491,13 +1451,11 @@ src/descriptor.pb.cc:10118: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:10134: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10144: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10150: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:10189: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10199: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10204: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10209: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10212: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10220: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:10241: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10251: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10256: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10261: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1547,17 +1505,14 @@ src/descriptor.pb.cc:10664: If statement had no body and no else clause [white src/descriptor.pb.cc:10679: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10704: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:10708: Missing space after , [whitespace/comma] [3] -src/descriptor.pb.cc:10725: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10730: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10733: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10738: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10753: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10763: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10769: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:10808: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10812: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10817: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:10838: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10842: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10847: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10862: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1584,15 +1539,12 @@ src/descriptor.pb.cc:11083: Do not indent within a namespace. [whitespace/inde src/descriptor.pb.cc:11101: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:11116: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11122: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11142: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11147: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11150: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11155: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11165: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11171: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11210: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11214: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11235: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11239: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11254: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11294: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -1613,15 +1565,12 @@ src/descriptor.pb.cc:11439: Do not indent within a namespace. [whitespace/inde src/descriptor.pb.cc:11440: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11458: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:11473: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11499: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11504: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11507: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11512: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11522: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11528: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11567: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11571: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11592: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11596: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11611: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11651: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -1642,15 +1591,12 @@ src/descriptor.pb.cc:11796: Do not indent within a namespace. [whitespace/inde src/descriptor.pb.cc:11797: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11815: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:11830: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11856: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11861: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11864: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11869: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11879: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11885: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11924: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11928: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:11949: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11953: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11968: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12008: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -1678,14 +1624,11 @@ src/descriptor.pb.cc:12190: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:12194: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12196: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12208: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:12219: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12224: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12227: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12249: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:12282: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12296: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12306: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:12307: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12322: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12326: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12355: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1714,18 +1657,15 @@ src/descriptor.pb.cc:12544: Missing space after , [whitespace/comma] [3] src/descriptor.pb.cc:12551: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12554: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12557: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:12572: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12577: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12580: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12586: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12619: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12634: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12649: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:12712: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12732: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12737: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12742: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:12769: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12791: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12796: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12801: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1868,7 +1808,6 @@ src/descriptor.pb.cc:13396: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:13402: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13414: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13417: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:13430: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13435: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13438: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13442: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1883,12 +1822,10 @@ src/descriptor.pb.cc:13498: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:13515: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13516: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13518: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:13550: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13554: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13564: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13595: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13609: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:13610: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13665: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13673: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13698: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] @@ -1905,12 +1842,9 @@ src/descriptor.pb.cc:13847: Do not indent within a namespace. [whitespace/inde src/descriptor.pb.cc:13848: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13865: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:13880: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:13904: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13909: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13912: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13918: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:13952: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor.pb.cc:13968: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13978: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14011: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:14012: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -2037,7 +1971,6 @@ src/descriptor.pb.cc:14395: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:14413: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:14417: Missing space after , [whitespace/comma] [3] src/descriptor.pb.cc:14424: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:14439: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14444: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14447: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14451: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -2046,12 +1979,10 @@ src/descriptor.pb.cc:14455: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:14456: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14487: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14502: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:14535: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14539: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14559: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14564: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14574: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:14575: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14604: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14609: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14613: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -2071,12 +2002,9 @@ src/descriptor.pb.cc:14770: Do not indent within a namespace. [whitespace/inde src/descriptor.pb.cc:14787: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:14802: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14808: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:14826: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14831: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14834: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14840: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.cc:14874: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor.pb.cc:14890: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14900: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14933: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:14934: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -2143,31 +2071,26 @@ src/descriptor.pb.h:88: Lines should be <= 80 characters long [whitespace/line src/descriptor.pb.h:89: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:91: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:92: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.h:97: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:98: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:107: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:108: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:109: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:111: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:112: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.h:117: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:118: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:127: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:128: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:129: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:131: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:132: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.h:137: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:147: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:148: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:151: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.h:157: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:167: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:168: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:169: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:171: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:172: Lines should be <= 80 characters long [whitespace/line_length] [2] -src/descriptor.pb.h:177: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:183: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:225: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:227: private: should be indented +1 space inside class FileDescriptorSet [whitespace/indent] [3] @@ -2984,25 +2907,6 @@ src/descriptor_unittest.cc:57: "google/protobuf/stubs/logging.h" already includ src/descriptor_unittest.cc:58: Found C system header after C++ system header. Should be: descriptor_unittest.h, c system, c++ system, other. [build/include_order] [4] src/descriptor_unittest.cc:59: Found C system header after C++ system header. Should be: descriptor_unittest.h, c system, c++ system, other. [build/include_order] [4] src/descriptor_unittest.cc:60: Found C system header after C++ system header. Should be: descriptor_unittest.h, c system, c++ system, other. [build/include_order] [4] -src/descriptor_unittest.cc:88: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:95: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:102: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:103: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:104: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:114: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:115: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:116: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:117: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:128: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:129: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:130: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:131: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:142: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:150: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:158: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:166: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:167: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:168: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:734: Extra space before ) [whitespace/parens] [2] src/descriptor_unittest.cc:735: Extra space before ) [whitespace/parens] [2] src/descriptor_unittest.cc:822: Extra space after ( in function call [whitespace/parens] [4] @@ -3165,13 +3069,9 @@ src/descriptor_unittest.cc:2325: Extra space before ( in function call [whites src/descriptor_unittest.cc:2327: Extra space after ( in function call [whitespace/parens] [4] src/descriptor_unittest.cc:2327: Extra space before ( in function call [whitespace/parens] [4] src/descriptor_unittest.cc:2383: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] -src/descriptor_unittest.cc:2627: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:2698: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:2699: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:2781: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor_unittest.cc:3038: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor_unittest.cc:3120: Missing space after , [whitespace/comma] [3] -src/descriptor_unittest.cc:4183: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:4475: Closing ) should be moved to the previous line [whitespace/parens] [2] src/descriptor_unittest.cc:4489: Closing ) should be moved to the previous line [whitespace/parens] [2] src/descriptor_unittest.cc:4502: Closing ) should be moved to the previous line [whitespace/parens] [2] @@ -3184,7 +3084,6 @@ src/descriptor_unittest.cc:5273: Do not indent within a namespace. [whitespace src/descriptor_unittest.cc:5274: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:5276: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:5277: Do not indent within a namespace. [whitespace/indent_namespace] [4] -src/descriptor_unittest.cc:5856: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:5929: Single-parameter constructors should be marked explicit. [runtime/explicit] [4] src/descriptor_unittest.cc:5968: Single-parameter constructors should be marked explicit. [runtime/explicit] [4] src/descriptor_unittest.cc:6401: Do not indent within a namespace. [whitespace/indent_namespace] [4]