From 3e97a85f65b3d29541eb6f7037ac91980c079cbc Mon Sep 17 00:00:00 2001 From: Yujin <78896558+Yujinmon@users.noreply.github.com> Date: Tue, 21 Nov 2023 23:44:57 +0900 Subject: [PATCH 01/11] changed false positive for namespace indentation error changed return in IsBlockInNameSpace function --- cpplint.py | 76 ++++++++++++++++++++++++++++++------------------------ 1 file changed, 43 insertions(+), 33 deletions(-) diff --git a/cpplint.py b/cpplint.py index 8158eb7..34b4582 100755 --- a/cpplint.py +++ b/cpplint.py @@ -98,10 +98,9 @@ certain of the problem, and 1 meaning it could be a legitimate construct. This will miss some errors, and is not a substitute for a code review. - To suppress false-positive errors of certain categories, add a - 'NOLINT(category[, category...])' comment to the line. NOLINT or NOLINT(*) - suppresses errors of all categories on that line. To suppress categories - on the next line use NOLINTNEXTLINE instead of NOLINT. + To suppress false-positive errors of a certain category, add a + 'NOLINT(category)' comment to the line. NOLINT or NOLINT(*) + suppresses errors of all categories on that line. The files passed in will be linted; at least one file must be provided. Default linted extensions are %s. @@ -409,7 +408,7 @@ 'alloc.h', 'builtinbuf.h', 'bvector.h', - # 'complex.h', collides with System C header "complex.h" + 'complex.h', 'defalloc.h', 'deque.h', 'editbuf.h', @@ -521,22 +520,6 @@ 'optional', 'string_view', 'variant', - # 17.6.1.2 C++20 headers - 'barrier', - 'bit', - 'compare', - 'concepts', - 'coroutine', - 'format', - 'latch' - 'numbers', - 'ranges', - 'semaphore', - 'source_location', - 'span', - 'stop_token', - 'syncstream', - 'version', # 17.6.1.2 C++ headers for C library facilities 'cassert', 'ccomplex', @@ -1002,11 +985,12 @@ def ParseNolintSuppressions(filename, raw_line, linenum, error): suppressed_line = linenum + 1 else: suppressed_line = linenum - categories = matched.group(2) - if categories in (None, '(*)'): # => "suppress all" + category = matched.group(2) + if category in (None, '(*)'): # => "suppress all" _error_suppressions.setdefault(None, set()).add(suppressed_line) - elif categories.startswith('(') and categories.endswith(')'): - for category in set(map(lambda c: c.strip(), categories[1:-1].split(','))): + else: + if category.startswith('(') and category.endswith(')'): + category = category[1:-1] if category in _ERROR_CATEGORIES: _error_suppressions.setdefault(category, set()).add(suppressed_line) elif any(c for c in _OTHER_NOLINT_CATEGORY_PREFIXES if category.startswith(c)): @@ -3561,11 +3545,27 @@ def IsBlankLine(line): def CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line, error): + # Plain Source Code + # is_namespace_indent_item = ( + # len(nesting_state.stack) > 1 and + # nesting_state.stack[-1].check_namespace_indentation and + # isinstance(nesting_state.previous_stack_top, _NamespaceInfo) and + # nesting_state.previous_stack_top == nesting_state.stack[-2]) + is_namespace_indent_item = ( - len(nesting_state.stack) > 1 and - nesting_state.stack[-1].check_namespace_indentation and - isinstance(nesting_state.previous_stack_top, _NamespaceInfo) and - nesting_state.previous_stack_top == nesting_state.stack[-2]) + len(nesting_state.stack) >= 1 and + (isinstance(nesting_state.stack[-1], _NamespaceInfo) or (isinstance(nesting_state.previous_stack_top, _NamespaceInfo))) + ) + + # print(str(line) + " line content : " + str(clean_lines.elided[line])) + # print("len(nesting_state.stack) : " + str(len(nesting_state.stack))) + # if (len(nesting_state.stack)): + # print("nesting_state.stack[-1] : " + str(nesting_state.stack[-1])) + # print("nesting_state.stack[-1].check_namespace_indentation : " + str(nesting_state.stack[-1].check_namespace_indentation)) + # print("isinstance(nesting_state.previous_stack_top, _NamespaceInfo) : " + str(isinstance(nesting_state.previous_stack_top, _NamespaceInfo))) + # if (len(nesting_state.stack) > 1): + # print("nesting_state.previous_stack_top == nesting_state.stack[-2]) : " + str(nesting_state.previous_stack_top == nesting_state.stack[-2])) + # print("is_namespace_indent_item : " + str(is_namespace_indent_item)) if ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item, clean_lines.elided, line): @@ -5116,7 +5116,7 @@ def CheckIncludeLine(filename, clean_lines, linenum, include_state, error): match = _RE_PATTERN_INCLUDE.search(line) if match: include = match.group(2) - used_angle_brackets = match.group(1) == '<' + used_angle_brackets = (match.group(1) == '<') duplicate_line = include_state.FindHeader(include) if duplicate_line >= 0: error(filename, linenum, 'build/include', 4, @@ -6324,9 +6324,19 @@ def IsBlockInNameSpace(nesting_state, is_forward_declaration): isinstance(nesting_state.stack[-1], _NamespaceInfo)) - return (len(nesting_state.stack) > 1 and - nesting_state.stack[-1].check_namespace_indentation and - isinstance(nesting_state.stack[-2], _NamespaceInfo)) + # return (len(nesting_state.stack) > 1 and + # nesting_state.stack[-1].check_namespace_indentation and + # isinstance(nesting_state.stack[-2], _NamespaceInfo)) + + if (len(nesting_state.stack) >= 1): + if (isinstance(nesting_state.stack[-1], _NamespaceInfo)): + return True + elif (len(nesting_state.stack) > 1 and + isinstance(nesting_state.previous_stack_top, _NamespaceInfo) and + isinstance(nesting_state.stack[-2], _NamespaceInfo)): + return True + + return False def ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item, From e61a686db28604e942f223194e71cde5ca9af4ac Mon Sep 17 00:00:00 2001 From: Yujin <78896558+Yujinmon@users.noreply.github.com> Date: Tue, 21 Nov 2023 23:48:41 +0900 Subject: [PATCH 02/11] remove comments in CheckForNamespaceIndentation erase other print statements for testing except original code. --- cpplint.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/cpplint.py b/cpplint.py index 34b4582..7a8dc01 100755 --- a/cpplint.py +++ b/cpplint.py @@ -3557,16 +3557,6 @@ def CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line, (isinstance(nesting_state.stack[-1], _NamespaceInfo) or (isinstance(nesting_state.previous_stack_top, _NamespaceInfo))) ) - # print(str(line) + " line content : " + str(clean_lines.elided[line])) - # print("len(nesting_state.stack) : " + str(len(nesting_state.stack))) - # if (len(nesting_state.stack)): - # print("nesting_state.stack[-1] : " + str(nesting_state.stack[-1])) - # print("nesting_state.stack[-1].check_namespace_indentation : " + str(nesting_state.stack[-1].check_namespace_indentation)) - # print("isinstance(nesting_state.previous_stack_top, _NamespaceInfo) : " + str(isinstance(nesting_state.previous_stack_top, _NamespaceInfo))) - # if (len(nesting_state.stack) > 1): - # print("nesting_state.previous_stack_top == nesting_state.stack[-2]) : " + str(nesting_state.previous_stack_top == nesting_state.stack[-2])) - # print("is_namespace_indent_item : " + str(is_namespace_indent_item)) - if ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item, clean_lines.elided, line): CheckItemIndentationInNamespace(filename, clean_lines.elided, From 89071b24d249ff11cd75963da58c146e6a5de453 Mon Sep 17 00:00:00 2001 From: Yujin <78896558+Yujinmon@users.noreply.github.com> Date: Wed, 22 Nov 2023 00:26:36 +0900 Subject: [PATCH 03/11] bug fix --- cpplint.py | 41 +++++++++++++++++++++++++++-------------- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/cpplint.py b/cpplint.py index 7a8dc01..61c85ba 100755 --- a/cpplint.py +++ b/cpplint.py @@ -98,9 +98,10 @@ certain of the problem, and 1 meaning it could be a legitimate construct. This will miss some errors, and is not a substitute for a code review. - To suppress false-positive errors of a certain category, add a - 'NOLINT(category)' comment to the line. NOLINT or NOLINT(*) - suppresses errors of all categories on that line. + To suppress false-positive errors of certain categories, add a + 'NOLINT(category[, category...])' comment to the line. NOLINT or NOLINT(*) + suppresses errors of all categories on that line. To suppress categories + on the next line use NOLINTNEXTLINE instead of NOLINT. The files passed in will be linted; at least one file must be provided. Default linted extensions are %s. @@ -408,7 +409,7 @@ 'alloc.h', 'builtinbuf.h', 'bvector.h', - 'complex.h', + # 'complex.h', collides with System C header "complex.h" 'defalloc.h', 'deque.h', 'editbuf.h', @@ -520,6 +521,22 @@ 'optional', 'string_view', 'variant', + # 17.6.1.2 C++20 headers + 'barrier', + 'bit', + 'compare', + 'concepts', + 'coroutine', + 'format', + 'latch' + 'numbers', + 'ranges', + 'semaphore', + 'source_location', + 'span', + 'stop_token', + 'syncstream', + 'version', # 17.6.1.2 C++ headers for C library facilities 'cassert', 'ccomplex', @@ -985,12 +1002,11 @@ def ParseNolintSuppressions(filename, raw_line, linenum, error): suppressed_line = linenum + 1 else: suppressed_line = linenum - category = matched.group(2) - if category in (None, '(*)'): # => "suppress all" + categories = matched.group(2) + if categories in (None, '(*)'): # => "suppress all" _error_suppressions.setdefault(None, set()).add(suppressed_line) - else: - if category.startswith('(') and category.endswith(')'): - category = category[1:-1] + elif categories.startswith('(') and categories.endswith(')'): + for category in set(map(lambda c: c.strip(), categories[1:-1].split(','))): if category in _ERROR_CATEGORIES: _error_suppressions.setdefault(category, set()).add(suppressed_line) elif any(c for c in _OTHER_NOLINT_CATEGORY_PREFIXES if category.startswith(c)): @@ -3545,13 +3561,11 @@ def IsBlankLine(line): def CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line, error): - # Plain Source Code # is_namespace_indent_item = ( # len(nesting_state.stack) > 1 and # nesting_state.stack[-1].check_namespace_indentation and # isinstance(nesting_state.previous_stack_top, _NamespaceInfo) and # nesting_state.previous_stack_top == nesting_state.stack[-2]) - is_namespace_indent_item = ( len(nesting_state.stack) >= 1 and (isinstance(nesting_state.stack[-1], _NamespaceInfo) or (isinstance(nesting_state.previous_stack_top, _NamespaceInfo))) @@ -5106,7 +5120,7 @@ def CheckIncludeLine(filename, clean_lines, linenum, include_state, error): match = _RE_PATTERN_INCLUDE.search(line) if match: include = match.group(2) - used_angle_brackets = (match.group(1) == '<') + used_angle_brackets = match.group(1) == '<' duplicate_line = include_state.FindHeader(include) if duplicate_line >= 0: error(filename, linenum, 'build/include', 4, @@ -6317,7 +6331,6 @@ def IsBlockInNameSpace(nesting_state, is_forward_declaration): # return (len(nesting_state.stack) > 1 and # nesting_state.stack[-1].check_namespace_indentation and # isinstance(nesting_state.stack[-2], _NamespaceInfo)) - if (len(nesting_state.stack) >= 1): if (isinstance(nesting_state.stack[-1], _NamespaceInfo)): return True @@ -6327,7 +6340,7 @@ def IsBlockInNameSpace(nesting_state, is_forward_declaration): return True return False - + def ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item, raw_lines_no_comments, linenum): From 37fa38bd9ddc5d24131c4ae44490e620dd36fb25 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sun, 31 Mar 2024 16:23:37 +0000 Subject: [PATCH 04/11] remove comments and extraneous whitespace --- cpplint.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/cpplint.py b/cpplint.py index 61c85ba..17a1b39 100755 --- a/cpplint.py +++ b/cpplint.py @@ -3561,11 +3561,6 @@ def IsBlankLine(line): def CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line, error): - # is_namespace_indent_item = ( - # len(nesting_state.stack) > 1 and - # nesting_state.stack[-1].check_namespace_indentation and - # isinstance(nesting_state.previous_stack_top, _NamespaceInfo) and - # nesting_state.previous_stack_top == nesting_state.stack[-2]) is_namespace_indent_item = ( len(nesting_state.stack) >= 1 and (isinstance(nesting_state.stack[-1], _NamespaceInfo) or (isinstance(nesting_state.previous_stack_top, _NamespaceInfo))) @@ -6327,10 +6322,6 @@ def IsBlockInNameSpace(nesting_state, is_forward_declaration): return len(nesting_state.stack) >= 1 and ( isinstance(nesting_state.stack[-1], _NamespaceInfo)) - - # return (len(nesting_state.stack) > 1 and - # nesting_state.stack[-1].check_namespace_indentation and - # isinstance(nesting_state.stack[-2], _NamespaceInfo)) if (len(nesting_state.stack) >= 1): if (isinstance(nesting_state.stack[-1], _NamespaceInfo)): return True From 579616387b626afa34e2581c2dde5c06e8dfd05c Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sun, 31 Mar 2024 16:25:32 +0000 Subject: [PATCH 05/11] fix lint errors --- cpplint.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cpplint.py b/cpplint.py index 17a1b39..3e5f61f 100755 --- a/cpplint.py +++ b/cpplint.py @@ -3563,7 +3563,8 @@ def CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line, error): is_namespace_indent_item = ( len(nesting_state.stack) >= 1 and - (isinstance(nesting_state.stack[-1], _NamespaceInfo) or (isinstance(nesting_state.previous_stack_top, _NamespaceInfo))) + (isinstance(nesting_state.stack[-1], _NamespaceInfo) or + (isinstance(nesting_state.previous_stack_top, _NamespaceInfo))) ) if ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item, @@ -6322,16 +6323,15 @@ def IsBlockInNameSpace(nesting_state, is_forward_declaration): return len(nesting_state.stack) >= 1 and ( isinstance(nesting_state.stack[-1], _NamespaceInfo)) - if (len(nesting_state.stack) >= 1): - if (isinstance(nesting_state.stack[-1], _NamespaceInfo)): + if len(nesting_state.stack) >= 1: + if isinstance(nesting_state.stack[-1], _NamespaceInfo): return True - elif (len(nesting_state.stack) > 1 and + elif (len(nesting_state.stack) > 1 and isinstance(nesting_state.previous_stack_top, _NamespaceInfo) and isinstance(nesting_state.stack[-2], _NamespaceInfo)): return True - return False - + def ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item, raw_lines_no_comments, linenum): From 3ec85d301d65503f34ea118276193a71e1a8846f Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sun, 31 Mar 2024 16:30:02 +0000 Subject: [PATCH 06/11] rename category to whitspace/indent_namespace --- cpplint.py | 4 ++-- cpplint_unittest.py | 4 ++-- samples/boost-sample/exclude.def | 2 +- samples/boost-sample/headers_inspect.def | 2 +- samples/boost-sample/simple.def | 14 +++++++------- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/cpplint.py b/cpplint.py index 3e5f61f..9889f41 100755 --- a/cpplint.py +++ b/cpplint.py @@ -333,7 +333,6 @@ 'runtime/invalid_increment', 'runtime/member_string_references', 'runtime/memset', - 'runtime/indentation_namespace', 'runtime/operator', 'runtime/printf', 'runtime/printf_format', @@ -352,6 +351,7 @@ 'whitespace/ending_newline', 'whitespace/forcolon', 'whitespace/indent', + 'whitspace/indent_namespace', 'whitespace/line_length', 'whitespace/newline', 'whitespace/operators', @@ -6370,7 +6370,7 @@ def CheckItemIndentationInNamespace(filename, raw_lines_no_comments, linenum, error): line = raw_lines_no_comments[linenum] if Match(r'^\s+', line): - error(filename, linenum, 'runtime/indentation_namespace', 4, + error(filename, linenum, 'whitspace/indent_namespace', 4, 'Do not indent within a namespace') diff --git a/cpplint_unittest.py b/cpplint_unittest.py index 30c5140..5feab9b 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -312,7 +312,7 @@ def testForwardDeclarationNameSpaceIndentation(self): results = self.GetNamespaceResults(lines) self.assertEquals(results, 'Do not indent within a namespace ' - ' [runtime/indentation_namespace] [4]') + ' [whitspace/indent_namespace] [4]') def testNameSpaceIndentationForClass(self): lines = ['namespace Test {', @@ -323,7 +323,7 @@ def testNameSpaceIndentationForClass(self): results = self.GetNamespaceResults(lines) self.assertEquals(results, 'Do not indent within a namespace ' - ' [runtime/indentation_namespace] [4]') + ' [whitspace/indent_namespace] [4]') def testNameSpaceIndentationNoError(self): lines = ['namespace Test {', diff --git a/samples/boost-sample/exclude.def b/samples/boost-sample/exclude.def index 2ba4f60..2cf79ec 100644 --- a/samples/boost-sample/exclude.def +++ b/samples/boost-sample/exclude.def @@ -13,7 +13,7 @@ src/inspect/unnamed_namespace_check.hpp:19: Closing ) should be moved to the pr src/inspect/unnamed_namespace_check.hpp:21: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] src/inspect/unnamed_namespace_check.hpp:21: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:26: { should almost always be at the end of the previous line [whitespace/braces] [4] -src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace [runtime/indentation_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace [whitspace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:28: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:29: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/inspect/unnamed_namespace_check.hpp:30: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] diff --git a/samples/boost-sample/headers_inspect.def b/samples/boost-sample/headers_inspect.def index b54e21c..c9b6717 100644 --- a/samples/boost-sample/headers_inspect.def +++ b/samples/boost-sample/headers_inspect.def @@ -12,7 +12,7 @@ src/inspect/unnamed_namespace_check.hpp:19: Closing ) should be moved to the pr src/inspect/unnamed_namespace_check.hpp:21: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] src/inspect/unnamed_namespace_check.hpp:21: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:26: { should almost always be at the end of the previous line [whitespace/braces] [4] -src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace [runtime/indentation_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace [whitspace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:28: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:29: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/inspect/unnamed_namespace_check.hpp:30: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] diff --git a/samples/boost-sample/simple.def b/samples/boost-sample/simple.def index 453efe4..e466f8e 100644 --- a/samples/boost-sample/simple.def +++ b/samples/boost-sample/simple.def @@ -7,7 +7,7 @@ Total errors found: 2572 include/boost/math/octonion.hpp:11: #ifndef header guard has wrong style, please use: SAMPLES_BOOST_SAMPLE_INCLUDE_BOOST_MATH_OCTONION_HPP_ [build/header_guard] [5] include/boost/math/octonion.hpp:4250: #endif line should be "#endif // SAMPLES_BOOST_SAMPLE_INCLUDE_BOOST_MATH_OCTONION_HPP_" [build/header_guard] [5] include/boost/math/octonion.hpp:18: { should almost always be at the end of the previous line [whitespace/braces] [4] -include/boost/math/octonion.hpp:19: Do not indent within a namespace [runtime/indentation_namespace] [4] +include/boost/math/octonion.hpp:19: Do not indent within a namespace [whitspace/indent_namespace] [4] include/boost/math/octonion.hpp:20: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:21: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:30: Missing space after , [whitespace/comma] [3] @@ -83,7 +83,7 @@ include/boost/math/octonion.hpp:164: Line ends in whitespace. Consider deletin include/boost/math/octonion.hpp:165: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:175: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:176: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:178: Do not indent within a namespace [runtime/indentation_namespace] [4] +include/boost/math/octonion.hpp:178: Do not indent within a namespace [whitspace/indent_namespace] [4] include/boost/math/octonion.hpp:179: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:180: public: should be indented +1 space inside class octonion [whitespace/indent] [3] include/boost/math/octonion.hpp:181: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -266,7 +266,7 @@ include/boost/math/octonion.hpp:663: Line ends in whitespace. Consider deletin include/boost/math/octonion.hpp:667: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:668: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:670: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:671: Do not indent within a namespace [runtime/indentation_namespace] [4] +include/boost/math/octonion.hpp:671: Do not indent within a namespace [whitspace/indent_namespace] [4] include/boost/math/octonion.hpp:672: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:673: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:679: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -733,7 +733,7 @@ include/boost/math/octonion.hpp:1235: Line ends in whitespace. Consider deleti include/boost/math/octonion.hpp:1241: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1247: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1248: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:1250: Do not indent within a namespace [runtime/indentation_namespace] [4] +include/boost/math/octonion.hpp:1250: Do not indent within a namespace [whitspace/indent_namespace] [4] include/boost/math/octonion.hpp:1251: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1252: public: should be indented +1 space inside class octonion [whitespace/indent] [3] include/boost/math/octonion.hpp:1253: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -775,7 +775,7 @@ include/boost/math/octonion.hpp:1307: Redundant blank line at the end of a code include/boost/math/octonion.hpp:1307: Do not leave a blank line after "private:" [whitespace/blank_line] [3] include/boost/math/octonion.hpp:1309: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1310: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:1312: Do not indent within a namespace [runtime/indentation_namespace] [4] +include/boost/math/octonion.hpp:1312: Do not indent within a namespace [whitspace/indent_namespace] [4] include/boost/math/octonion.hpp:1313: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1314: public: should be indented +1 space inside class octonion [whitespace/indent] [3] include/boost/math/octonion.hpp:1315: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -818,7 +818,7 @@ include/boost/math/octonion.hpp:1371: Redundant blank line at the end of a code include/boost/math/octonion.hpp:1371: Do not leave a blank line after "private:" [whitespace/blank_line] [3] include/boost/math/octonion.hpp:1373: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1374: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:1376: Do not indent within a namespace [runtime/indentation_namespace] [4] +include/boost/math/octonion.hpp:1376: Do not indent within a namespace [whitspace/indent_namespace] [4] include/boost/math/octonion.hpp:1377: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1378: public: should be indented +1 space inside class octonion [whitespace/indent] [3] include/boost/math/octonion.hpp:1379: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -2569,7 +2569,7 @@ include/boost/math/octonion.hpp:4222: Missing space after , [whitespace/comma] include/boost/math/octonion.hpp:4225: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4226: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4228: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:4229: Do not indent within a namespace [runtime/indentation_namespace] [4] +include/boost/math/octonion.hpp:4229: Do not indent within a namespace [whitspace/indent_namespace] [4] include/boost/math/octonion.hpp:4230: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4231: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4236: { should almost always be at the end of the previous line [whitespace/braces] [4] From a09d256bfc92968784ecf164994026f9bc85cfa7 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Sun, 31 Mar 2024 16:32:27 +0000 Subject: [PATCH 07/11] add a period in the error message --- cpplint.py | 6 +++--- cpplint_unittest.py | 8 ++++---- samples/boost-sample/exclude.def | 2 +- samples/boost-sample/headers_inspect.def | 2 +- samples/boost-sample/simple.def | 14 +++++++------- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/cpplint.py b/cpplint.py index 9889f41..14fcbdb 100755 --- a/cpplint.py +++ b/cpplint.py @@ -351,7 +351,7 @@ 'whitespace/ending_newline', 'whitespace/forcolon', 'whitespace/indent', - 'whitspace/indent_namespace', + 'whitespace/indent_namespace', 'whitespace/line_length', 'whitespace/newline', 'whitespace/operators', @@ -6370,8 +6370,8 @@ def CheckItemIndentationInNamespace(filename, raw_lines_no_comments, linenum, error): line = raw_lines_no_comments[linenum] if Match(r'^\s+', line): - error(filename, linenum, 'whitspace/indent_namespace', 4, - 'Do not indent within a namespace') + error(filename, linenum, 'whitespace/indent_namespace', 4, + 'Do not indent within a namespace.') def ProcessLine(filename, file_extension, clean_lines, line, diff --git a/cpplint_unittest.py b/cpplint_unittest.py index 5feab9b..9a2e1db 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -311,8 +311,8 @@ def testForwardDeclarationNameSpaceIndentation(self): '} // namespace Test'] results = self.GetNamespaceResults(lines) - self.assertEquals(results, 'Do not indent within a namespace ' - ' [whitspace/indent_namespace] [4]') + self.assertEquals(results, 'Do not indent within a namespace. ' + ' [whitespace/indent_namespace] [4]') def testNameSpaceIndentationForClass(self): lines = ['namespace Test {', @@ -322,8 +322,8 @@ def testNameSpaceIndentationForClass(self): '} // namespace Test'] results = self.GetNamespaceResults(lines) - self.assertEquals(results, 'Do not indent within a namespace ' - ' [whitspace/indent_namespace] [4]') + self.assertEquals(results, 'Do not indent within a namespace. ' + ' [whitespace/indent_namespace] [4]') def testNameSpaceIndentationNoError(self): lines = ['namespace Test {', diff --git a/samples/boost-sample/exclude.def b/samples/boost-sample/exclude.def index 2cf79ec..fa959ea 100644 --- a/samples/boost-sample/exclude.def +++ b/samples/boost-sample/exclude.def @@ -13,7 +13,7 @@ src/inspect/unnamed_namespace_check.hpp:19: Closing ) should be moved to the pr src/inspect/unnamed_namespace_check.hpp:21: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] src/inspect/unnamed_namespace_check.hpp:21: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:26: { should almost always be at the end of the previous line [whitespace/braces] [4] -src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace [whitspace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:28: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:29: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/inspect/unnamed_namespace_check.hpp:30: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] diff --git a/samples/boost-sample/headers_inspect.def b/samples/boost-sample/headers_inspect.def index c9b6717..8e81252 100644 --- a/samples/boost-sample/headers_inspect.def +++ b/samples/boost-sample/headers_inspect.def @@ -12,7 +12,7 @@ src/inspect/unnamed_namespace_check.hpp:19: Closing ) should be moved to the pr src/inspect/unnamed_namespace_check.hpp:21: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] src/inspect/unnamed_namespace_check.hpp:21: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:26: { should almost always be at the end of the previous line [whitespace/braces] [4] -src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace [whitspace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:28: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:29: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/inspect/unnamed_namespace_check.hpp:30: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] diff --git a/samples/boost-sample/simple.def b/samples/boost-sample/simple.def index e466f8e..396769a 100644 --- a/samples/boost-sample/simple.def +++ b/samples/boost-sample/simple.def @@ -7,7 +7,7 @@ Total errors found: 2572 include/boost/math/octonion.hpp:11: #ifndef header guard has wrong style, please use: SAMPLES_BOOST_SAMPLE_INCLUDE_BOOST_MATH_OCTONION_HPP_ [build/header_guard] [5] include/boost/math/octonion.hpp:4250: #endif line should be "#endif // SAMPLES_BOOST_SAMPLE_INCLUDE_BOOST_MATH_OCTONION_HPP_" [build/header_guard] [5] include/boost/math/octonion.hpp:18: { should almost always be at the end of the previous line [whitespace/braces] [4] -include/boost/math/octonion.hpp:19: Do not indent within a namespace [whitspace/indent_namespace] [4] +include/boost/math/octonion.hpp:19: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:20: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:21: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:30: Missing space after , [whitespace/comma] [3] @@ -83,7 +83,7 @@ include/boost/math/octonion.hpp:164: Line ends in whitespace. Consider deletin include/boost/math/octonion.hpp:165: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:175: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:176: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:178: Do not indent within a namespace [whitspace/indent_namespace] [4] +include/boost/math/octonion.hpp:178: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:179: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:180: public: should be indented +1 space inside class octonion [whitespace/indent] [3] include/boost/math/octonion.hpp:181: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -266,7 +266,7 @@ include/boost/math/octonion.hpp:663: Line ends in whitespace. Consider deletin include/boost/math/octonion.hpp:667: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:668: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:670: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:671: Do not indent within a namespace [whitspace/indent_namespace] [4] +include/boost/math/octonion.hpp:671: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:672: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:673: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:679: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -733,7 +733,7 @@ include/boost/math/octonion.hpp:1235: Line ends in whitespace. Consider deleti include/boost/math/octonion.hpp:1241: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1247: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1248: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:1250: Do not indent within a namespace [whitspace/indent_namespace] [4] +include/boost/math/octonion.hpp:1250: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1251: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1252: public: should be indented +1 space inside class octonion [whitespace/indent] [3] include/boost/math/octonion.hpp:1253: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -775,7 +775,7 @@ include/boost/math/octonion.hpp:1307: Redundant blank line at the end of a code include/boost/math/octonion.hpp:1307: Do not leave a blank line after "private:" [whitespace/blank_line] [3] include/boost/math/octonion.hpp:1309: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1310: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:1312: Do not indent within a namespace [whitspace/indent_namespace] [4] +include/boost/math/octonion.hpp:1312: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1313: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1314: public: should be indented +1 space inside class octonion [whitespace/indent] [3] include/boost/math/octonion.hpp:1315: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -818,7 +818,7 @@ include/boost/math/octonion.hpp:1371: Redundant blank line at the end of a code include/boost/math/octonion.hpp:1371: Do not leave a blank line after "private:" [whitespace/blank_line] [3] include/boost/math/octonion.hpp:1373: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1374: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:1376: Do not indent within a namespace [whitspace/indent_namespace] [4] +include/boost/math/octonion.hpp:1376: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1377: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1378: public: should be indented +1 space inside class octonion [whitespace/indent] [3] include/boost/math/octonion.hpp:1379: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -2569,7 +2569,7 @@ include/boost/math/octonion.hpp:4222: Missing space after , [whitespace/comma] include/boost/math/octonion.hpp:4225: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4226: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4228: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] -include/boost/math/octonion.hpp:4229: Do not indent within a namespace [whitspace/indent_namespace] [4] +include/boost/math/octonion.hpp:4229: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4230: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4231: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4236: { should almost always be at the end of the previous line [whitespace/braces] [4] From 3084250ac7d2d9915316d7f2b03367e0fa262857 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Tue, 23 Apr 2024 13:58:23 +0000 Subject: [PATCH 08/11] Fix nearly all tests for namespace indentation The only test that fails is for when the entire namespace, including the declaration, is indented. I'm not sure if we should support that usecase, but the error would also seem misleading. --- cpplint_unittest.py | 14 +- samples/boost-sample/exclude.def | 21 +- samples/boost-sample/headers_inspect.def | 16 +- samples/boost-sample/headers_simple.def | 7 +- samples/boost-sample/simple.def | 354 +++++++++++++- samples/chromium-sample/simple.def | 10 +- samples/protobuf-sample/simple.def | 568 ++++++++++++++++++++++- 7 files changed, 978 insertions(+), 12 deletions(-) diff --git a/cpplint_unittest.py b/cpplint_unittest.py index 4d77a0f..0643d87 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -283,7 +283,7 @@ def GetNamespaceResults(self, lines): return error_collector.Results() - def testForwardDeclarationNameSpaceIndentation(self): + def testForwardDeclarationNamespaceIndentation(self): lines = ['namespace Test {', ' class ForwardDeclaration;', '} // namespace Test'] @@ -292,7 +292,7 @@ def testForwardDeclarationNameSpaceIndentation(self): self.assertEqual(results, 'Do not indent within a namespace. ' ' [whitespace/indent_namespace] [4]') - def testNameSpaceIndentationForClass(self): + def testNamespaceIndentationForClass(self): lines = ['namespace Test {', 'void foo() { }', ' class Test {', @@ -300,10 +300,12 @@ def testNameSpaceIndentationForClass(self): '} // namespace Test'] results = self.GetNamespaceResults(lines) - self.assertEqual(results, 'Do not indent within a namespace. ' - ' [whitespace/indent_namespace] [4]') + self.assertEqual(results, ['Do not indent within a namespace. ' + ' [whitespace/indent_namespace] [4]', + 'Do not indent within a namespace. ' + ' [whitespace/indent_namespace] [4]']) - def testNameSpaceIndentationNoError(self): + def testNamespaceIndentationNoError(self): lines = ['namespace Test {', 'void foo() { }', '} // namespace Test'] @@ -319,7 +321,7 @@ def testWhitespaceBeforeNamespace(self): results = self.GetNamespaceResults(lines) self.assertEqual(results, '') - def testFalsePositivesNoError(self): + def testStructInNamespace(self): lines = ['namespace Test {', 'struct OuterClass {', ' struct NoFalsePositivesHere;', diff --git a/samples/boost-sample/exclude.def b/samples/boost-sample/exclude.def index fa959ea..e9fef89 100644 --- a/samples/boost-sample/exclude.def +++ b/samples/boost-sample/exclude.def @@ -3,19 +3,25 @@ 4 Done processing src/inspect/unnamed_namespace_check.hpp Done processing src/tr1/c_policy.hpp -Total errors found: 107 +Total errors found: 126 src/inspect/unnamed_namespace_check.hpp:0: No #ifndef header guard found, suggested CPP variable is: SAMPLES_BOOST_SAMPLE_SRC_INSPECT_UNNAMED_NAMESPACE_CHECK_HPP_ [build/header_guard] [5] src/inspect/unnamed_namespace_check.hpp:11: Include the directory when naming header files [build/include_subdir] [4] src/inspect/unnamed_namespace_check.hpp:14: Do not use unnamed namespaces in header files. See https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces for more information. [build/namespaces_headers] [4] +src/inspect/unnamed_namespace_check.hpp:17: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:18: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:18: At least two spaces is best between code and comments [whitespace/comments] [2] +src/inspect/unnamed_namespace_check.hpp:19: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:19: Closing ) should be moved to the previous line [whitespace/parens] [2] src/inspect/unnamed_namespace_check.hpp:21: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] src/inspect/unnamed_namespace_check.hpp:21: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:26: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:28: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:28: { should almost always be at the end of the previous line [whitespace/braces] [4] +src/inspect/unnamed_namespace_check.hpp:29: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:29: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/inspect/unnamed_namespace_check.hpp:30: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:30: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/inspect/unnamed_namespace_check.hpp:30: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:31: Extra space after ( in function call [whitespace/parens] [4] @@ -34,8 +40,14 @@ src/inspect/unnamed_namespace_check.hpp:36: Extra space after ( in function cal src/inspect/unnamed_namespace_check.hpp:36: Extra space before ) [whitespace/parens] [2] src/inspect/unnamed_namespace_check.hpp:37: Extra space after ( in function call [whitespace/parens] [4] src/inspect/unnamed_namespace_check.hpp:37: Extra space before ) [whitespace/parens] [2] +src/inspect/unnamed_namespace_check.hpp:38: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:38: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/inspect/unnamed_namespace_check.hpp:40: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:40: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/inspect/unnamed_namespace_check.hpp:41: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:42: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:43: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:44: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:44: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:48: Lines should be <= 80 characters long [whitespace/line_length] [2] src/inspect/unnamed_namespace_check.hpp:49: Missing space before ( in for( [whitespace/parens] [5] @@ -43,6 +55,8 @@ src/inspect/unnamed_namespace_check.hpp:50: { should almost always be at the en src/inspect/unnamed_namespace_check.hpp:54: Extra space after ( in function call [whitespace/parens] [4] src/inspect/unnamed_namespace_check.hpp:54: Extra space before ) [whitespace/parens] [2] src/inspect/unnamed_namespace_check.hpp:57: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] +src/inspect/unnamed_namespace_check.hpp:58: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:59: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:59: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:60: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:51: Add #include for string [build/include_what_you_use] [4] @@ -111,5 +125,10 @@ src/tr1/c_policy.hpp:109: Namespace should be terminated with "// namespace mat src/tr1/c_policy.hpp:109: Namespace should be terminated with "// namespace boost" [readability/namespace] [5] src/tr1/c_policy.hpp:109: At least two spaces is best between code and comments [whitespace/comments] [2] src/tr1/c_policy.hpp:111: Missing space before { [whitespace/braces] [5] +src/tr1/c_policy.hpp:122: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/tr1/c_policy.hpp:123: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/tr1/c_policy.hpp:124: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/tr1/c_policy.hpp:125: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/tr1/c_policy.hpp:126: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/tr1/c_policy.hpp:131: Namespace should be terminated with "// namespace c_policies" [readability/namespace] [5] diff --git a/samples/boost-sample/headers_inspect.def b/samples/boost-sample/headers_inspect.def index 8e81252..6c61efc 100644 --- a/samples/boost-sample/headers_inspect.def +++ b/samples/boost-sample/headers_inspect.def @@ -2,19 +2,25 @@ src/inspect/* 1 3 Done processing src/inspect/unnamed_namespace_check.hpp -Total errors found: 41 +Total errors found: 55 src/inspect/unnamed_namespace_check.hpp:0: No #ifndef header guard found, suggested CPP variable is: SAMPLES_BOOST_SAMPLE_SRC_INSPECT_UNNAMED_NAMESPACE_CHECK_HPP_ [build/header_guard] [5] src/inspect/unnamed_namespace_check.hpp:11: Include the directory when naming header files [build/include_subdir] [4] src/inspect/unnamed_namespace_check.hpp:14: Do not use unnamed namespaces in header files. See https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces for more information. [build/namespaces_headers] [4] +src/inspect/unnamed_namespace_check.hpp:17: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:18: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:18: At least two spaces is best between code and comments [whitespace/comments] [2] +src/inspect/unnamed_namespace_check.hpp:19: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:19: Closing ) should be moved to the previous line [whitespace/parens] [2] src/inspect/unnamed_namespace_check.hpp:21: Anonymous namespace should be terminated with "// namespace" [readability/namespace] [5] src/inspect/unnamed_namespace_check.hpp:21: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:26: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:27: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:28: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:28: { should almost always be at the end of the previous line [whitespace/braces] [4] +src/inspect/unnamed_namespace_check.hpp:29: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:29: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/inspect/unnamed_namespace_check.hpp:30: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:30: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/inspect/unnamed_namespace_check.hpp:30: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:31: Extra space after ( in function call [whitespace/parens] [4] @@ -33,8 +39,14 @@ src/inspect/unnamed_namespace_check.hpp:36: Extra space after ( in function cal src/inspect/unnamed_namespace_check.hpp:36: Extra space before ) [whitespace/parens] [2] src/inspect/unnamed_namespace_check.hpp:37: Extra space after ( in function call [whitespace/parens] [4] src/inspect/unnamed_namespace_check.hpp:37: Extra space before ) [whitespace/parens] [2] +src/inspect/unnamed_namespace_check.hpp:38: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:38: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/inspect/unnamed_namespace_check.hpp:40: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:40: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/inspect/unnamed_namespace_check.hpp:41: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:42: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:43: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:44: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:44: { should almost always be at the end of the previous line [whitespace/braces] [4] src/inspect/unnamed_namespace_check.hpp:48: Lines should be <= 80 characters long [whitespace/line_length] [2] src/inspect/unnamed_namespace_check.hpp:49: Missing space before ( in for( [whitespace/parens] [5] @@ -42,6 +54,8 @@ src/inspect/unnamed_namespace_check.hpp:50: { should almost always be at the en src/inspect/unnamed_namespace_check.hpp:54: Extra space after ( in function call [whitespace/parens] [4] src/inspect/unnamed_namespace_check.hpp:54: Extra space before ) [whitespace/parens] [2] src/inspect/unnamed_namespace_check.hpp:57: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] +src/inspect/unnamed_namespace_check.hpp:58: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/inspect/unnamed_namespace_check.hpp:59: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/inspect/unnamed_namespace_check.hpp:59: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:60: At least two spaces is best between code and comments [whitespace/comments] [2] src/inspect/unnamed_namespace_check.hpp:51: Add #include for string [build/include_what_you_use] [4] diff --git a/samples/boost-sample/headers_simple.def b/samples/boost-sample/headers_simple.def index cd66673..5621a28 100644 --- a/samples/boost-sample/headers_simple.def +++ b/samples/boost-sample/headers_simple.def @@ -2,7 +2,7 @@ src/tr1/* 1 3 Done processing src/tr1/c_policy.hpp -Total errors found: 66 +Total errors found: 71 src/tr1/c_policy.hpp:0: No #ifndef header guard found, suggested CPP variable is: SAMPLES_BOOST_SAMPLE_SRC_TR1_C_POLICY_HPP_ [build/header_guard] [5] src/tr1/c_policy.hpp:9: Missing space before { [whitespace/braces] [5] @@ -69,5 +69,10 @@ src/tr1/c_policy.hpp:109: Namespace should be terminated with "// namespace mat src/tr1/c_policy.hpp:109: Namespace should be terminated with "// namespace boost" [readability/namespace] [5] src/tr1/c_policy.hpp:109: At least two spaces is best between code and comments [whitespace/comments] [2] src/tr1/c_policy.hpp:111: Missing space before { [whitespace/braces] [5] +src/tr1/c_policy.hpp:122: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/tr1/c_policy.hpp:123: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/tr1/c_policy.hpp:124: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/tr1/c_policy.hpp:125: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/tr1/c_policy.hpp:126: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/tr1/c_policy.hpp:131: Namespace should be terminated with "// namespace c_policies" [readability/namespace] [5] diff --git a/samples/boost-sample/simple.def b/samples/boost-sample/simple.def index 396769a..823013c 100644 --- a/samples/boost-sample/simple.def +++ b/samples/boost-sample/simple.def @@ -2,13 +2,15 @@ include/boost/math/* 1 3 Done processing include/boost/math/octonion.hpp -Total errors found: 2572 +Total errors found: 2924 include/boost/math/octonion.hpp:11: #ifndef header guard has wrong style, please use: SAMPLES_BOOST_SAMPLE_INCLUDE_BOOST_MATH_OCTONION_HPP_ [build/header_guard] [5] include/boost/math/octonion.hpp:4250: #endif line should be "#endif // SAMPLES_BOOST_SAMPLE_INCLUDE_BOOST_MATH_OCTONION_HPP_" [build/header_guard] [5] include/boost/math/octonion.hpp:18: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:19: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:20: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:20: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:21: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:21: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:30: Missing space after , [whitespace/comma] [3] include/boost/math/octonion.hpp:75: Missing space after , [whitespace/comma] [3] @@ -17,7 +19,9 @@ include/boost/math/octonion.hpp:85: Missing space after , [whitespace/comma] [ include/boost/math/octonion.hpp:90: Missing space after , [whitespace/comma] [3] include/boost/math/octonion.hpp:95: Missing space after , [whitespace/comma] [3] include/boost/math/octonion.hpp:100: Missing space after , [whitespace/comma] [3] +include/boost/math/octonion.hpp:102: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:102: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:103: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:103: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:104: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:105: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -79,10 +83,14 @@ include/boost/math/octonion.hpp:159: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:160: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:161: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:162: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:164: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:164: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:165: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:165: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:175: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:176: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:176: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:177: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:178: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:179: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:180: public: should be indented +1 space inside class octonion [whitespace/indent] [3] @@ -260,18 +268,39 @@ include/boost/math/octonion.hpp:657: private: should be indented +1 space insid include/boost/math/octonion.hpp:658: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:658: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] include/boost/math/octonion.hpp:658: Do not leave a blank line after "private:" [whitespace/blank_line] [3] +include/boost/math/octonion.hpp:659: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:660: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:660: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:661: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:661: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:663: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:663: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:664: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:665: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:666: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:667: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:667: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:668: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:668: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:670: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:670: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:671: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:672: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:672: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:673: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:673: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:674: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:675: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:676: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:677: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:678: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:679: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:679: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:680: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:680: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:682: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:682: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:683: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:683: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:684: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:685: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -322,8 +351,11 @@ include/boost/math/octonion.hpp:726: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:727: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:728: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:729: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:731: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:731: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:732: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:732: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:740: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:740: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:741: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:742: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -332,6 +364,7 @@ include/boost/math/octonion.hpp:744: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:745: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:746: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:747: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:749: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:749: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:750: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:751: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -342,6 +375,7 @@ include/boost/math/octonion.hpp:755: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:756: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:757: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:758: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:760: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:760: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:761: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:762: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -357,7 +391,9 @@ include/boost/math/octonion.hpp:771: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:772: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:773: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:774: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:776: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:776: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:784: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:784: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:785: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:786: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -366,6 +402,7 @@ include/boost/math/octonion.hpp:788: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:789: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:790: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:791: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:793: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:793: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:794: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:795: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -376,8 +413,11 @@ include/boost/math/octonion.hpp:799: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:800: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:801: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:802: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:804: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:804: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:820: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:820: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:835: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:835: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:836: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:837: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -404,6 +444,7 @@ include/boost/math/octonion.hpp:857: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:858: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:859: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:860: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:862: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:862: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:863: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:864: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -432,6 +473,7 @@ include/boost/math/octonion.hpp:886: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:887: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:888: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:889: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:891: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:891: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:892: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:893: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -465,9 +507,13 @@ include/boost/math/octonion.hpp:920: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:921: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:922: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:923: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:925: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:925: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:932: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:932: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:943: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:943: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:945: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:945: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:946: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:947: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -508,6 +554,7 @@ include/boost/math/octonion.hpp:981: Lines should be <= 80 characters long [wh include/boost/math/octonion.hpp:982: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:983: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:984: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:987: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:987: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:988: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:989: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -547,7 +594,9 @@ include/boost/math/octonion.hpp:1022: Lines should be <= 80 characters long [w include/boost/math/octonion.hpp:1023: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1024: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1025: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1028: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1028: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1030: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1030: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1031: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1032: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -590,6 +639,7 @@ include/boost/math/octonion.hpp:1068: Lines should be <= 80 characters long [w include/boost/math/octonion.hpp:1069: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1070: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1071: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1074: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1074: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1075: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1076: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -631,7 +681,9 @@ include/boost/math/octonion.hpp:1111: Lines should be <= 80 characters long [w include/boost/math/octonion.hpp:1112: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1113: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1114: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1117: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1117: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1119: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1119: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1120: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1121: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -679,6 +731,7 @@ include/boost/math/octonion.hpp:1162: Lines should be <= 80 characters long [w include/boost/math/octonion.hpp:1163: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1164: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1165: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1168: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1168: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1169: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1170: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -725,14 +778,23 @@ include/boost/math/octonion.hpp:1210: Lines should be <= 80 characters long [w include/boost/math/octonion.hpp:1211: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1212: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1213: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1216: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1216: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1217: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1217: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1223: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1223: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1229: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1229: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1235: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1235: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1241: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1241: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1247: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1247: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1248: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1248: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1249: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1250: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1251: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1252: public: should be indented +1 space inside class octonion [whitespace/indent] [3] @@ -773,8 +835,12 @@ include/boost/math/octonion.hpp:1306: private: should be indented +1 space insi include/boost/math/octonion.hpp:1307: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1307: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] include/boost/math/octonion.hpp:1307: Do not leave a blank line after "private:" [whitespace/blank_line] [3] +include/boost/math/octonion.hpp:1308: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1309: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1309: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1310: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1310: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1311: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1312: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1313: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1314: public: should be indented +1 space inside class octonion [whitespace/indent] [3] @@ -816,8 +882,12 @@ include/boost/math/octonion.hpp:1370: private: should be indented +1 space insi include/boost/math/octonion.hpp:1371: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1371: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] include/boost/math/octonion.hpp:1371: Do not leave a blank line after "private:" [whitespace/blank_line] [3] +include/boost/math/octonion.hpp:1372: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1373: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1373: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1374: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1374: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1375: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1376: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1377: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1378: public: should be indented +1 space inside class octonion [whitespace/indent] [3] @@ -860,122 +930,245 @@ include/boost/math/octonion.hpp:1434: private: should be indented +1 space insi include/boost/math/octonion.hpp:1435: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1435: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] include/boost/math/octonion.hpp:1435: Do not leave a blank line after "private:" [whitespace/blank_line] [3] +include/boost/math/octonion.hpp:1436: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1437: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1437: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1438: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1438: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1440: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1440: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1442: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1442: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1447: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1447: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1464: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1464: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1465: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1465: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1467: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1467: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1469: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1469: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1471: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1471: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1472: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1472: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1474: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1474: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1481: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1481: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1482: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1483: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1484: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1486: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1486: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1487: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1488: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1489: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1491: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1491: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1492: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1493: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1494: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1496: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1496: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1497: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1498: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1499: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1501: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1501: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1502: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1503: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1504: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1506: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1506: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1507: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1508: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1509: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1511: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1511: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1512: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1513: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1514: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1516: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1516: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1525: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1525: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1526: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1526: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1527: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1528: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1529: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1530: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1531: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1531: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1532: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1532: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1534: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1534: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1542: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1542: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1544: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1544: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1545: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1545: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1546: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1547: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1547: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1548: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1548: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:1550: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1551: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1551: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1552: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1552: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1553: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1554: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1554: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1555: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1555: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1556: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1556: Missing space after , [whitespace/comma] [3] +include/boost/math/octonion.hpp:1557: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1558: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1558: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1559: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1559: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1560: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1561: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1561: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1562: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1562: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1572: Closing ) should be moved to the previous line [whitespace/parens] [2] +include/boost/math/octonion.hpp:1573: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1574: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1574: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1575: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1575: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1576: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1577: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1577: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1578: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1578: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1588: Closing ) should be moved to the previous line [whitespace/parens] [2] +include/boost/math/octonion.hpp:1589: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1590: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1590: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1591: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1591: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1592: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1593: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1593: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1594: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1594: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1604: Closing ) should be moved to the previous line [whitespace/parens] [2] +include/boost/math/octonion.hpp:1605: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1606: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1606: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1607: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1607: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1608: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1609: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1609: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1610: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1610: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1620: Closing ) should be moved to the previous line [whitespace/parens] [2] +include/boost/math/octonion.hpp:1621: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1622: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1622: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1623: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1623: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1624: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1625: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1625: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1626: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1626: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1636: Closing ) should be moved to the previous line [whitespace/parens] [2] +include/boost/math/octonion.hpp:1637: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1638: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1638: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1639: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1639: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1640: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1641: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1641: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1642: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1642: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1652: Closing ) should be moved to the previous line [whitespace/parens] [2] +include/boost/math/octonion.hpp:1653: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1654: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1654: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1655: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1655: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1656: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1657: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1657: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1658: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1658: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1668: Closing ) should be moved to the previous line [whitespace/parens] [2] +include/boost/math/octonion.hpp:1669: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1670: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1670: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1671: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1671: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1676: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1676: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1677: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1678: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1678: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1679: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1680: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1680: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1681: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1682: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1682: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1683: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1684: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1684: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1685: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1686: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1686: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1687: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1688: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1688: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1689: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1690: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1690: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1691: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1692: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1692: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1693: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1694: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1694: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1695: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1696: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1696: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1697: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1698: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1698: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1699: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1700: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1700: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1701: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1702: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1702: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1703: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1704: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1704: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1705: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1706: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1706: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:1707: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1707: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:1708: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1709: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:1710: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1711: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1711: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1711: Missing space after , [whitespace/comma] [3] include/boost/math/octonion.hpp:1711: Extra space after ( [whitespace/parens] [2] +include/boost/math/octonion.hpp:1712: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:1713: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:1713: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:1716: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:1718: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -2413,38 +2606,78 @@ include/boost/math/octonion.hpp:3843: Lines should be <= 80 characters long [w include/boost/math/octonion.hpp:3844: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3846: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3849: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3852: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3853: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3853: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3854: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3854: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3855: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3856: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3856: Lines should be <= 80 characters long [whitespace/line_length] [2] include/boost/math/octonion.hpp:3856: Missing space after , [whitespace/comma] [3] include/boost/math/octonion.hpp:3856: Extra space after ( [whitespace/parens] [2] +include/boost/math/octonion.hpp:3857: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3857: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:3858: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3858: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:3859: Missing space after , [whitespace/comma] [3] include/boost/math/octonion.hpp:3860: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3867: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3876: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3878: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3879: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3879: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3880: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3880: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3882: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3882: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3883: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3884: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3885: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3885: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:3887: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3888: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3888: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3889: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3889: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3890: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3891: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3892: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3892: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:3894: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3895: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3895: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3896: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3896: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3910: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3910: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3911: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3911: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3912: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3913: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3914: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3914: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:3918: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3920: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3922: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3923: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3923: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3924: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3924: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3925: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3926: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3927: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3927: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:3931: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3933: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3935: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3936: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3936: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3937: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3937: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3938: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3939: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3940: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3940: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:3944: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3946: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -2459,20 +2692,50 @@ include/boost/math/octonion.hpp:3960: Line ends in whitespace. Consider deleti include/boost/math/octonion.hpp:3962: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3965: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3966: Should have a space between // and comment [whitespace/comments] [4] +include/boost/math/octonion.hpp:3967: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3968: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3968: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3969: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3969: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3971: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3971: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3972: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3972: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3974: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3974: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3975: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3976: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3977: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3977: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:3979: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3980: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3980: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3981: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3981: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3982: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3983: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3984: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3984: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:3993: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:3994: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3994: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3995: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3995: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:3996: Lines should be <= 80 characters long [whitespace/line_length] [2] +include/boost/math/octonion.hpp:3998: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3998: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:3999: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:3999: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4000: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4001: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4002: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4003: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4004: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4005: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4006: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4007: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4008: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4009: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4009: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4012: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4013: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -2502,54 +2765,129 @@ include/boost/math/octonion.hpp:4045: Line ends in whitespace. Consider deleti include/boost/math/octonion.hpp:4047: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4050: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4051: Missing space after , [whitespace/comma] [3] +include/boost/math/octonion.hpp:4052: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4053: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4053: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4054: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4054: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4055: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4056: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4057: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4058: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4059: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4060: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4061: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4062: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4063: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4064: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4064: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4067: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4076: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4077: Missing space after , [whitespace/comma] [3] +include/boost/math/octonion.hpp:4078: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4079: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4079: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4080: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4080: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4081: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4082: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4083: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4084: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4085: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4086: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4087: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4088: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4089: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4090: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4090: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4093: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4096: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4097: Missing space after , [whitespace/comma] [3] +include/boost/math/octonion.hpp:4098: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4099: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4099: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4100: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4100: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4101: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4102: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4103: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4103: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4106: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4108: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4110: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4112: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4114: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4120: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4121: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4121: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4122: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4122: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4123: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4124: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4125: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4125: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4129: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4131: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4133: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4135: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4141: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4142: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4142: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4143: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4143: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4144: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4145: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4146: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4146: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4150: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4152: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4154: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4156: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4162: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4163: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4163: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4164: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4164: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4165: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4166: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4167: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4167: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:4169: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4170: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4170: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4171: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4171: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4172: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4173: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4174: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4174: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:4176: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4177: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4177: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4178: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4178: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4179: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4180: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4181: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4181: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:4183: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4184: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4184: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4185: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4185: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4186: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4187: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4188: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4188: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:4190: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4191: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4191: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4192: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4192: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4193: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4194: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4195: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4196: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4196: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4198: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4200: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -2566,14 +2904,28 @@ include/boost/math/octonion.hpp:4217: { should almost always be at the end of t include/boost/math/octonion.hpp:4220: An else should appear on the same line as the preceding } [whitespace/newline] [4] include/boost/math/octonion.hpp:4221: { should almost always be at the end of the previous line [whitespace/braces] [4] include/boost/math/octonion.hpp:4222: Missing space after , [whitespace/comma] [3] +include/boost/math/octonion.hpp:4224: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4225: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4225: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4226: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4226: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4228: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4228: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] include/boost/math/octonion.hpp:4229: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4230: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4230: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:4231: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4231: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] +include/boost/math/octonion.hpp:4232: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4233: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4234: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4235: Do not indent within a namespace. [whitespace/indent_namespace] [4] +include/boost/math/octonion.hpp:4236: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4236: { should almost always be at the end of the previous line [whitespace/braces] [4] +include/boost/math/octonion.hpp:4245: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4246: Namespace should be terminated with "// namespace detail" [readability/namespace] [5] +include/boost/math/octonion.hpp:4246: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4247: Namespace should be terminated with "// namespace math" [readability/namespace] [5] +include/boost/math/octonion.hpp:4247: Do not indent within a namespace. [whitespace/indent_namespace] [4] include/boost/math/octonion.hpp:4248: Namespace should be terminated with "// namespace boost" [readability/namespace] [5] diff --git a/samples/chromium-sample/simple.def b/samples/chromium-sample/simple.def index ba2ab4d..925d3af 100644 --- a/samples/chromium-sample/simple.def +++ b/samples/chromium-sample/simple.def @@ -5,8 +5,12 @@ Done processing src/chrome_content_renderer_client.cc Done processing src/chrome_content_renderer_client.h Done processing src/io_thread.cc Done processing src/io_thread.h -Total errors found: 17 +Total errors found: 25 +src/chrome_content_renderer_client.cc:303: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/chrome_content_renderer_client.cc:308: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/chrome_content_renderer_client.cc:309: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/chrome_content_renderer_client.cc:310: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/chrome_content_renderer_client.cc:308: Add #include for vector<> [build/include_what_you_use] [4] src/chrome_content_renderer_client.cc:1540: Add #include for set<> [build/include_what_you_use] [4] src/chrome_content_renderer_client.cc:1841: Add #include for string [build/include_what_you_use] [4] @@ -15,6 +19,10 @@ src/chrome_content_renderer_client.h:5: #ifndef header guard has wrong style, p src/chrome_content_renderer_client.h:225: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_" [build/header_guard] [5] src/chrome_content_renderer_client.h:115: Use int16/int64/etc, rather than the C type long [runtime/int] [4] src/chrome_content_renderer_client.h:117: Use int16/int64/etc, rather than the C type long [runtime/int] [4] +src/io_thread.cc:242: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/io_thread.cc:286: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/io_thread.cc:298: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/io_thread.cc:299: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/io_thread.cc:1148: Closing ) should be moved to the previous line [whitespace/parens] [2] src/io_thread.cc:1547: Missing space around colon in range-based for loop [whitespace/forcolon] [2] src/io_thread.cc:651: Add #include for map<> [build/include_what_you_use] [4] diff --git a/samples/protobuf-sample/simple.def b/samples/protobuf-sample/simple.def index 393995b..9bb5495 100644 --- a/samples/protobuf-sample/simple.def +++ b/samples/protobuf-sample/simple.def @@ -4,7 +4,7 @@ src/* Done processing src/descriptor.pb.cc Done processing src/descriptor.pb.h Done processing src/descriptor_unittest.cc -Total errors found: 2646 +Total errors found: 3212 src/descriptor.pb.cc:0: No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5] src/descriptor.pb.cc:9: Found C system header after C++ system header. Should be: descriptor.pb.h, c system, c++ system, other. [build/include_order] [4] @@ -16,16 +16,40 @@ src/descriptor.pb.cc:14: Found C system header after C++ system header. Should src/descriptor.pb.cc:15: Found C system header after C++ system header. Should be: descriptor.pb.h, c system, c++ system, other. [build/include_order] [4] src/descriptor.pb.cc:16: Found C system header after C++ system header. Should be: descriptor.pb.h, c system, c++ system, other. [build/include_order] [4] src/descriptor.pb.cc:17: Found C system header after C++ system header. Should be: descriptor.pb.h, c system, c++ system, other. [build/include_order] [4] +src/descriptor.pb.cc:27: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:30: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:33: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:34: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:36: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:37: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:39: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:42: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:43: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:44: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:47: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:50: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:51: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:53: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:56: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:59: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:62: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:63: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:66: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:69: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:71: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:74: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:77: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:80: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:83: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:86: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:87: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:89: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:92: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:93: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:95: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:98: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:99: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:101: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:117: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:121: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:125: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -236,12 +260,18 @@ src/descriptor.pb.cc:819: Lines should be <= 80 characters long [whitespace/li src/descriptor.pb.cc:834: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:838: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:863: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:890: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:899: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:900: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:917: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:932: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:938: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:956: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:961: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:964: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:970: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1004: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:1020: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1030: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1063: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:1064: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -250,8 +280,11 @@ src/descriptor.pb.cc:1100: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:1133: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1137: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1150: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1176: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1182: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1183: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1187: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:1188: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1197: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1198: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1201: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -264,6 +297,7 @@ src/descriptor.pb.cc:1249: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:1252: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1260: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1263: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1280: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1285: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1288: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1347: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -280,6 +314,8 @@ src/descriptor.pb.cc:1455: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:1456: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1459: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1460: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1510: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:1608: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1708: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1733: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] src/descriptor.pb.cc:1756: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] @@ -296,62 +332,97 @@ src/descriptor.pb.cc:1897: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:1898: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1899: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:1950: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1953: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1953: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:1955: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1957: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1957: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:1959: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1962: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1962: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:1964: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1967: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1967: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:1973: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1973: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:1976: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1978: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1978: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:1981: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:1983: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:1983: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:1989: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2004: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2007: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2007: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2009: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2011: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2011: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2013: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2016: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2016: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2018: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2021: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2021: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2023: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2027: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2027: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2030: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2032: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2032: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2035: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2037: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2037: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2043: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2054: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2054: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2058: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2058: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2062: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2062: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2062: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2066: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2066: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2070: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2070: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2070: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2075: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2075: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2079: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2079: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2083: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2083: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2087: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2087: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2091: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2091: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2096: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2096: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2109: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2109: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2109: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2113: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2113: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2113: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2117: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2117: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2117: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2121: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2121: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2126: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2126: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2139: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2139: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2139: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2143: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2143: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2143: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2147: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2147: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2147: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2151: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2151: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:2156: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2156: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2169: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2173: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -375,21 +446,31 @@ src/descriptor.pb.cc:2344: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:2352: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2359: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2381: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2384: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2384: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2386: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2388: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2388: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2390: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2393: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2393: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2395: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2398: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2398: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2400: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2404: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2404: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2407: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2409: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2409: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2412: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2414: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2414: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:2420: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2434: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2442: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2443: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:2444: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2463: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:2472: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2477: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -398,13 +479,16 @@ src/descriptor.pb.cc:2482: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:2484: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2502: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:2506: Missing space after , [whitespace/comma] [3] +src/descriptor.pb.cc:2522: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2527: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2530: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2535: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2550: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2583: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2587: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2592: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2602: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2603: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2607: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2612: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2616: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -419,7 +503,10 @@ src/descriptor.pb.cc:2700: Redundant blank line at the start of a code block sh src/descriptor.pb.cc:2704: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2708: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2716: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2733: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2741: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2742: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:2743: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2762: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:2771: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2776: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -428,13 +515,16 @@ src/descriptor.pb.cc:2781: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:2783: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2801: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:2805: Missing space after , [whitespace/comma] [3] +src/descriptor.pb.cc:2821: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2826: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2829: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2834: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2849: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2882: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2886: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2891: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2901: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:2902: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:2906: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2911: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:2915: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -448,12 +538,16 @@ src/descriptor.pb.cc:2991: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:2999: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:3007: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3015: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3040: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3046: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3050: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:3051: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3060: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3071: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3088: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3106: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3109: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3127: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3132: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3135: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3158: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -466,7 +560,9 @@ src/descriptor.pb.cc:3237: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:3252: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3263: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3268: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3321: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3351: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3399: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3433: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3479: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3504: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] @@ -480,28 +576,43 @@ src/descriptor.pb.cc:3636: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:3637: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3638: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3639: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3691: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3691: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:3695: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3695: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3695: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3715: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3715: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:3719: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3719: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:3743: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3743: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:3747: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3747: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3747: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3767: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3767: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:3771: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3771: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3792: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3795: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3795: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3797: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3799: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3799: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3801: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3804: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3804: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3806: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3809: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3809: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:3815: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3815: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3818: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3820: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3820: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3823: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:3825: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:3825: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:3831: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:3842: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -533,24 +644,38 @@ src/descriptor.pb.cc:4070: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:4074: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4078: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4083: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4096: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4096: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4100: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4100: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4104: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4104: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4104: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4108: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4108: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4112: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4112: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4112: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4117: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4117: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4121: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4121: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4125: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4125: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4129: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4129: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4133: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4133: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4138: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4138: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4148: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4153: Missing space before ( in switch( [whitespace/parens] [5] src/descriptor.pb.cc:4201: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4206: Missing space before ( in switch( [whitespace/parens] [5] +src/descriptor.pb.cc:4238: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4244: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4248: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:4249: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4258: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4262: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4263: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -568,6 +693,7 @@ src/descriptor.pb.cc:4322: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:4325: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4328: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4334: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4347: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4352: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4355: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4394: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -577,9 +703,11 @@ src/descriptor.pb.cc:4430: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:4433: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4482: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4496: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4546: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4570: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4613: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4633: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4634: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4660: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4706: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4721: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -595,131 +723,193 @@ src/descriptor.pb.cc:4866: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:4869: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:4892: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:4941: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4944: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4944: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4946: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4948: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4948: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4950: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4953: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4953: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4955: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4958: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4958: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:4964: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4964: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4967: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4969: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4969: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4972: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4974: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4974: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:4980: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:4998: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:4998: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:5002: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5002: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:5022: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5022: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5022: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5026: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5026: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5026: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5047: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5047: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5047: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5051: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5051: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5051: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5069: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5072: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5072: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5074: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5076: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5076: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5078: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5081: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5081: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5083: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5086: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5086: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5088: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5092: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5092: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5095: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5097: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5097: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5100: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5102: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5102: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5108: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5123: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5126: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5126: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5128: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5130: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5130: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5132: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5135: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5135: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5137: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5140: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5140: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5142: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5146: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5146: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5149: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5151: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5151: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5154: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5156: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5156: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5162: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5177: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5180: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5180: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5182: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5184: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5184: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5186: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5189: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5189: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5191: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5194: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5194: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5196: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5200: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5200: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5203: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5205: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5205: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5208: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5210: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5210: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5210: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5216: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5234: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5234: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:5238: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5238: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5255: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5258: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5258: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5260: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5262: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5262: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5264: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5267: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5267: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5269: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5272: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5272: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5274: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5278: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5278: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5281: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5283: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5283: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5286: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5288: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5288: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5294: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5331: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5351: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:5360: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:5361: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5370: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5380: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5381: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:5396: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5402: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5413: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5422: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5427: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5430: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5470: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5489: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5490: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5504: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5536: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:5537: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5554: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5577: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:5614: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5617: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5617: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5619: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5621: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5621: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5623: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5626: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5626: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5628: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5631: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5631: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:5637: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5637: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5640: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5642: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5642: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5645: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5647: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5647: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:5653: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5668: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5674: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5678: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:5679: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5688: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5699: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5716: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5722: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5734: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5748: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5753: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5756: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5779: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5794: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:5826: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:5858: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:5886: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:5911: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] src/descriptor.pb.cc:5935: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -729,17 +919,24 @@ src/descriptor.pb.cc:5957: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:5980: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:5981: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6023: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6026: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6026: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6028: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6030: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6030: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6032: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6035: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6035: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6037: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6040: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6040: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:6046: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6046: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6049: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6051: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6051: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6054: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6056: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6056: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6062: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6073: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -747,20 +944,26 @@ src/descriptor.pb.cc:6077: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:6085: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6090: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6129: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6151: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6157: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6160: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6161: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:6162: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6171: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6183: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6200: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6206: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6218: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6222: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6232: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6237: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6240: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6262: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6276: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6308: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6322: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6338: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6339: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6354: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6365: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6397: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] @@ -772,38 +975,53 @@ src/descriptor.pb.cc:6437: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:6445: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6460: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:6502: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6505: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6505: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6507: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6509: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6509: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6511: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6514: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6514: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6516: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6519: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6519: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:6525: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6525: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6528: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6530: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6530: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6533: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6535: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6535: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6541: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6559: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6559: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:6563: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6563: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6583: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6587: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6595: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6602: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6624: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6630: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6633: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6634: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:6635: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6644: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6655: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6672: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6678: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6690: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6693: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6704: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6709: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6712: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6735: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6750: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6782: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6813: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6814: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6842: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6867: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] src/descriptor.pb.cc:6888: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -814,17 +1032,24 @@ src/descriptor.pb.cc:6913: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:6936: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:6937: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:6979: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6982: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6982: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6984: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6986: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6986: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6988: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6991: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6991: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:6993: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:6996: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:6996: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:7002: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7002: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7005: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7007: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7007: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7010: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7012: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7012: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7018: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7029: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -834,7 +1059,10 @@ src/descriptor.pb.cc:7041: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:7046: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7066: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7085: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7110: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7116: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7120: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:7121: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7130: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7131: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7132: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -849,14 +1077,17 @@ src/descriptor.pb.cc:7199: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:7202: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7205: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7208: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7222: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7227: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7230: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7285: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7299: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7314: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7347: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7387: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7392: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7402: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7403: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7447: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7452: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7456: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -869,59 +1100,87 @@ src/descriptor.pb.cc:7547: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:7550: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7579: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:7624: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7627: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7627: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7629: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7631: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7631: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7633: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7636: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7636: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7638: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7641: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7641: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:7647: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7647: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7650: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7652: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7652: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7655: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7657: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7657: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7663: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7678: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7681: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7681: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7683: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7685: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7685: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7687: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7690: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7690: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7692: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7695: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7695: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7697: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7701: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7701: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7704: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7706: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7706: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7709: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7711: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7711: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7711: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7717: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7732: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7735: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7735: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7737: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7739: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7739: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7741: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7744: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7744: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7746: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7749: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7749: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7751: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7755: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7755: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7758: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7760: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7760: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7763: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7765: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7765: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7765: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7771: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7789: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7808: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:7833: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7833: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:7837: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7837: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:7857: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7857: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:7861: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7861: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:7871: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7876: Missing space before ( in switch( [whitespace/parens] [5] +src/descriptor.pb.cc:7913: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:7922: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:7923: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:7932: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7933: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:7938: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -941,6 +1200,7 @@ src/descriptor.pb.cc:8014: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:8018: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8024: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8027: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8042: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8047: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8050: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8074: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -958,6 +1218,7 @@ src/descriptor.pb.cc:8231: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:8248: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8275: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8281: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8320: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8335: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8342: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8350: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -968,6 +1229,7 @@ src/descriptor.pb.cc:8380: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:8385: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8390: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8395: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8436: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8452: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8460: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8468: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -994,102 +1256,155 @@ src/descriptor.pb.cc:8760: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:8762: If/else bodies with multiple statements require braces [readability/braces] [4] src/descriptor.pb.cc:8773: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8813: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8816: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8816: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8818: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8820: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8820: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8822: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8825: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8825: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8827: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8830: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8830: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8832: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8836: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8836: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8839: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8841: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8841: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8844: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8846: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8846: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8852: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8867: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8870: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8870: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8872: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8874: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8874: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8876: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8879: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8879: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8881: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8884: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8884: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8886: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8890: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8890: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8893: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8895: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8895: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8898: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8900: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8900: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8900: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8906: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8924: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8924: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:8928: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8928: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:8948: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8948: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:8952: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8952: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:8972: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8972: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:8976: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8976: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8982: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:8996: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:8996: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:8996: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:8998: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9000: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9000: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9000: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9018: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9021: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9021: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9023: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9025: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9025: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9027: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9030: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9030: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9032: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9035: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9035: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9037: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9041: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9041: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9044: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9046: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9046: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9049: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9051: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9051: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9057: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9075: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9075: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9079: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9079: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9099: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9099: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9103: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9103: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9123: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9123: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9127: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9127: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9147: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9147: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9151: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9151: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9171: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9171: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9175: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9175: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9192: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9195: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9195: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9197: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9199: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9199: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9201: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9204: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9204: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9206: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9209: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9209: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9211: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9215: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9215: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9218: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9220: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9220: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9223: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9225: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9225: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9225: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9231: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9246: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9249: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9249: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9251: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9253: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9253: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9255: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9258: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9258: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9260: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9263: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9263: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9265: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9269: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9269: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9272: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9274: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9274: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9277: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9279: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9279: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9279: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9285: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1097,10 +1412,14 @@ src/descriptor.pb.cc:9296: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:9300: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9304: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9313: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9332: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:9341: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:9342: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9363: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:9378: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9403: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:9407: Missing space after , [whitespace/comma] [3] +src/descriptor.pb.cc:9424: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9429: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9432: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9437: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1109,10 +1428,12 @@ src/descriptor.pb.cc:9467: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:9482: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9492: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9498: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9537: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9541: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9546: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9551: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9556: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9577: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9581: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9586: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9591: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1126,13 +1447,21 @@ src/descriptor.pb.cc:9719: Redundant blank line at the start of a code block sh src/descriptor.pb.cc:9720: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9722: If/else bodies with multiple statements require braces [readability/braces] [4] src/descriptor.pb.cc:9731: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:9766: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9766: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9770: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9770: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9790: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9790: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9794: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9794: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9814: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9814: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9818: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9818: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9838: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9838: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:9842: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9842: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:9855: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9859: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1140,10 +1469,14 @@ src/descriptor.pb.cc:9863: Lines should be <= 80 characters long [whitespace/l src/descriptor.pb.cc:9872: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:9887: Missing space before ( in switch( [whitespace/parens] [5] src/descriptor.pb.cc:9910: Missing space before ( in switch( [whitespace/parens] [5] +src/descriptor.pb.cc:9939: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:9948: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:9949: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:9972: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:9987: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10012: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:10016: Missing space after , [whitespace/comma] [3] +src/descriptor.pb.cc:10036: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10041: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10044: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10045: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1158,11 +1491,13 @@ src/descriptor.pb.cc:10118: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:10134: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10144: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10150: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:10189: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10199: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10204: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10209: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10212: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10220: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:10241: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10251: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10256: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10261: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1176,35 +1511,53 @@ src/descriptor.pb.cc:10356: Line ends in whitespace. Consider deleting these e src/descriptor.pb.cc:10413: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:10414: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10416: If/else bodies with multiple statements require braces [readability/braces] [4] +src/descriptor.pb.cc:10462: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10462: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10466: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10466: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10487: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10487: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10491: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10491: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:10497: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:10511: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10511: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10515: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10515: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10536: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10536: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10540: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10540: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10560: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10560: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10564: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10564: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10584: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10584: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:10588: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10588: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:10601: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10605: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10609: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10618: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:10635: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:10644: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:10645: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10664: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:10679: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10704: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:10708: Missing space after , [whitespace/comma] [3] +src/descriptor.pb.cc:10725: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10730: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10733: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10738: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10753: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10763: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10769: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:10808: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10812: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10817: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:10838: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10842: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10847: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10862: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1213,23 +1566,33 @@ src/descriptor.pb.cc:10909: Line ends in whitespace. Consider deleting these e src/descriptor.pb.cc:10954: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:10955: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:10957: If/else bodies with multiple statements require braces [readability/braces] [4] +src/descriptor.pb.cc:10999: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:10999: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:11003: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11003: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:11023: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11023: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:11027: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11027: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:11040: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11044: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11048: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11057: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11073: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:11082: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:11083: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11101: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:11116: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11122: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11142: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11147: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11150: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11155: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11165: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11171: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11210: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11214: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11235: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11239: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11254: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11294: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -1237,20 +1600,28 @@ src/descriptor.pb.cc:11295: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:11336: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:11337: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11339: If/else bodies with multiple statements require braces [readability/braces] [4] +src/descriptor.pb.cc:11380: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11380: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:11384: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11384: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:11397: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11401: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11405: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11414: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11430: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:11439: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:11440: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11458: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:11473: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11499: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11504: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11507: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11512: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11522: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11528: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11567: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11571: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11592: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11596: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11611: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11651: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] @@ -1258,33 +1629,46 @@ src/descriptor.pb.cc:11652: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:11693: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:11694: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11696: If/else bodies with multiple statements require braces [readability/braces] [4] +src/descriptor.pb.cc:11737: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11737: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:11741: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11741: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:11754: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11758: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11762: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11771: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11787: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:11796: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:11797: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11815: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:11830: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11856: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11861: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11864: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11869: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11879: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11885: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11924: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11928: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:11949: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:11953: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:11968: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12008: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:12050: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:12051: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12053: If/else bodies with multiple statements require braces [readability/braces] [4] +src/descriptor.pb.cc:12094: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12094: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:12098: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12098: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:12111: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12115: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12119: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12128: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12144: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12152: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12153: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:12154: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12163: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12174: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12175: If statement had no body and no else clause [whitespace/empty_if_body] [4] @@ -1294,11 +1678,14 @@ src/descriptor.pb.cc:12190: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:12194: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12196: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12208: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12219: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12224: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12227: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12249: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12282: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12296: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12306: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12307: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12322: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12326: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12355: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1310,6 +1697,9 @@ src/descriptor.pb.cc:12399: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:12410: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12417: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12434: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12464: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:12473: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:12474: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12483: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12487: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12488: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1324,15 +1714,18 @@ src/descriptor.pb.cc:12544: Missing space after , [whitespace/comma] [3] src/descriptor.pb.cc:12551: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12554: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12557: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12572: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12577: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12580: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12586: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12619: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12634: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12649: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12712: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12732: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12737: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12742: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:12769: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:12791: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12796: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:12801: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1346,23 +1739,32 @@ src/descriptor.pb.cc:12934: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:12957: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:12958: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13001: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13004: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13004: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13006: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13008: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13008: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13010: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13013: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13013: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13015: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13018: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13018: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13018: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13020: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13024: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13024: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13027: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13029: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13029: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13032: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13034: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13034: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13034: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13040: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13058: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13058: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:13062: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13062: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13079: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13083: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1370,63 +1772,93 @@ src/descriptor.pb.cc:13087: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:13091: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13096: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13113: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13116: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13116: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13118: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13120: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13120: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13122: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13125: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13125: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13127: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13130: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13130: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13130: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13132: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13136: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13136: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13139: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13141: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13141: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13144: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13146: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13146: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13146: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13152: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13170: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13170: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:13174: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13174: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13174: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13194: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13194: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:13198: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13198: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13198: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13218: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13218: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:13222: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13222: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13239: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13242: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13242: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13244: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13246: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13246: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13248: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13251: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13251: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13253: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13256: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13256: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13258: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13262: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13262: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13265: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13267: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13267: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13270: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13272: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13272: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13272: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13278: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13293: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13296: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13296: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13298: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13300: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13300: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13302: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13305: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13305: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13307: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13310: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13310: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13312: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13316: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13316: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13319: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13321: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13321: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13324: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13326: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13326: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:13326: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13332: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13349: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13357: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13358: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:13359: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13368: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13369: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13379: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1436,6 +1868,7 @@ src/descriptor.pb.cc:13396: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:13402: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13414: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13417: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13430: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13435: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13438: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13442: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1450,10 +1883,12 @@ src/descriptor.pb.cc:13498: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:13515: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13516: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13518: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13550: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13554: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13564: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13595: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13609: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13610: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13665: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13673: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13698: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] @@ -1465,88 +1900,132 @@ src/descriptor.pb.cc:13780: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:13788: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13803: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:13816: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13838: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:13847: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:13848: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13865: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:13880: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13904: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13909: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13912: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:13918: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:13952: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:13968: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:13978: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14011: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:14012: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14047: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] +src/descriptor.pb.cc:14080: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14080: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14084: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14084: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14084: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14088: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14088: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14092: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14092: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14097: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14097: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14110: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14110: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14114: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14114: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14114: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14118: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14118: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14122: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14122: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14127: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14127: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14144: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14147: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14147: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14149: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14151: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14151: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14151: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14153: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14156: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14156: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14158: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14161: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14161: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14161: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14163: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14167: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14167: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14170: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14172: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14172: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14175: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14177: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14177: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14177: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14183: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14198: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14201: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14201: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14203: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14205: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14205: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14205: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14207: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14210: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14210: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14212: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14215: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14215: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14215: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14217: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14221: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14221: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14224: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14226: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14226: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14229: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14231: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14231: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14231: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14237: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14248: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14248: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14248: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14252: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14252: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14252: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14256: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14256: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14256: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14260: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14260: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14260: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14264: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14264: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14264: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14269: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14269: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14273: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14273: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14273: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14277: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14277: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14277: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14281: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14281: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14281: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14282: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14285: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14285: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:14290: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14290: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:14307: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14311: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14319: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14324: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14342: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14350: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14351: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:14352: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14361: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14373: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14374: If statement had no body and no else clause [whitespace/empty_if_body] [4] @@ -1558,6 +2037,7 @@ src/descriptor.pb.cc:14395: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:14413: Are you taking an address of something dereferenced from a cast? Wrapping the dereferenced expression in parentheses will make the binding more obvious [readability/casting] [4] src/descriptor.pb.cc:14417: Missing space after , [whitespace/comma] [3] src/descriptor.pb.cc:14424: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14439: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14444: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14447: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14451: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1566,10 +2046,12 @@ src/descriptor.pb.cc:14455: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:14456: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14487: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14502: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14535: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14539: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14559: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14564: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14574: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14575: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14604: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14609: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14613: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1583,43 +2065,65 @@ src/descriptor.pb.cc:14711: Lines should be <= 80 characters long [whitespace/ src/descriptor.pb.cc:14718: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14726: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/descriptor.pb.cc:14734: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14760: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:14769: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:14770: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14787: If statement had no body and no else clause [whitespace/empty_if_body] [4] src/descriptor.pb.cc:14802: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14808: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14826: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14831: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14834: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14840: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:14874: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor.pb.cc:14890: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:14900: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14933: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/descriptor.pb.cc:14934: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:14969: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] +src/descriptor.pb.cc:15002: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15002: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:15006: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15006: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15006: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15010: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15010: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:15014: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15014: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:15019: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15019: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15036: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15039: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15039: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15041: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15043: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15043: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15043: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:15045: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15048: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15048: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15050: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15053: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15053: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15053: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:15055: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15059: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15059: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15062: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15064: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15064: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15067: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15069: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15069: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15069: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:15075: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.cc:15093: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15093: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:15097: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15097: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:15117: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15117: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor.pb.cc:15121: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.cc:15121: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/descriptor.pb.cc:15138: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.cc:15142: Lines should be <= 80 characters long [whitespace/line_length] [2] @@ -1639,26 +2143,31 @@ src/descriptor.pb.h:88: Lines should be <= 80 characters long [whitespace/line src/descriptor.pb.h:89: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:91: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:92: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.h:97: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:98: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:107: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:108: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:109: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:111: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:112: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.h:117: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:118: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:127: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:128: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:129: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:131: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:132: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.h:137: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:147: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:148: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:151: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.h:157: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:167: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:168: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:169: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:171: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:172: Lines should be <= 80 characters long [whitespace/line_length] [2] +src/descriptor.pb.h:177: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor.pb.h:183: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:225: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor.pb.h:227: private: should be indented +1 space inside class FileDescriptorSet [whitespace/indent] [3] @@ -2475,6 +2984,25 @@ src/descriptor_unittest.cc:57: "google/protobuf/stubs/logging.h" already includ src/descriptor_unittest.cc:58: Found C system header after C++ system header. Should be: descriptor_unittest.h, c system, c++ system, other. [build/include_order] [4] src/descriptor_unittest.cc:59: Found C system header after C++ system header. Should be: descriptor_unittest.h, c system, c++ system, other. [build/include_order] [4] src/descriptor_unittest.cc:60: Found C system header after C++ system header. Should be: descriptor_unittest.h, c system, c++ system, other. [build/include_order] [4] +src/descriptor_unittest.cc:88: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:95: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:102: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:103: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:104: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:114: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:115: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:116: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:117: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:128: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:129: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:130: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:131: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:142: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:150: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:158: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:166: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:167: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:168: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:734: Extra space before ) [whitespace/parens] [2] src/descriptor_unittest.cc:735: Extra space before ) [whitespace/parens] [2] src/descriptor_unittest.cc:822: Extra space after ( in function call [whitespace/parens] [4] @@ -2637,9 +3165,13 @@ src/descriptor_unittest.cc:2325: Extra space before ( in function call [whites src/descriptor_unittest.cc:2327: Extra space after ( in function call [whitespace/parens] [4] src/descriptor_unittest.cc:2327: Extra space before ( in function call [whitespace/parens] [4] src/descriptor_unittest.cc:2383: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] +src/descriptor_unittest.cc:2627: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:2698: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:2699: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:2781: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor_unittest.cc:3038: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor_unittest.cc:3120: Missing space after , [whitespace/comma] [3] +src/descriptor_unittest.cc:4183: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:4475: Closing ) should be moved to the previous line [whitespace/parens] [2] src/descriptor_unittest.cc:4489: Closing ) should be moved to the previous line [whitespace/parens] [2] src/descriptor_unittest.cc:4502: Closing ) should be moved to the previous line [whitespace/parens] [2] @@ -2648,8 +3180,42 @@ src/descriptor_unittest.cc:4548: Closing ) should be moved to the previous line src/descriptor_unittest.cc:4984: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor_unittest.cc:4990: Lines should be <= 80 characters long [whitespace/line_length] [2] src/descriptor_unittest.cc:5125: Closing ) should be moved to the previous line [whitespace/parens] [2] +src/descriptor_unittest.cc:5273: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:5274: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:5276: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:5277: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:5856: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:5929: Single-parameter constructors should be marked explicit. [runtime/explicit] [5] src/descriptor_unittest.cc:5968: Single-parameter constructors should be marked explicit. [runtime/explicit] [5] +src/descriptor_unittest.cc:6401: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6402: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6403: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6404: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6405: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6406: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6407: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6408: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6409: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6410: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6411: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6412: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6413: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6414: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6416: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6417: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6418: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6419: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6420: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6421: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6422: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6423: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6424: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6425: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6426: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6427: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6428: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:6486: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] +src/descriptor_unittest.cc:6557: Do not indent within a namespace. [whitespace/indent_namespace] [4] +src/descriptor_unittest.cc:6558: Do not indent within a namespace. [whitespace/indent_namespace] [4] src/descriptor_unittest.cc:6437: Add #include for string [build/include_what_you_use] [4] From d37f84c1f768a5abefb26b96d55ebe5a6a27d857 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Tue, 23 Apr 2024 13:59:53 +0000 Subject: [PATCH 09/11] Remove testWhitespaceBeforeNamespace I don't think we should be supporting this case. Saying "don't indent namespaces" is also not very misleading. --- cpplint_unittest.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/cpplint_unittest.py b/cpplint_unittest.py index 0643d87..b747de7 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -313,14 +313,6 @@ def testNamespaceIndentationNoError(self): results = self.GetNamespaceResults(lines) self.assertEqual(results, '') - def testWhitespaceBeforeNamespace(self): - lines = [' namespace Test {', - ' void foo() { }', - ' } // namespace Test'] - - results = self.GetNamespaceResults(lines) - self.assertEqual(results, '') - def testStructInNamespace(self): lines = ['namespace Test {', 'struct OuterClass {', From f30eeb2b406978df981bf45e7caf0827605f8868 Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Tue, 23 Apr 2024 10:16:45 -0400 Subject: [PATCH 10/11] add to changelog --- changelog.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/changelog.rst b/changelog.rst index 6f0f628..494aa3c 100644 --- a/changelog.rst +++ b/changelog.rst @@ -9,12 +9,13 @@ A bunch of long-overdue modernizations of the codebase! * Python 2 is no longer supported. Python 3.7 and 3.12 support was added, courtesy of @jayvdb * As a result of all this, setup.py's lint subcommand was removed. Please run the commands directly instead. -* NOLINT and NOLINTNEXTLINE comments now support a comma-separated list of categories, courtesy of @n3world (https://github.com/cpplint/cpplint/pull/220) * The `--filter` option can now be only applied to a specific file or even a specific line through utilizing colons, e.g. `-filter=-whitespace:foo.h,+whitespace/braces:foo.h:418`. Courtesy of @PhilLab (https://github.com/cpplint/cpplint/pull/171) +* NOLINT and NOLINTNEXTLINE comments now support a comma-separated list of categories, courtesy of @n3world (https://github.com/cpplint/cpplint/pull/220) * NOLINT and NOLINTNEXTLINE will now ignore categories known to be from clang-tidy thanks to @xatier (https://github.com/cpplint/cpplint/pull/231) * Fix behavior with nested source repositories by @groegeorg (https://github.com/cpplint/cpplint/pull/78) * build/include-what-you-use no longer supports transitive headers from the header for the current module for parity with the style guide by @aaronliu0130 * build/include-what-you-use now supports a plethora of new functions, courtesy of @geoffviola (https://github.com/cpplint/cpplint/pull/94) +* Indented functions inside namespaces will now be correctly erred on, courtesy of @Yujinmon (https://github.com/cpplint/cpplint/pull/235) * C++20 headers will no longer be flagged as C headers thanks to @miker2 (https://github.com/cpplint/cpplint/pull/216) * Same goes for C++23 and C23 headers, thanks to @aaronliu0130 (https://github.com/cpplint/cpplint/pull/239) * "complex.h" will be treated as the C99 header instead of the legacy C++ header by @tkruse (https://github.com/cpplint/cpplint/pull/219) @@ -22,7 +23,7 @@ A bunch of long-overdue modernizations of the codebase! * As part of this, the build/c++14 and build/c++tr1 categories were removed. * The filesystem header will now also be blocked, and the build/c++17 category has been added. * You can now specify the name of the CPPLINT.cfg file through `--config` as long as it is in the same directory, thanks to @gedankenexperimenter (https://github.com/cpplint/cpplint/pull/198) -* The new __VA_OPT__(,) will now be recognized by the Whitespace linter as a function, courtesy of @elrinor (https://github.com/cpplint/cpplint/pull/237) +* The new __VA_OPT__(,) will now be recognized by the Whitespace linter as a function thanks to @elrinor (https://github.com/cpplint/cpplint/pull/237) * The check for including a source file's header file will now scan all files with the same base name. Thanks to @crogre for figuring out what code needed to be changed and @aaronliu0130 for fixing it (https://github.com/cpplint/cpplint/pull/104) * Usages of the deprecated sre_compile were refectored by @jspricke (https://github.com/cpplint/cpplint/pull/214) * Usages of deprecated unittest aliases were refactored by @tirkarthi (https://github.com/cpplint/cpplint/pull/182), @aaronliu0130 and @jayvdb From 6326e42cf51ee6e1d07839b7dbbdb7579a02109b Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Tue, 23 Apr 2024 10:31:25 -0400 Subject: [PATCH 11/11] Additional false positive test --- cpplint_unittest.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpplint_unittest.py b/cpplint_unittest.py index e0a36fb..fb63c9d 100755 --- a/cpplint_unittest.py +++ b/cpplint_unittest.py @@ -313,12 +313,15 @@ def testNamespaceIndentationNoError(self): results = self.GetNamespaceResults(lines) self.assertEqual(results, '') - def testStructInNamespace(self): + def testNestingInNamespace(self): lines = ['namespace Test {', 'struct OuterClass {', ' struct NoFalsePositivesHere;', ' struct NoFalsePositivesHere member_variable;', '};', + 'void foo() {', + ' const int no_positives_eh = 418;', + '}', '} // namespace Test'] results = self.GetNamespaceResults(lines)