Skip to content

refactor: create 941120 .ra file#4498

Merged
fzipi merged 5 commits into
mainfrom
regex-assembly/941120
Mar 21, 2026
Merged

refactor: create 941120 .ra file#4498
fzipi merged 5 commits into
mainfrom
regex-assembly/941120

Conversation

@fzipi
Copy link
Copy Markdown
Member

@fzipi fzipi commented Mar 1, 2026

what

  • create regex-assembly file for rule 941120 (XSS event handler vector detection)
  • toolchain normalized character classes (collapsed hex escapes \x0B\x09\x0C into range \t-\r, removed duplicate ;/\x3B)
  • add standard "generated from regex-assembly" comment block

why

  • maintainability: .ra file makes the pattern easier to review and update
  • consistency: aligns with the ongoing effort to move rules to regex-assembly format

refs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2026 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi requested a review from a team March 1, 2026 22:39
@fzipi fzipi mentioned this pull request Mar 1, 2026
Open
25 tasks
franbuehler
franbuehler reviewed Mar 2, 2026
View reviewed changes
Comment thread regex-assembly/941120.ra Outdated
@fzipi fzipi mentioned this pull request Mar 2, 2026
Closed
fzipi and others added 2 commits March 16, 2026 22:19
@fzipi
Merge branch 'main' into regex-assembly/941120
060b171
@fzipi
chore: make the regex more readable
c9649c5 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi requested a review from franbuehler March 17, 2026 12:17
@fzipi
Copy link
Copy Markdown
Member Author

fzipi commented Mar 17, 2026

@franbuehler Can you recheck?

@fzipi fzipi enabled auto-merge March 17, 2026 13:34
franbuehler
franbuehler reviewed Mar 21, 2026
View reviewed changes
Comment thread regex-assembly/941120.ra Outdated
franbuehler
franbuehler reviewed Mar 21, 2026
View reviewed changes
Comment thread regex-assembly/941120.ra Outdated
fzipi
fzipi commented Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member Author

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah. It was listed twice in the original. Good catch!

Comment thread regex-assembly/941120.ra Outdated
Comment thread regex-assembly/941120.ra Outdated
@fzipi
Apply suggestions from code review
af52122 
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
@fzipi fzipi requested a review from franbuehler March 21, 2026 15:19
franbuehler
franbuehler approved these changes Mar 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@franbuehler franbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzipi fzipi added this pull request to the merge queue Mar 21, 2026
Merged via the queue into main with commit e699755 Mar 21, 2026
8 checks passed
@fzipi fzipi deleted the regex-assembly/941120 branch March 21, 2026 15:46
@fzipi fzipi mentioned this pull request Apr 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franbuehler franbuehler franbuehler approved these changes

Assignees

No one assigned

Labels

🧙 regex-assembly release:refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzipi @franbuehler