Skip to content

fix: add more exclusions for Google Funding Choices cookie#4484

Merged
fzipi merged 1 commit into
coreruleset:mainfrom
azurit:ExRUle
Feb 28, 2026
Merged

fix: add more exclusions for Google Funding Choices cookie#4484
fzipi merged 1 commit into
coreruleset:mainfrom
azurit:ExRUle

Conversation

@azurit
Copy link
Copy Markdown
Member

@azurit azurit commented Feb 28, 2026

Proposed changes

Add more exclusions for Google Funding Choices cookie.

New FP is coming from 6f855a4.

PR Checklist

  • I have read the CONTRIBUTING doc
  • I have added positive tests proving my fix/feature works as intended.
  • I have added negative tests that prove my fix/feature considers common cases that might end in false positives
  • In case you changed a regular expression, you are not adding a ReDOS for pcre. You can check this using regexploit
  • My test use the comment field to write the expected behavior
  • I have added documentation for the rule or change (when appropriate)

Further comments

For the reviewer

  • Positive and negative tests were added
  • Tests cover the intended fix/feature properly
  • No usage of dangerous constructs like ctl:requestBodyAccess=Off were used in the rule
  • In case a regular expression was changed, there is no ReDOS
  • Documentation is clear for the rule/change

@github-actions
Copy link
Copy Markdown
Contributor

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi changed the title fix: Add more exclusions for Google Funding Choices cookie fix: add more exclusions for Google Funding Choices cookie Feb 28, 2026
@fzipi fzipi added this pull request to the merge queue Feb 28, 2026
Merged via the queue into coreruleset:main with commit dca1fac Feb 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants