The subject_imperative check accepts a commit subject when its first word is in the IMPERATIVES list. A few common, valid imperative verbs are missing, so they're incorrectly reported as non-imperative — for example: revamp, comment, vendor, backport, embed, polyfill.
Where
commit_check/imperatives.py
What to change
- Add the missing verbs, keeping the list consistent with the existing style/ordering.
- Add a test asserting subjects like
docs: revamp the profile and chore: comment out entry pass the imperative check.
Acceptance criteria
- The listed verbs no longer fail
subject_imperative.
- The full test suite passes.
Note
This is an incremental fix. The underlying limitation (an allow-list can never cover every valid imperative verb) is a separate, larger topic — please keep this PR scoped to adding verbs plus a test.
The
subject_imperativecheck accepts a commit subject when its first word is in theIMPERATIVESlist. A few common, valid imperative verbs are missing, so they're incorrectly reported as non-imperative — for example:revamp,comment,vendor,backport,embed,polyfill.Where
commit_check/imperatives.pyWhat to change
docs: revamp the profileandchore: comment out entrypass the imperative check.Acceptance criteria
subject_imperative.Note
This is an incremental fix. The underlying limitation (an allow-list can never cover every valid imperative verb) is a separate, larger topic — please keep this PR scoped to adding verbs plus a test.