Skip to content

Commit c79b29b

Browse files
giggiogiggio
committed
Integrate vb analyzers and fixes
Revert incorrectly changed C# code Remove analyzer base class (still working on that idea) Remove Diagnostic id modules (will implement them in a different way) Reorder fixes so they match the C# ones Make solution match C# solution Remove TestCustomWorkspace (not needed in CTP5) Removed nuget references on vsix project Added namespaces to analyzers, fixes and tests Updated names (from sealed to NotInherittable, etc) Updated AssemblyInfo Removed dead code Updated nuget references that were outdated removed unnecessary .gitkeep files Add shared to C# code fixes that were missing it
1 parent e38aaf6 commit c79b29b

File tree

73 files changed

+1414
-1598
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+1414
-1598
lines changed

‎.nuget/packages.config‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
<package id="OpenCover" version="4.5.3607-rc27" />
66
<package id="psake" version="4.4.1" />
77
<package id="ReportGenerator" version="2.0.4.0" />
8-
<package id="xunit.runners" version="2.0.0-beta5-build2785" />
8+
<package id="xunit.runners" version="2.0.0-rc1-build2826" />
99
</packages>

‎CodeCracker.CSharp.sln‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{40545653
3737
build.ps1 = build.ps1
3838
build.targets.ps1 = build.targets.ps1
3939
psake.ps1 = psake.ps1
40-
test.ps1 = test.ps1
4140
EndProjectSection
4241
EndProject
4342
Global

‎CodeCracker.VisualBasic.sln‎

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,28 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
1414
.gitattributes = .gitattributes
1515
.gitignore = .gitignore
1616
README.md = README.md
17-
runTestsVB.ps1 = runTestsVB.ps1
1817
EndProjectSection
1918
EndProject
2019
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".nuget", ".nuget", "{5413BEBC-2F00-4B54-98E9-B1A7618C3C2A}"
2120
ProjectSection(SolutionItems) = preProject
21+
nuget.config = nuget.config
2222
.nuget\packages.config = .nuget\packages.config
2323
EndProjectSection
2424
EndProject
25+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{D1591C8E-982D-402F-B3CB-1D1662104425}"
26+
ProjectSection(SolutionItems) = preProject
27+
appveyor.yml = appveyor.yml
28+
build.ps1 = build.ps1
29+
build.targets.ps1 = build.targets.ps1
30+
psake.ps1 = psake.ps1
31+
EndProjectSection
32+
EndProject
33+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{22D6C608-E7F1-4236-BB07-BE5F97A4C810}"
34+
ProjectSection(SolutionItems) = preProject
35+
runTestsVB.ps1 = runTestsVB.ps1
36+
test.ps1 = test.ps1
37+
EndProjectSection
38+
EndProject
2539
Global
2640
GlobalSection(SolutionConfigurationPlatforms) = preSolution
2741
Debug|Any CPU = Debug|Any CPU
@@ -50,4 +64,8 @@ Global
5064
GlobalSection(SolutionProperties) = preSolution
5165
HideSolutionNode = FALSE
5266
EndGlobalSection
67+
GlobalSection(NestedProjects) = preSolution
68+
{D1591C8E-982D-402F-B3CB-1D1662104425} = {3DB077DC-387D-4AAD-9ECE-96D3D24FB3A6}
69+
{22D6C608-E7F1-4236-BB07-BE5F97A4C810} = {3DB077DC-387D-4AAD-9ECE-96D3D24FB3A6}
70+
EndGlobalSection
5371
EndGlobal

‎runTestsCS.ps1‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ $Global:lastRun = $(date)
33
$testDllDirPath = "$PSScriptRoot\test\CSharp\CodeCracker.Test\bin\Debug\"
44
$testDllFileName = "CodeCracker.Test.CSharp.dll"
55
$Global:testDllFullFileName = "$testDllDirPath$testDllFileName"
6-
$Global:xunitConsole = "$PSScriptRoot\packages\xunit.runners.2.0.0-beta5-build2785\tools\xunit.console.x86.exe"
6+
$Global:xunitConsole = "$PSScriptRoot\packages\xunit.runners.2.0.0-rc1-build2826\tools\xunit.console.x86.exe"
77

88
if ($testClass -eq "now"){
99
. $Global:xunitConsole "$Global:testDllFullFileName"

‎runTestsVB.ps1‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ $Global:lastRun = $(date)
33
$testDllDirPath = "$PSScriptRoot\test\VisualBasic\CodeCracker.Test\bin\Debug\"
44
$testDllFileName = "CodeCracker.Test.VisualBasic.dll"
55
$Global:testDllFullFileName = "$testDllDirPath$testDllFileName"
6-
$Global:xunitConsole = "$PSScriptRoot\packages\xunit.runners.2.0.0-beta5-build2785\tools\xunit.console.x86.exe"
6+
$Global:xunitConsole = "$PSScriptRoot\packages\xunit.runners.2.0.0-rc1-build2826\tools\xunit.console.x86.exe"
77

88
if ($testClass -eq "now"){
99
. $Global:xunitConsole "$Global:testDllFullFileName"

‎src/CSharp/CodeCracker/CodeCracker.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<WarningLevel>4</WarningLevel>
3535
</PropertyGroup>
3636
<ItemGroup>
37-
<Compile Include="Performance\StringBuiderInLoopCodeFixProvider.cs" />
37+
<Compile Include="Performance\StringBuilderInLoopCodeFixProvider.cs" />
3838
<Compile Include="Performance\StringBuilderInLoopAnalyzer.cs" />
3939
<Compile Include="Refactoring\AllowMembersOrderingAnalyzer.cs" />
4040
<Compile Include="Refactoring\AllowMembersOrderingCodeFixProvider.StyleCop.cs" />

‎src/CSharp/CodeCracker/CodeCracker.nuspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<description>A analyzer library for C# that uses Roslyn to produce refactorings, code analysis, and other niceties.
1414

1515
This is a community project, free and open source. Everyone is invited to contribute, fork, share and use the code. No money shall be charged by this software, nor it will be. Ever.</description>
16-
<releaseNotes>Second alpha release</releaseNotes>
16+
<releaseNotes>Third alpha release</releaseNotes>
1717
<copyright>Copyright CodeCracker 2014</copyright>
1818
<tags>roslyn, analyzers</tags>
1919
<frameworkAssemblies>

‎src/CSharp/CodeCracker/Design/CopyEventToVariableBeforeFireCodeFixProvider.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@
55
using Microsoft.CodeAnalysis.CSharp.Syntax;
66
using Microsoft.CodeAnalysis.Formatting;
77
using System.Collections.Immutable;
8+
using System.Composition;
89
using System.Linq;
910
using System.Threading;
1011
using System.Threading.Tasks;
1112

1213
namespace CodeCracker.Design
1314
{
14-
[ExportCodeFixProvider("CodeCrackerCopyEventToVariableBeforeFireCodeFixProvider", LanguageNames.CSharp)]
15+
[ExportCodeFixProvider("CodeCrackerCopyEventToVariableBeforeFireCodeFixProvider", LanguageNames.CSharp), Shared]
1516
public class CopyEventToVariableBeforeFireCodeFixProvider : CodeFixProvider
1617
{
1718
private const string SyntaxAnnotatinKind = "CC-CopyEvent";

‎src/CSharp/CodeCracker/Design/StaticConstructorExceptionCodeFixProvider.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@
44
using Microsoft.CodeAnalysis.CSharp;
55
using Microsoft.CodeAnalysis.CSharp.Syntax;
66
using System.Collections.Immutable;
7+
using System.Composition;
78
using System.Linq;
89
using System.Threading;
910
using System.Threading.Tasks;
1011

1112
namespace CodeCracker.Design
1213
{
13-
[ExportCodeFixProvider("CodeCrackerStaticConstructorExceptionCodeFixProvider", LanguageNames.CSharp)]
14+
[ExportCodeFixProvider("CodeCrackerStaticConstructorExceptionCodeFixProvider", LanguageNames.CSharp), Shared]
1415
public class StaticConstructorExceptionCodeFixProvider : CodeFixProvider
1516
{
1617
public sealed override ImmutableArray<string> GetFixableDiagnosticIds()

‎src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventCodeFixProvider.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@
55
using Microsoft.CodeAnalysis.CSharp.Syntax;
66
using Microsoft.CodeAnalysis.Formatting;
77
using System.Collections.Immutable;
8+
using System.Composition;
89
using System.Linq;
910
using System.Threading;
1011
using System.Threading.Tasks;
1112

1213
namespace CodeCracker.Design
1314
{
14-
[ExportCodeFixProvider("CodeCrackerUseInvokeMethodToFireEventCodeFixProvider", LanguageNames.CSharp)]
15+
[ExportCodeFixProvider("CodeCrackerUseInvokeMethodToFireEventCodeFixProvider", LanguageNames.CSharp), Shared]
1516
public class UseInvokeMethodToFireEventCodeFixProvider : CodeFixProvider
1617
{
1718
public sealed override ImmutableArray<string> GetFixableDiagnosticIds()

0 commit comments

Comments
 (0)