Remove unnecessary check on MakeLocalVariableConstWhenItIsPossibleAnalyzer

giggio · giggio · commit 352b6b33a365 · 2016-09-06T11:51:56.000-03:00
Also add `Fact` to missing test Related to #774
diff --git a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs
@@ -36,8 +36,6 @@ private static void AnalyzeNode(SyntaxNodeAnalysisContext context)
             var localDeclaration = (LocalDeclarationStatementSyntax)context.Node;
             var semanticModel = context.SemanticModel;
 
-            if (localDeclaration.GetType().IsPointer) return;
-
             if (!localDeclaration.IsConst
                 && IsDeclarationConstFriendly(localDeclaration, semanticModel)
                 && AreVariablesOnlyWrittenInsideDeclaration(localDeclaration, semanticModel) )
diff --git a/test/CSharp/CodeCracker.Test/Performance/MakeLocalVariablesConstWhenItIsPossibleTests.cs b/test/CSharp/CodeCracker.Test/Performance/MakeLocalVariablesConstWhenItIsPossibleTests.cs
@@ -52,6 +52,7 @@ public async Task IgnoresVariablesThatChangesValueOutsideDeclaration()
             await VerifyCSharpHasNoDiagnosticsAsync(test);
         }
 
+        [Fact]
         public async Task IgnoresPointerDeclarations()
         {
             var test = @"void* value = null;".WrapInCSharpMethod();

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ public async Task IgnoresVariablesThatChangesValueOutsideDeclaration()`
`52`	`52`	`await VerifyCSharpHasNoDiagnosticsAsync(test);`
`53`	`53`	`}`
`54`	`54`
	`55`	`+ [Fact]`
`55`	`56`	`public async Task IgnoresPointerDeclarations()`
`56`	`57`	`{`
`57`	`58`	`var test = @"void* value = null;".WrapInCSharpMethod();`