Handle ref parameter detection for unused parameters

jwooley · jwooley · commit 0dbe4d034cfd · 2015-03-10T22:28:13.000-04:00
diff --git a/CodeCracker.VisualBasic.sln b/CodeCracker.VisualBasic.sln
@@ -72,7 +72,6 @@ Global
 		{1CD1A3EE-28CE-404B-A59E-AEACF762D938}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{1CD1A3EE-28CE-404B-A59E-AEACF762D938}.Release|Any CPU.Build.0 = Release|Any CPU
 		{B7B513B4-0317-4F32-B560-4BFC4FAEC239}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{B7B513B4-0317-4F32-B560-4BFC4FAEC239}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{B7B513B4-0317-4F32-B560-4BFC4FAEC239}.DebugNoVsix|Any CPU.ActiveCfg = Debug|Any CPU
 		{B7B513B4-0317-4F32-B560-4BFC4FAEC239}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{B7B513B4-0317-4F32-B560-4BFC4FAEC239}.Release|Any CPU.Build.0 = Release|Any CPU
diff --git a/src/VisualBasic/CodeCracker/Usage/UnusedParametersAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/UnusedParametersAnalyzer.vb
@@ -50,7 +50,8 @@ You should delete the parameter in such cases."
                 For Each parameter In parameters
                     Dim parameterSymbol = parameter.Value
                     If parameterSymbol Is Nothing Then Continue For
-                    If Not dataFlowAnalysis.ReadInside.Contains(parameterSymbol) Then 'AndAlso Not dataFlowAnalysis.WrittenOutside.Contains(parameterSymbol) 
+                    If Not dataFlowAnalysis.ReadInside.Contains(parameterSymbol) AndAlso
+                        Not dataFlowAnalysis.WrittenInside.Contains(parameterSymbol) Then
                         context = CreateDiagnostic(context, parameter.Key)
                     End If
                 Next
diff --git a/test/CSharp/CodeCracker.Test/Usage/UnusedParametersTests.cs b/test/CSharp/CodeCracker.Test/Usage/UnusedParametersTests.cs
@@ -449,5 +449,97 @@ class Derived : Base
 }";
             await VerifyCSharpHasNoDiagnosticsAsync(source);
         }
+
+        [Fact]
+        public async Task CallWithRefPeremeterDoesNotCreateDiagnostic()
+        {
+            const string source = @"
+class TypeName
+{
+    bool TryParse(string input, ref int output)
+    {
+        try
+        {
+            output = int.Parse(input);
+            return true;
+        }
+        catch
+        {
+            return false;
+        }
+    }
+}";
+            await VerifyCSharpHasNoDiagnosticsAsync(source);
+        }
+        [Fact]
+        public async Task CallWithUnusedRefPeremeterCreateDiagnostic()
+        {
+            const string source = @"
+class TypeName
+{
+    bool TryParse(string input, ref int output, ref int out2)
+    {
+        try
+        {
+            output = int.Parse(input);
+            return true;
+        }
+        catch
+        {
+            return false;
+        }
     }
-}
+}";
+
+            await VerifyCSharpDiagnosticAsync(source, CreateDiagnosticResult("out2", 4, 49));
+        }
+
+        [Fact]
+        public async Task CallWithOutPeremeterDoesNotCreateDiagnostic()
+        {
+            const string source = @"
+class TypeName
+{
+    bool TryParse(string input, out int output)
+    {
+        try
+        {
+            output = int.Parse(input);
+            return true;
+        }
+        catch
+        {
+            return false;
+        }
+    }
+}";
+            await VerifyCSharpHasNoDiagnosticsAsync(source);
+        }
+        [Fact]
+        public async Task CallWithUnusedOutPeremeterCreateDiagnostic()
+        {
+            const string source = @"
+class TypeName
+{
+    bool TryParse(string input, out int output, out int out2)
+    {
+        try
+        {
+            output = int.Parse(input);
+            return true;
+        }
+        catch
+        {
+            return false;
+        }
+    }
+}";
+
+            await VerifyCSharpDiagnosticAsync(source, CreateDiagnosticResult("out2", 4, 49));
+        }
+
+    }
+
+}
+
+
diff --git a/test/VisualBasic/CodeCracker.Test/Usage/UnusedParameterTests.vb b/test/VisualBasic/CodeCracker.Test/Usage/UnusedParameterTests.vb
@@ -361,6 +361,32 @@ End Class
             Await VerifyBasicHasNoDiagnosticsAsync(source)
         End Function
 
+        <Fact>
+        Public Async Function CallWithRefParameterDoesNotCreateDiagnostic() As Task
+            Const source = "
+Class Base
+        Private Function TryParse(input As String, ByRef output As Integer) As Boolean
+            output = CInt(input)
+            Return True
+        End Function
+End Class
+"
+            Await VerifyBasicHasNoDiagnosticsAsync(source)
+        End Function
+
+        <Fact>
+        Public Async Function CallWithUnusedRefParameterDoesCreateDiagnostic() As Task
+            Const source = "
+Class Base
+        Private Function TryParse(input As String, ByRef output As Integer, ByRef out2 As Integer) As Boolean
+            output = CInt(input)
+            Return True
+        End Function
+End Class
+"
+            Await VerifyBasicDiagnosticAsync(source, CreateDiagnosticResult("out2", 3, 77))
+        End Function
+
         Private Function CreateDiagnosticResult(parameterName As String, line As Integer, column As Integer) As DiagnosticResult
             Return New DiagnosticResult With {
                 .Id = DiagnosticId.UnusedParameters.ToDiagnosticId(),
