Builder for creating test Commits

smashwilson · smashwilson · commit 23ed35b724d7 · 2018-11-28T14:36:30.000-05:00
diff --git a/test/builder/commit.js b/test/builder/commit.js
@@ -0,0 +1,54 @@
+import moment from 'moment';
+
+import Commit from '../../lib/models/commit';
+
+class CommitBuilder {
+  constructor() {
+    this._sha = '0123456789abcdefghij0123456789abcdefghij';
+    this._authorEmail = 'default@email.com';
+    this._authorDate = moment('2018-11-28T12:00:00', moment.ISO_8601).unix();
+    this._coAuthors = [];
+    this._messageSubject = 'subject';
+    this._messageBody = 'body';
+  }
+
+  sha(newSha) {
+    this._sha = newSha;
+    return this;
+  }
+
+  authorEmail(newEmail) {
+    this._authorEmail = newEmail;
+    return this;
+  }
+
+  authorDate(timestamp) {
+    this._authorDate = timestamp;
+    return this;
+  }
+
+  messageSubject(subject) {
+    this._messageSubject = subject;
+    return this;
+  }
+
+  messageBody(body) {
+    this._messageBody = body;
+    return this;
+  }
+
+  build() {
+    return new Commit({
+      sha: this._sha,
+      authorEmail: this._authorEmail,
+      authorDate: this._authorDate,
+      coAuthors: this._coAuthors,
+      messageSubject: this._messageSubject,
+      messageBody: this._messageBody,
+    });
+  }
+}
+
+export function commitBuilder() {
+  return new CommitBuilder();
+}
diff --git a/test/models/commit.test.js b/test/models/commit.test.js
@@ -1,24 +1,13 @@
-import moment from 'moment';
 import dedent from 'dedent-js';
 
-import Commit, {nullCommit} from '../../lib/models/commit';
+import {nullCommit} from '../../lib/models/commit';
+import {commitBuilder} from '../builder/commit';
 
 describe('Commit', function() {
-  function buildCommit(override = {}) {
-    return new Commit({
-      sha: '0123456789abcdefghij0123456789abcdefghij',
-      authorEmail: 'me@email.com',
-      coAuthors: [],
-      authorDate: moment('2018-11-28T12:00:00', moment.ISO_8601).unix(),
-      messageSubject: 'subject',
-      messageBody: 'body',
-      ...override,
-    });
-  }
-
   describe('isBodyLong()', function() {
     it('returns false if the commit message body is short', function() {
-      assert.isFalse(buildCommit({messageBody: 'short'}).isBodyLong());
+      const commit = commitBuilder().messageBody('short').build();
+      assert.isFalse(commit.isBodyLong());
     });
 
     it('returns true if the commit message body is long', function() {
@@ -41,7 +30,8 @@ describe('Commit', function() {
         delicatissimi sea in. Est id putent accusata convenire, no tibique molestie accommodare quo, cu est fuisset
         offendit evertitur.
       `;
-      assert.isTrue(buildCommit({messageBody}).isBodyLong());
+      const commit = commitBuilder().messageBody(messageBody).build();
+      assert.isTrue(commit.isBodyLong());
     });
 
     it('returns false for a null commit', function() {
