Skip to content

Bug with the sequential domain reduction #476

Description

@bwkong

Bug1
In domain_reduction.py, line 105-108:
for i, entry in enumerate(new_bounds):
if entry[0] > entry[1]:
new_bounds[i, 0] = entry[1]
new_bounds[i, 1] = entry[0]
I guess it aims to swap the values of two entries but it does not work in that way. When new_bounds[i, 0] is rewritten, entry[0] will also be rewritten and new_bounds[i, 1] cannot be designated the appropriate value.

Bug2
new_bounds in the function transform in domain_reduction.py is never trimmed:
line 147: self._trim(new_bounds, self.original_bounds) is doing nothing.
Instead, it should be like: new_bounds = self._trim(new_bounds, self.original_bounds)
These have caused new bounds not within the original bounds.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions