Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: temporalio/samples-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: barmoshe/samples-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 10 files changed
  • 2 contributors

Commits on Mar 11, 2025

  1. Configuration menu
    Copy the full SHA
    442f4f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2026

  1. Configuration menu
    Copy the full SHA
    583d5fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    132864b View commit details
    Browse the repository at this point in the history
  3. Rework Request/Response sample around Workflow Update (fixes #6)

    Issue #6 and the Go sample it was ported from predate Workflow Update. Per
    maintainer feedback, replace the response-activity port with an update-based
    sample: the update handler runs the uppercase activity and returns the result
    to the caller, removing the response task queue, the callback activity and the
    request IDs.
    
    Ports the durability parts of samples-go/reqrespupdate: a request counter,
    continue-as-new to bound history, and an update validator that rejects requests
    while a run drains so the requester backs off and retries against the fresh run.
    
    Uses workflow.all_handlers_finished() for the drain rather than Go's hand-rolled
    pending counter, matching message_passing/safe_message_handlers.
    message_passing/waiting_for_handlers notes the continue-as-new drain case is not
    illustrated there, so this sample covers it.
    
    Adds tests, which the original sample did not have.
    
    Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    barmoshe and claude committed Jul 30, 2026
    Configuration menu
    Copy the full SHA
    662fa80 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e1d2ebf View commit details
    Browse the repository at this point in the history
  5. Run reqrespupdate tests on the time-skipping server too

    The tests were skipping when env.supports_time_skipping, on the assumption
    that the Java test server does not support workflow update. It does: both
    tests pass against it, repeatedly. CI runs the suite twice, once per
    environment, so the guard was halving this sample's coverage for no reason.
    
    Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    barmoshe and claude committed Jul 30, 2026
    Configuration menu
    Copy the full SHA
    4245b7c View commit details
    Browse the repository at this point in the history
  6. Address review feedback on reqrespupdate

    - Bound the test retry helper with a max attempt count and a short sleep, so
      a workflow that stops continuing as new fails the test instead of retrying
      forever and hanging CI.
    - Skip both tests on the time-skipping server, matching the other update
      tests in the repo (temporalio/sdk-java#1903).
    - Reject requests_before_continue_as_new < 1 in the workflow constructor.
      Zero made the run continue as new immediately and forever while rejecting
      every request.
    - Move TASK_QUEUE and WORKFLOW_ID into __init__.py, as sleep_for_days and
      message_passing/waiting_for_handlers do, instead of the worker hardcoding
      the task queue name.
    - Use the existing handle in the continue-as-new test rather than re-fetching
      it; start_workflow does not pin the handle to a run.
    
    Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    barmoshe and claude committed Jul 30, 2026
    Configuration menu
    Copy the full SHA
    6e93145 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2026

  1. Merge remote-tracking branch 'upstream/main'

    # Conflicts:
    #	pyproject.toml
    barmoshe committed Aug 14, 2026
    Configuration menu
    Copy the full SHA
    af58f14 View commit details
    Browse the repository at this point in the history
Loading