Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/amoro
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: apache/amoro
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: czy006/optqueue-refactor
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 22 files changed
  • 1 contributor

Commits on Apr 8, 2026

  1. [Refactor] OptimizingQueue decomposition: extract components and wire… 

    … SPI integration

Decompose the OptimizingQueue God Class into independent components following
the refactoring plan:

Phase 1 - Common interfaces:
- Add OptimizingType, TableOptimizingPlanner, OptimizingPlanResult, TableOptimizingCommitter to amoro-common
- Make AbstractOptimizingPlanner implement TableOptimizingPlanner

Phase 2 - ProcessFactory SPI:
- Add IcebergOptimizingProcessFactory with trigger()/recover() creating OptimizingTableProcess
- Add PaimonOptimizingProcessFactory (stub), PaimonOptimizingPlanner/Committer/CompactionTask (stubs)
- Register factories via META-INF/services SPI

Phase 3 - OptimizingTableProcess extraction:
- Extract inner TableOptimizingProcess from OptimizingQueue to standalone class
- Add OptimizingProcessAdapter bridging PersistentBase to TableProcess framework
- Wire commit() to use factory callback via setProcessFactory()

Phase 4-5 - QuotaManager + OptimizerRegistryService:
- Add QuotaManager for thread-safe per-group quota tracking
- Add OptimizerRegistryService with authenticate/touch/timeout detection

Phase 6-7 - ActionCoordinator + ExecuteEngine:
- Add OptimizingActionCoordinator delegating to ProcessFactory via SPI
- Add Blocker conflict check in ActionCoordinatorScheduler.execute()
- Add OptimizerExecuteEngine with per-group pull-based task dispatch

Phase 8 - DefaultOptimizingService refactoring:
- pollTask/ackTask/completeTask delegate to OptimizerExecuteEngine when available
- authenticate registers with QuotaManager for new flow
- Old OptimizingQueue path preserved as fallback for safe migration
    @czy006
    czy006 committed Apr 8, 2026
    Configuration menu
    Copy the full SHA
    2110acf View commit details
    Browse the repository at this point in the history
Loading