From f05666ee3cb22e1c6f6d529dcd5e494d49fac422 Mon Sep 17 00:00:00 2001 From: sanderelias Date: Mon, 19 May 2025 11:57:32 +0200 Subject: [PATCH 1/2] docs: update readme and add setup instructions to contirbutors.md --- CONTRIBUTING.md | 43 ++++++++++++++++++++++++++++++++++++------- README.md | 14 ++++++++++---- 2 files changed, 46 insertions(+), 11 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index babfd561..f1bade7a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,12 +4,41 @@ We would love for you to contribute to angular-split and help make it even bette than it is today! As a contributor, here are the guidelines we would like you to follow: -- [Code of Conduct](#coc) -- [Issues and Bugs](#issue) -- [Feature Requests](#feature) -- [Submission Guidelines](#submit) -- [Coding Rules](#rules) -- [Commit Message Guidelines](#commit) +- [Contributing to angular-split](#contributing-to-angular-split) + - [ Setting up your Environment](#-setting-up-your-environment) + - [ Code of Conduct](#-code-of-conduct) + - [ Got a Question or Problem?](#-got-a-question-or-problem) + - [ Found an Issue?](#-found-an-issue) + - [ Want a Feature?](#-want-a-feature) + - [ Submission Guidelines](#-submission-guidelines) + - [ Submitting an Issue](#-submitting-an-issue) + - [ Submitting a Pull Request (PR)](#-submitting-a-pull-request-pr) + - [After your pull request is merged](#after-your-pull-request-is-merged) + - [ Coding Rules](#-coding-rules) + - [ Commit Message Guidelines](#-commit-message-guidelines) + - [Commit Message Format](#commit-message-format) + - [Revert](#revert) + - [Type](#type) + - [Scope](#scope) + - [TODO](#todo) + - [Subject](#subject) + - [Body](#body) + - [Footer](#footer) + +## Setting up your Environment + +To set up your environment to work on angular-split, follow these steps: + +1. **Fork the repository** on GitHub to your own account. +2. **Clone the repository** to your local machine +3. **Install the dependencies**: `npm install` + + > Note: If you are using a version of Node.js that is not supported by angular-split, you might need to use `nvm` (Node Version Manager) to switch to a compatible version. The recommended version is Node.js 22.x LTS or later. + +4. **build and run the project by**: `npm run start --watch` + +For windows users, we expect you to use the WSL, as we set up the project to work with github actions. Make sure to check out the project and run the commands in the WSL terminal. +It might work outside the WSL when you delete the `package-lock.json` file, but we cannot guarantee that it will work. (also, make sure you don't commit that `package-lock.json`, as it will break the build for other users). ## Code of Conduct @@ -190,7 +219,7 @@ Must be one of the following: The scope should be the name of the module affected as perceived by the person reading changelog generated from the commit messages. The following is the list of supported scopes (there might be more added in the fututre): - + ## TODO There are currently a few exceptions to the "use package name" rule: diff --git a/README.md b/README.md index 5237566c..de4af6ad 100644 --- a/README.md +++ b/README.md @@ -5,13 +5,19 @@ Angular UI library to split views and allow dragging to resize areas using CSS g Documentation and examples: [https://angular-split.github.io](https://angular-split.github.io) -### Credits +## Credits -#### Built by [Bertrand Gaillard](https://github.com/bertrandg) +### Built by [Bertrand Gaillard](https://github.com/bertrandg) -#### Maintained by: [Bram Borggreve](https://github.com/beeman) (As of 2020) +### Maintained by: (As of 2024) -#### Previously: [Bertrand Gaillard](https://github.com/bertrandg) (2016 to 2019) +- [Jeffrey Bosch](https://jefiozie.github.io) + [Sander Elias](https://github.com/SanderElias) + +#### Previously + +- maintained by: [Bram Borggreve](https://github.com/beeman) (As of 2020) +- build and maintained [Bertrand Gaillard](https://github.com/bertrandg) (2016 to 2019) ## Contributors From dda856f8b876bec38df74a780732e27abd2f1ab9 Mon Sep 17 00:00:00 2001 From: sanderelias Date: Mon, 19 May 2025 12:11:14 +0200 Subject: [PATCH 2/2] docs: small fix in readme --- README.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index de4af6ad..2c907fd4 100644 --- a/README.md +++ b/README.md @@ -12,12 +12,13 @@ Documentation and examples: ### Maintained by: (As of 2024) - [Jeffrey Bosch](https://jefiozie.github.io) - [Sander Elias](https://github.com/SanderElias) +- [Sander Elias](https://github.com/SanderElias) +- [harpush](https://github.com/Harpush) #### Previously -- maintained by: [Bram Borggreve](https://github.com/beeman) (As of 2020) -- build and maintained [Bertrand Gaillard](https://github.com/bertrandg) (2016 to 2019) +- Maintained by: [Bram Borggreve](https://github.com/beeman) (2020 to 2024) +- Build and maintained [Bertrand Gaillard](https://github.com/bertrandg) (2016 to 2019) ## Contributors