fix($sniffer): report history false on Android < 4

vojtajina · vojtajina · commit 7b739c97028b · 2012-05-14T15:12:51.000-07:00
Android has history.pushState, but it does not update the location correctly: http://code.google.com/p/android/issues/detail?id=17471 Closes #904
diff --git a/src/ng/sniffer.js b/src/ng/sniffer.js
@@ -14,10 +14,15 @@
  */
 function $SnifferProvider() {
   this.$get = ['$window', function($window) {
-    var eventSupport = {};
+    var eventSupport = {},
+        android = int((/android (\d+)/.exec(lowercase($window.navigator.userAgent)) || [])[1]);
 
     return {
-      history: !!($window.history && $window.history.pushState),
+      // Android has history.pushState, but it does not update location correctly
+      // so let's not use the history API at all.
+      // http://code.google.com/p/android/issues/detail?id=17471
+      // https://github.com/angular/angular.js/issues/904
+      history: !!($window.history && $window.history.pushState && !(android < 4)),
       hashchange: 'onhashchange' in $window &&
                   // IE8 compatible mode lies
                   (!$window.document.documentMode || $window.document.documentMode > 7),
diff --git a/test/ng/anchorScrollSpec.js b/test/ng/anchorScrollSpec.js
@@ -51,7 +51,8 @@ describe('$anchorScroll', function() {
     elmSpy = {};
     $provide.value('$window', {
       scrollTo: jasmine.createSpy('$window.scrollTo'),
-      document: document
+      document: document,
+      navigator: {}
     });
   }));
 
diff --git a/test/ng/logSpec.js b/test/ng/logSpec.js
@@ -6,7 +6,7 @@ describe('$log', function() {
 
 
   beforeEach(module(function($provide){
-    $window = {};
+    $window = {navigator: {}};
     logger = '';
     log = function() { logger+= 'log;'; };
     warn = function() { logger+= 'warn;'; };
diff --git a/test/ng/snifferSpec.js b/test/ng/snifferSpec.js
@@ -3,6 +3,7 @@
 describe('$sniffer', function() {
 
   function sniffer($window) {
+    $window.navigator = {};
     return new $SnifferProvider().$get[1]($window);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`describe('$sniffer', function() {`
`4`	`4`
`5`	`5`	`function sniffer($window) {`
	`6`	`+ $window.navigator = {};`
`6`	`7`	`return new $SnifferProvider().$get[1]($window);`
`7`	`8`	`}`
`8`	`9`