Skip to content

feat: update grpc-java to the newer version; handle introduced StatusException #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsavoie merged 3 commits into from
Dec 5, 2025
Merged

feat: update grpc-java to the newer version; handle introduced StatusException #488

ehsavoie merged 3 commits into from
Dec 5, 2025

Conversation

@anFatum
Copy link
Contributor

@anFatum anFatum commented Nov 26, 2025

Description

Update the grpc-java used to the latest available release - 1.77. It introduces the StatusException on the BlockingClientCall, add adjustments for this case as well.

I've run the tests and they all finished successfully:

[INFO] --------------------------------[ pom ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Java SDK A2A Parent 0.4.0.Alpha1-SNAPSHOT:
[INFO] 
[INFO] Java SDK A2A Parent ................................ SUCCESS [  0.006 s]
[INFO] A2A Java SDK - BOM Test Utilities .................. SUCCESS [  1.071 s]
[INFO] Java SDK A2A Common ................................ SUCCESS [  0.211 s]
[INFO] Java SDK A2A Spec .................................. SUCCESS [  1.999 s]
[INFO] Java SDK A2A HTTP Client ........................... SUCCESS [  1.993 s]
[INFO] Java SDK A2A Client Transport: SPI ................. SUCCESS [  0.777 s]
[INFO] Java SDK A2A Client Transport: JSONRPC ............. SUCCESS [  5.879 s]
[INFO] Java SDK A2A Spec: gRPC ............................ SUCCESS [  1.466 s]
[INFO] Java SDK A2A Client Transport: gRPC ................ SUCCESS [  0.058 s]
[INFO] Java SDK A2A Client Transport: JSON+HTTP/REST ...... SUCCESS [  4.507 s]
[INFO] Java SDK A2A Client ................................ SUCCESS [  5.255 s]
[INFO] Java SDK A2A Examples: Hello World ................. SUCCESS [  0.019 s]
[INFO] Java SDK A2A Examples .............................. SUCCESS [  0.801 s]
[INFO] Java SDK A2A Core .................................. SUCCESS [ 16.824 s]
[INFO] Java A2A SDK Server Tests Common ................... SUCCESS [  0.094 s]
[INFO] A2A Java SDK - MicroProfile Config Integration ..... SUCCESS [  5.229 s]
[INFO] Java A2A Reference Server: Common .................. SUCCESS [  0.451 s]
[INFO] Java SDK A2A Transport: JSONRPC .................... SUCCESS [  3.347 s]
[INFO] Java A2A Reference Server: JSONRPC ................. SUCCESS [ 31.455 s]
[INFO] Java SDK A2A Examples .............................. SUCCESS [  1.216 s]
[INFO] A2A Java SDK :: Extras :: Common ................... SUCCESS [  0.023 s]
[INFO] Java A2A Extras: JPA Database TaskStore ............ SUCCESS [ 15.282 s]
[INFO] Java A2A Extras: JPA Database PushNotificationConfigStore SUCCESS [ 11.814 s]
[INFO] Java A2A Extras: Replicated Queue Manager Parent ... SUCCESS [  0.001 s]
[INFO] Java A2A Extras: Replicated Queue Manager Core ..... SUCCESS [  1.550 s]
[INFO] Java A2A Extras: Replicated Queue Manager MicroProfile Reactive Messaging SUCCESS [  2.447 s]
[INFO] A2A Java SDK - Cloud Deployment Example Server ..... SUCCESS [  1.379 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Single Instance SUCCESS [ 14.694 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance Parent SUCCESS [  0.001 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance Common SUCCESS [  0.032 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance App 1 SUCCESS [  0.058 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance App 2 SUCCESS [  0.058 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance Tests SUCCESS [01:00 min]
[INFO] Java SDK A2A Transport: gRPC ....................... SUCCESS [  2.817 s]
[INFO] Java A2A Reference Server: gRPC .................... SUCCESS [ 26.423 s]
[INFO] Java SDK A2A Transport: JSON+HTTP/REST ............. SUCCESS [  1.915 s]
[INFO] Java A2A Reference Server: JSON+HTTP/REST .......... SUCCESS [ 29.314 s]
[INFO] Java SDK A2A TCK Server ............................ SUCCESS [  1.405 s]
[INFO] A2A Java SDK - BOM ................................. SUCCESS [  0.015 s]
[INFO] A2A Java SDK - Extras BOM .......................... SUCCESS [  0.001 s]
[INFO] A2A Java SDK - Reference Implementations BOM ....... SUCCESS [  0.000 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  04:16 min
[INFO] Finished at: 2025-11-26T14:02:51Z
[INFO] ------------------------------------------------------------------------

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 26, 2025

Summary of Changes

Hello @anFatum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a critical dependency update, upgrading the grpc-java library to its latest version, 1.77.0. This update necessitates changes to how gRPC errors are handled, specifically by accommodating the newly introduced StatusException in blocking client calls. The modifications ensure continued compatibility and reliable error propagation within the A2A client transport, maintaining the stability and functionality of gRPC communications.

Highlights

  • gRPC Library Update: The grpc-java library has been updated to version 1.77.0, bringing the project up to date with the latest gRPC features and fixes.
  • StatusException Handling: Introduced StatusException handling, which is a new exception type that can be thrown by blocking gRPC client calls in the updated library. This ensures robust error management across the gRPC transport layer.
  • Generalized Error Mapping: The GrpcErrorMapper has been refactored to accept a more general Throwable type and utilize Status.fromThrowable(e), allowing it to correctly map both StatusRuntimeException and the newly introduced StatusException to internal A2A client exceptions.
  • Blocking Client Call Signature Changes: All blocking gRPC client methods in A2AServiceGrpc.java now explicitly declare throws io.grpc.StatusException and use the io.grpc.stub.ClientCalls.blockingV2UnaryCall method, aligning with the updated gRPC API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the grpc-java library to version 1.77.0 and correctly handles the newly introduced StatusException in the GrpcTransport and A2AServiceGrpc classes. The pom.xml update reflects the version change. The changes are well-contained and address the stated goal of the PR. One minor documentation update is suggested for clarity.

@anFatum
Copy link
Contributor Author

anFatum commented Nov 27, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates grpc-java to version 1.77.0 and adapts the codebase to handle the StatusException introduced in blocking calls. The changes are well-executed: the POM file is updated, the generated gRPC stub reflects the new exception signatures, GrpcTransport correctly catches both StatusRuntimeException and StatusException for blocking calls, and GrpcErrorMapper is appropriately generalized to handle any Throwable. The implementation is solid and addresses the core requirements of the library upgrade. I've included one suggestion to improve the maintainability of the error mapping logic.

@kabir
Copy link
Collaborator

kabir commented Dec 2, 2025

Hi @anFatum we're currently working on a big refactoring touching gRPC. We will give your PR attention once that is in. Thanks!

@anFatum
Copy link
Contributor Author

anFatum commented Dec 2, 2025

Thank you @kabir for an update!

@ehsavoie
Copy link
Collaborator

ehsavoie commented Dec 5, 2025

@anFatum Could you please rebase your changes

@ehsavoie ehsavoie merged commit 46793cf into a2aproject:main Dec 5, 2025
10 checks passed
@jmesnil jmesnil added this to the 1.0.0 milestone Dec 11, 2025
kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@anFatum @kabir
feat: update grpc-java to the newer version; handle introduced Status…
1b047ff 
…Exception (a2aproject#488)

# Description

Update the [grpc-java](https://github.com/grpc/grpc-java/releases) used
to the latest available release - 1.77. It introduces the
StatusException on the BlockingClientCall, add adjustments for this case
as well.

I've run the tests and they all finished successfully: 
```
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Java SDK A2A Parent 0.4.0.Alpha1-SNAPSHOT:
[INFO] 
[INFO] Java SDK A2A Parent ................................ SUCCESS [  0.006 s]
[INFO] A2A Java SDK - BOM Test Utilities .................. SUCCESS [  1.071 s]
[INFO] Java SDK A2A Common ................................ SUCCESS [  0.211 s]
[INFO] Java SDK A2A Spec .................................. SUCCESS [  1.999 s]
[INFO] Java SDK A2A HTTP Client ........................... SUCCESS [  1.993 s]
[INFO] Java SDK A2A Client Transport: SPI ................. SUCCESS [  0.777 s]
[INFO] Java SDK A2A Client Transport: JSONRPC ............. SUCCESS [  5.879 s]
[INFO] Java SDK A2A Spec: gRPC ............................ SUCCESS [  1.466 s]
[INFO] Java SDK A2A Client Transport: gRPC ................ SUCCESS [  0.058 s]
[INFO] Java SDK A2A Client Transport: JSON+HTTP/REST ...... SUCCESS [  4.507 s]
[INFO] Java SDK A2A Client ................................ SUCCESS [  5.255 s]
[INFO] Java SDK A2A Examples: Hello World ................. SUCCESS [  0.019 s]
[INFO] Java SDK A2A Examples .............................. SUCCESS [  0.801 s]
[INFO] Java SDK A2A Core .................................. SUCCESS [ 16.824 s]
[INFO] Java A2A SDK Server Tests Common ................... SUCCESS [  0.094 s]
[INFO] A2A Java SDK - MicroProfile Config Integration ..... SUCCESS [  5.229 s]
[INFO] Java A2A Reference Server: Common .................. SUCCESS [  0.451 s]
[INFO] Java SDK A2A Transport: JSONRPC .................... SUCCESS [  3.347 s]
[INFO] Java A2A Reference Server: JSONRPC ................. SUCCESS [ 31.455 s]
[INFO] Java SDK A2A Examples .............................. SUCCESS [  1.216 s]
[INFO] A2A Java SDK :: Extras :: Common ................... SUCCESS [  0.023 s]
[INFO] Java A2A Extras: JPA Database TaskStore ............ SUCCESS [ 15.282 s]
[INFO] Java A2A Extras: JPA Database PushNotificationConfigStore SUCCESS [ 11.814 s]
[INFO] Java A2A Extras: Replicated Queue Manager Parent ... SUCCESS [  0.001 s]
[INFO] Java A2A Extras: Replicated Queue Manager Core ..... SUCCESS [  1.550 s]
[INFO] Java A2A Extras: Replicated Queue Manager MicroProfile Reactive Messaging SUCCESS [  2.447 s]
[INFO] A2A Java SDK - Cloud Deployment Example Server ..... SUCCESS [  1.379 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Single Instance SUCCESS [ 14.694 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance Parent SUCCESS [  0.001 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance Common SUCCESS [  0.032 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance App 1 SUCCESS [  0.058 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance App 2 SUCCESS [  0.058 s]
[INFO] Java A2A Extras: Replicated Queue Manager Tests - Multi Instance Tests SUCCESS [01:00 min]
[INFO] Java SDK A2A Transport: gRPC ....................... SUCCESS [  2.817 s]
[INFO] Java A2A Reference Server: gRPC .................... SUCCESS [ 26.423 s]
[INFO] Java SDK A2A Transport: JSON+HTTP/REST ............. SUCCESS [  1.915 s]
[INFO] Java A2A Reference Server: JSON+HTTP/REST .......... SUCCESS [ 29.314 s]
[INFO] Java SDK A2A TCK Server ............................ SUCCESS [  1.405 s]
[INFO] A2A Java SDK - BOM ................................. SUCCESS [  0.015 s]
[INFO] A2A Java SDK - Extras BOM .......................... SUCCESS [  0.001 s]
[INFO] A2A Java SDK - Reference Implementations BOM ....... SUCCESS [  0.000 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  04:16 min
[INFO] Finished at: 2025-11-26T14:02:51Z
[INFO] ------------------------------------------------------------------------
```

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [X] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md).
- [X] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- Important Prefixes for
[release-please](https://github.com/googleapis/release-please):
- `fix:` which represents bug fixes, and correlates to a
[SemVer](https://semver.org/) patch.
- `feat:` represents a new feature, and correlates to a SemVer minor.
- `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking
change (indicated by the `!`) and will result in a SemVer major.
- [X] Ensure the tests pass
- [X] Appropriate READMEs were updated (if necessary)


Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@anFatum @kabir @ehsavoie @jmesnil