-
Notifications
You must be signed in to change notification settings - Fork 110
ci: add Java version matrix (17, 21, 24) to run-tck workflow #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
- Updated run-tck.yml to use a matrix strategy - Tests will now run against Java versions 17, 21, and 24 - Fixes a2aproject#314
b2304c6 to
4bbfa68
Compare
fjuma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @whatsupsumit!
|
Shouldn't we use 25 instead of 24 now that 25 is GA ? |
|
@whatsupsumit Thanks! It seem @ehsavoie is right, my bad. It seems that 25, NOT 24, is the LTS release. Would you be able to replace 24 with 25? Sorry for the inconvenience |
|
Sure ...I can do that |
- Updated Java matrix to use version 25 instead of 24 (now GA) - Upgraded actions/setup-java from v4 to v5 - Tests will run against Java 17, 21, and 25
|
gotcha ! I made the changes...🫡 |
- Added profile to exclude KafkaReplicationIntegrationTest on Java 24+ - Follows existing pattern from push-notification-config-store-database-jpa - Addresses Vert.x 4.5.x incompatibility with Java 24+ in Quarkus 3.28.x - Tests will skip problematic integration tests on Java 25 while keeping unit tests
|
@whatsupsumit Thank you. I know I did the KafkaReplicationIntegrationTest exclusion the other day, and am quite sure I committed it. So I was surprised to see it added here, but looking in the main branch I don't see it there. So that is strange, but thank you for picking up on that :-) |
…ect#323) - Updated run-tck.yml to use a matrix strategy - Tests will now run against Java versions 17, 21, and 24 - Fixes a2aproject#314 <img width="1438" height="978" alt="Screenshot 2025-10-01 232520" src="proxy.php?url=https%3A%2F%2Fgithub.com%2Fa2aproject%2Fa2a-java%2Fpull%2F%3Ca+href%3D"https://github.com/user-attachments/assets/9b05e006-5d6f-4c79-b6fe-d3b3ae571bc4">https://github.com/user-attachments/assets/9b05e006-5d6f-4c79-b6fe-d3b3ae571bc4" /> # Description Added a matrix strategy to the tck-test job with Java versions: [17, 21, 24] Updated the JDK setup step to use ${{ matrix.java-version }} instead of hardcoded '17' Updated the step name to dynamically show which Java version is being used Fixes #<314> 🦕
Description
Added a matrix strategy to the tck-test job with Java versions: [17, 21, 24]
Updated the JDK setup step to use ${{ matrix.java-version }} instead of hardcoded '17'
Updated the step name to dynamically show which Java version is being used
Fixes #<314> 🦕