Skip to content

Conversation

@whatsupsumit
Copy link
Contributor

Screenshot 2025-10-01 232520

Description

Added a matrix strategy to the tck-test job with Java versions: [17, 21, 24]
Updated the JDK setup step to use ${{ matrix.java-version }} instead of hardcoded '17'
Updated the step name to dynamically show which Java version is being used

Fixes #<314> 🦕

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

- Updated run-tck.yml to use a matrix strategy
- Tests will now run against Java versions 17, 21, and 24
- Fixes a2aproject#314
@whatsupsumit whatsupsumit changed the title Add Java version matrix (17, 21, 24) to run-tck workflow ci: add Java version matrix (17, 21, 24) to run-tck workflow Oct 1, 2025
Copy link
Collaborator

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whatsupsumit!

@fjuma fjuma requested a review from kabir October 1, 2025 18:28
@ehsavoie
Copy link
Collaborator

ehsavoie commented Oct 2, 2025

Shouldn't we use 25 instead of 24 now that 25 is GA ?
Maybe we could upgrade the version of actions/setup-java@v4 toactions/setup-java@v5

@kabir
Copy link
Collaborator

kabir commented Oct 2, 2025

@whatsupsumit Thanks! It seem @ehsavoie is right, my bad. It seems that 25, NOT 24, is the LTS release.

Would you be able to replace 24 with 25? Sorry for the inconvenience

@whatsupsumit
Copy link
Contributor Author

Sure ...I can do that

- Updated Java matrix to use version 25 instead of 24 (now GA)
- Upgraded actions/setup-java from v4 to v5
- Tests will run against Java 17, 21, and 25
@whatsupsumit
Copy link
Contributor Author

gotcha ! I made the changes...🫡

- Added profile to exclude KafkaReplicationIntegrationTest on Java 24+
- Follows existing pattern from push-notification-config-store-database-jpa
- Addresses Vert.x 4.5.x incompatibility with Java 24+ in Quarkus 3.28.x
- Tests will skip problematic integration tests on Java 25 while keeping unit tests
@kabir
Copy link
Collaborator

kabir commented Oct 2, 2025

@whatsupsumit Thank you.

I know I did the KafkaReplicationIntegrationTest exclusion the other day, and am quite sure I committed it. So I was surprised to see it added here, but looking in the main branch I don't see it there. So that is strange, but thank you for picking up on that :-)

@kabir kabir merged commit cfb3cd9 into a2aproject:main Oct 2, 2025
9 of 11 checks passed
kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
…ect#323)

- Updated run-tck.yml to use a matrix strategy
- Tests will now run against Java versions 17, 21, and 24
- Fixes a2aproject#314 

<img width="1438" height="978" alt="Screenshot 2025-10-01 232520"
src="proxy.php?url=https%3A%2F%2Fgithub.com%2Fa2aproject%2Fa2a-java%2Fpull%2F%3Ca+href%3D"https://github.com/user-attachments/assets/9b05e006-5d6f-4c79-b6fe-d3b3ae571bc4">https://github.com/user-attachments/assets/9b05e006-5d6f-4c79-b6fe-d3b3ae571bc4"
/>


# Description
Added a matrix strategy to the tck-test job with Java versions: [17, 21,
24]
Updated the JDK setup step to use ${{ matrix.java-version }} instead of
hardcoded '17'
Updated the step name to dynamically show which Java version is being
used

Fixes #<314> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[chore]: Upgrade the run-tck GitHub Actions workflow to test with more Java versions

4 participants