Admin UI: Fix nested landmark in Page header#78001
Merged
Merged
Conversation
The Page header was rendered as a `<header>` element nested inside NavigableRegion's `role="region"` wrapper. Because `role="region"` is not an HTML sectioning element, the inner `<header>` retained its implicit `banner` role, producing a banner landmark nested inside a region landmark. Drop the `<header>` element so the wrapping region remains the sole landmark for the page surface.
|
Size Change: -210 B (0%) Total Size: 7.92 MB 📦 View Changed
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
I think this PR should be backported to 7.0. Since it cannot be cherry-picked automatically, I have manually submitted a PR: #78002 |
|
Flaky tests detected in 82ba6a6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25548678909
|
6 tasks
Open
10 tasks
ciampo
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
LGTM 🚀
The reason for the change explained in the PR description is correct. A few links to support the decision:
- Primary: https://www.w3.org/TR/html-aria/#el-header (the explicit role-mapping rule)
- Background: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/#banner (APG: there should generally be only one banner per page, scoped to the site, not a sub-view)
- WHATWG HTML on : https://html.spec.whatwg.org/multipage/sections.html#the-header-element (definition of the element itself)
Should we add a CHANGELOG entry before merging?
Contributor
Author
|
Thanks for the review!
👍 |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
t-hamano
added a commit
that referenced
this pull request
May 8, 2026
) * Admin UI: change default heading level from h2 to h1 (#77617) * admin-ui: Change default heading level to 1 in Page Header * Update CHANGELOG.md * Update all pages * Remove heading level from experimental Dashboard * edit-site: Explicitly set headingLevel=2 for Page components in site editor These Page components are rendered inside nested landmark regions within the site editor layout, where h2 is the semantically correct heading level. They were relying on the old default of 2 which changed to 1. Co-authored-by: simison <simison@git.wordpress.org> Co-authored-by: retrofox <retrofox@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> * Admin UI: Fix nested landmark in Page header The Page header was rendered as a `<header>` element nested inside NavigableRegion's `role="region"` wrapper. Because `role="region"` is not an HTML sectioning element, the inner `<header>` retained its implicit `banner` role, producing a banner landmark nested inside a region landmark. Drop the `<header>` element so the wrapping region remains the sole landmark for the page surface. * Admin UI: Add CHANGELOG entry for nested landmark fix Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: simison <simison@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
May 14, 2026
This updates the pinned hash from the `gutenberg` from `c15cef1d6b07f666df28dac0383bafb0edfe0914 ` to `3a4e8d1418d25da83b70158bcaabf65580690b6b`. The following changes are included: - [WP.7.0] Admin UI: Backport accessibility fixes (WordPress/gutenberg#77617, WordPress/gutenberg#78001) (WordPress/gutenberg#78002) - Fix: Shortcode block does not render in Navigation Overlay (WordPress/gutenberg#77511) - feat: Enhance Connectors page on read-only file system (WordPress/gutenberg#77521) - Connectors: Avoid using centered text (WordPress/gutenberg#78125) - Revisions: Add tooltip to diff marker buttons (WordPress/gutenberg#77690) - Add backport for WP_ALLOW_COLLABORATION (WordPress/gutenberg#78160) - Add aria-label to Revisions button in Post Summary sidebar (WordPress/gutenberg#78140) - Revisions diff markers: enforce 24×24px minimum target size (WCAG 2.5.8) (WordPress/gutenberg#77671) - Connectors: Replace @wordpress/ui Link and Notice usage (WordPress/gutenberg#78117) - Connectors: Increase right padding of callout for mobile layout (WordPress/gutenberg#78126) - isFulfilled: don't change resolution state, call in resolveSelect (WordPress/gutenberg#78201) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) (WordPress/gutenberg#78286) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/c15cef1d6b07f666df28dac0383bafb0edfe0914…3a4e8d1418d25da83b70158bcaabf65580690b6b. Log created with: git log --reverse --format="- %s" c15cef1d6b07f666df28dac0383bafb0edfe0914..3a4e8d1418d25da83b70158bcaabf65580690b6b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62360 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
May 14, 2026
This updates the pinned hash from the `gutenberg` from `c15cef1d6b07f666df28dac0383bafb0edfe0914 ` to `3a4e8d1418d25da83b70158bcaabf65580690b6b`. The following changes are included: - [WP.7.0] Admin UI: Backport accessibility fixes (WordPress/gutenberg#77617, WordPress/gutenberg#78001) (WordPress/gutenberg#78002) - Fix: Shortcode block does not render in Navigation Overlay (WordPress/gutenberg#77511) - feat: Enhance Connectors page on read-only file system (WordPress/gutenberg#77521) - Connectors: Avoid using centered text (WordPress/gutenberg#78125) - Revisions: Add tooltip to diff marker buttons (WordPress/gutenberg#77690) - Add backport for WP_ALLOW_COLLABORATION (WordPress/gutenberg#78160) - Add aria-label to Revisions button in Post Summary sidebar (WordPress/gutenberg#78140) - Revisions diff markers: enforce 24×24px minimum target size (WCAG 2.5.8) (WordPress/gutenberg#77671) - Connectors: Replace @wordpress/ui Link and Notice usage (WordPress/gutenberg#78117) - Connectors: Increase right padding of callout for mobile layout (WordPress/gutenberg#78126) - isFulfilled: don't change resolution state, call in resolveSelect (WordPress/gutenberg#78201) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) (WordPress/gutenberg#78286) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/c15cef1d6b07f666df28dac0383bafb0edfe0914…3a4e8d1418d25da83b70158bcaabf65580690b6b. Log created with: git log --reverse --format="- %s" c15cef1d6b07f666df28dac0383bafb0edfe0914..3a4e8d1418d25da83b70158bcaabf65580690b6b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. Built from https://develop.svn.wordpress.org/branches/7.0@62360 git-svn-id: http://core.svn.wordpress.org/branches/7.0@61641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
May 14, 2026
This updates the pinned hash from the `gutenberg` from `c15cef1d6b07f666df28dac0383bafb0edfe0914 ` to `3a4e8d1418d25da83b70158bcaabf65580690b6b`. The following changes are included: - [WP.7.0] Admin UI: Backport accessibility fixes (WordPress/gutenberg#77617, WordPress/gutenberg#78001) (WordPress/gutenberg#78002) - Fix: Shortcode block does not render in Navigation Overlay (WordPress/gutenberg#77511) - feat: Enhance Connectors page on read-only file system (WordPress/gutenberg#77521) - Connectors: Avoid using centered text (WordPress/gutenberg#78125) - Revisions: Add tooltip to diff marker buttons (WordPress/gutenberg#77690) - Add backport for WP_ALLOW_COLLABORATION (WordPress/gutenberg#78160) - Add aria-label to Revisions button in Post Summary sidebar (WordPress/gutenberg#78140) - Revisions diff markers: enforce 24×24px minimum target size (WCAG 2.5.8) (WordPress/gutenberg#77671) - Connectors: Replace @wordpress/ui Link and Notice usage (WordPress/gutenberg#78117) - Connectors: Increase right padding of callout for mobile layout (WordPress/gutenberg#78126) - isFulfilled: don't change resolution state, call in resolveSelect (WordPress/gutenberg#78201) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) (WordPress/gutenberg#78286) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/c15cef1d6b07f666df28dac0383bafb0edfe0914…3a4e8d1418d25da83b70158bcaabf65580690b6b. Log created with: `git log --reverse --format="- %s" c15cef1d6b07f666df28dac0383bafb0edfe0914..3a4e8d1418d25da83b70158bcaabf65580690b6b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy` Reviewed by desrosj. Merges [62360] to `trunk`. See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@62361 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
May 14, 2026
This updates the pinned hash from the `gutenberg` from `c15cef1d6b07f666df28dac0383bafb0edfe0914 ` to `3a4e8d1418d25da83b70158bcaabf65580690b6b`. The following changes are included: - [WP.7.0] Admin UI: Backport accessibility fixes (WordPress/gutenberg#77617, WordPress/gutenberg#78001) (WordPress/gutenberg#78002) - Fix: Shortcode block does not render in Navigation Overlay (WordPress/gutenberg#77511) - feat: Enhance Connectors page on read-only file system (WordPress/gutenberg#77521) - Connectors: Avoid using centered text (WordPress/gutenberg#78125) - Revisions: Add tooltip to diff marker buttons (WordPress/gutenberg#77690) - Add backport for WP_ALLOW_COLLABORATION (WordPress/gutenberg#78160) - Add aria-label to Revisions button in Post Summary sidebar (WordPress/gutenberg#78140) - Revisions diff markers: enforce 24×24px minimum target size (WCAG 2.5.8) (WordPress/gutenberg#77671) - Connectors: Replace @wordpress/ui Link and Notice usage (WordPress/gutenberg#78117) - Connectors: Increase right padding of callout for mobile layout (WordPress/gutenberg#78126) - isFulfilled: don't change resolution state, call in resolveSelect (WordPress/gutenberg#78201) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) (WordPress/gutenberg#78286) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/c15cef1d6b07f666df28dac0383bafb0edfe0914…3a4e8d1418d25da83b70158bcaabf65580690b6b. Log created with: `git log --reverse --format="- %s" c15cef1d6b07f666df28dac0383bafb0edfe0914..3a4e8d1418d25da83b70158bcaabf65580690b6b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy` Reviewed by desrosj. Merges [62360] to `trunk`. See #64595. Built from https://develop.svn.wordpress.org/trunk@62361 git-svn-id: http://core.svn.wordpress.org/trunk@61642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dd32
pushed a commit
to dd32/jetpack
that referenced
this pull request
May 20, 2026
…utomattic#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct.
matticbot
pushed a commit
to Automattic/jetpack-production
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
matticbot
pushed a commit
to Automattic/jetpack-mu-wpcom-plugin
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
matticbot
pushed a commit
to Automattic/jetpack-base-styles
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
matticbot
pushed a commit
to Automattic/wpcom-site-helper
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
matticbot
pushed a commit
to Automattic/jetpack-search
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
matticbot
pushed a commit
to Automattic/jetpack-search-plugin
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
matticbot
pushed a commit
to Automattic/jetpack-scan-page
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
matticbot
pushed a commit
to Automattic/jetpack-activity-log
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
matticbot
pushed a commit
to Automattic/jetpack-newsletter
that referenced
this pull request
May 20, 2026
…#49006) * Base styles: Fix admin-page-layout header selector for admin-ui 2.1 @wordpress/admin-ui 2.1.0 (Gutenberg PR WordPress/gutenberg#78001) removed render={ <header /> } from the Page header's Stack, so the rendered element changed from <header> to <div>. The mixin's > header selectors silently stopped matching and the header was no longer pinned at the top of the flex column. Anchor to > :first-child instead — Page always renders its Header as the first child of the page wrapper, regardless of element type. Forward-compatible with 2.1+ and backward-compatible with 2.0. * Base styles: extend admin-page-layout `:first-child` fix to the scrollable-middle selector Mirrors the selector change in 8e4d22a6 onto the `:not(header)` companion rule. Same upstream cause — admin-ui 2.1 renders the page header as a `<div>` instead of `<header>`, so position-based selectors are required to keep the scrollable-middle partition correct. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26180898789 Upstream-Ref: Automattic/jetpack@e17ffe2
CGastrell
added a commit
to Automattic/jetpack
that referenced
this pull request
May 22, 2026
…ader The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice.
CGastrell
added a commit
to Automattic/jetpack
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice.
matticbot
pushed a commit
to Automattic/jetpack-production
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-mu-wpcom-plugin
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-components
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-storybook
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-podcast
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-publicize
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-my-jetpack
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/classic-theme-plugin
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-social-plugin
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-starter-plugin
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-backup
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-videopress
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-protect-plugin
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-backup-plugin
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-search
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-boost-production
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/wpcom-site-helper
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-videopress-plugin
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-scan-page
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
matticbot
pushed a commit
to Automattic/jetpack-activity-log
that referenced
this pull request
May 22, 2026
….1 (#49018) * Components: fix AdminPage SCSS module header selectors for admin-ui 2.1 Replace the three `> header` selectors in the AdminPage SCSS module with `> :first-child` so they keep matching after @wordpress/admin-ui 2.1 changed the page header element from <header> to <div>. Together with #49006 (which applied the same fix to the shared admin-page-layout mixin in js-packages/base-styles), this resolves the publicize page header spacing regression that surfaced on PR #48404 — the title/subtitle ' compaction' was the cumulative effect of the three jetpack-side overrides (sticky-disable, border removal, visual-slot centering) silently ceasing to fire, not a missing gap. Also bumps @wordpress/admin-ui from 2.0.0 to 2.1.0 in this package as the consumer-side pin of the version this fix targets. * Search e2e: adapt header-logo locator to admin-ui 2.1's <div> page header The dashboard test was scoping the Jetpack Logo locator via `page.locator( 'header' )` — coupling to admin-ui 2.0's <header> element. admin-ui 2.1 renders the page header as a <div> (WordPress/gutenberg#78001), so the locator finds nothing once this PR's admin-ui pin lands. Swap the locator to `.jp-admin-page__page > :first-child` — same positional pattern this PR uses in the SCSS module, matches both the old <header> and the new <div>. Updates the surrounding comment to explain the choice. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/26291726516 Upstream-Ref: Automattic/jetpack@35d3e78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77481
What?
Removes the
<header>element from the Admin UIPageheader.Why?
Pagewraps content inNavigableRegion(role="region"). Sincerole="region"is not an HTML sectioning element, the inner<header>kept its implicitbannerrole, producing abannernested inside aregion.How?
Drop
render={ <header /> }from the outerStack. `Testing Instructions
Page(e.g. Appearance > Connectors or Settings > Connectors).bannernested in the page'sregionlandmark.Screenshots or screencast
N/A — no visual changes.
Use of AI Tools
Authored with assistance from Claude Code; reviewed by the author.